Fork me on GitHub
#tools-deps
<
2019-06-10
>
martinklepsch09:06:14

I've found another potential bug/issue, let me know if it makes sense to file an issue. With the code below we'll end up with two versions of Clojure on the classpath:

(tdeps/resolve-deps {:deps {'org.clojure/clojure {:mvn/version "1.9.0"}}
                     :mvn/repos default-repos}
                    {:extra-deps {"org.clojure/clojure" {:local/root "/Users/martinklepsch/.m2/repository/org/clojure/clojure/1.10.0-beta2/clojure-1.10.0-beta2.jar"}}})
It can be easily fixed by changing the "org.clojure/clojure" to be a symbol but I would expect tools deps to handle that(?)

alexmiller12:06:17

you can file a ticket for that

dominicm14:06:52

Feels like strings in that position should blow up

dominicm14:06:02

However, strings would make a pretty neat reference to the canonical upstream for git repos, even when you're using a separate branch

alexmiller15:06:15

it should be an error, libs are symbols