Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2019-01-14

Channels

#tools-deps
<
2019-01-14
>
borkdude19:01:31

since there is no cognitect channel and this is a tools.deps project, I’ll post it here. there’s a trivial PR lingering for a while now. I wonder why there’s no interesting in accepting it from Cognitect Labs: https://github.com/cognitect-labs/test-runner

borkdude19:01:24

I even forgot about the previous PR and made a duplicate one 🙂

Alex Miller (Clojure team)19:01:08

Sorry, Luke was minding that project and he’s not at Cognitect anymore

Alex Miller (Clojure team)19:01:33

I’ll take a look when I get a chance

borkdude19:01:58

I’ve been using it more and more. There’s also a CLJS clone of it

borkdude19:01:27

ghadi made the first PR. he is at cognitect right?

dominicm19:01:13

@U050ECB92 is this any you became a space cat wizard?

ghadi19:01:43

209b64504cb3bd3b99ecfec7937b358a879f55c1 is master now

❤️ 20
avi21:01:36

Are there any examples out there of libraries that have both a project.clj and also a deps.edn, for compatibility with both Leiningen and tools.deps, but don’t duplicate the dependency specifications? I’m interested in possibly contributing such a feature to a library I use.

dpsutton21:01:34

:plugins [[lein-tools-deps "0.4.1"]] is in one of our project.clj files. This allows the lein project to read deps out of the deps.edn file

rickmoynihan16:01:38

:plugins [[lein-tools-deps "0.4.3"]] is the latest and should be a bit quicker at resolution.

thosmos21:01:09

I've been using that for quite a while, and it works great. but now Cursive supports deps.edn directly so I mostly use that

👍 5
rickmoynihan09:01:36

lein-tools-deps is not without its issues… I should probably make them clearer on the repo.

avi13:01:19

Once I read the docs, I was up and running with no clear issues, at least not at first. Maybe some of the steps could be moved to the top of the readme, but no big deal

rickmoynihan13:01:46

Good to know… but it can cause problems if you’re not aware of how it works… and it’s not made clear yet. Essentially it currently flattens the whole transitive dependency graph. It does this to guarantee resolution is the same in both tools.deps and leiningen — but it does mean that downstream mvn resolution semantics can change.

rickmoynihan13:01:21

e.g wrt to :exclusions

avi14:01:14

That sentence seems very important… if it’s not in the readme already maybe just add it as-is?

rickmoynihan14:01:57

I think it warrants a small section covering the implications tbh — will write it at some point.

avi14:01:20

I’d be happy to review if that’d be helpful

rickmoynihan14:01:45

you’re welcome to comment on what is written — but it’ll probably be ok. Too busy to do it just now though.

rickmoynihan14:01:52

there are github issues that touch on it already

dpsutton21:01:50

Makes it very simple to use lein for building/deploying but deps.edn for dev and running

avi21:01:37

Will check it out, thank you!

hiredman21:01:37

I just pushed https://git.sr.ht/%7Ehiredman/dset/tree up over the weekend, it has both a deps.edn and a project.clj, with all the deps coming from deps.edn

lilactown00:01:55

how do you like using http://sr.ht?

hiredman00:01:18

so far all I have done is create that repo and push to it, seems fine, I appreciate that I can browse the site without letting it execute js

avi20:01:57

Great, thanks for sharing!