Fork me on GitHub
#tools-deps
<
2018-08-27
>
steveb8n01:08:52

has anyone else used cognitect.test-runner in CI? I’m finding it returns status zero when there are test failures

seancorfield01:08:03

@steveb8n Are you sure? I use it with clojure.java.jdbc and I'm pretty sure I get a non-zero status when there are failures.

seancorfield01:08:10

Are you using clojure or clj?

steveb8n01:08:18

I’m using clojure

steveb8n01:08:35

is that a possible explanation?

steveb8n01:08:04

I can reproduce on my laptop also. have looked at source and it doesn’t jive

seancorfield01:08:16

clojure is the underlying script so it should be safe(r) anyway.

seancorfield01:08:27

Are you on an older version of clj/`clojure`?

steveb8n01:08:49

nope. 1.9.0 in deps.edn

steveb8n01:08:08

I might try debug in Cursive and see if that explains it

cfleming01:08:15

@steveb8n I think @seancorfield is talking about the clj/`clojure` CLI scripts, not Clojure itself.

steveb8n01:08:39

oh good point. I’ll check

steveb8n01:08:00

when I run from repl I see correct results so I think Sean is right in that this is maybe the scripts masking the system/exit value

steveb8n01:08:12

just updated clojure using brew. same result sadly. will keep digging

steveb8n01:08:20

just spotted this commit. I’m on an old version of the test runner. testing new sha now

steveb8n01:08:23

that was it. thanks for the sounding board 🙂

steveb8n01:08:08

interesting challenge to keep the SHA’s in readmes current when a jar/snapshot not available in clojars. not sure how that can be improved.

alexmiller02:08:01

rub some script on it

seancorfield02:08:19

@steveb8n Sorry, stepped away. Glad you got it figured out. Not sure why a SHA is any harder to keep up to date than a Maven/Clojars dependency? You still have to go look at the project and see what's changed...

steveb8n02:08:27

fair point. I agree. I guess the exception is snapshots but I generally don’t use them anyway. also the clojars build/badge provides the latest without a readme update I believe. that’s one way that clojars beats shas for readme maintenance. anyway I’m good and I’ll check latest shas from now on. thanks all

levitanong04:08:04

What’s the difference between putting some code in "-e '(foo)'" and putting the same code in some namespace with -main, and putting it in an alias main-opt?

steveb8n05:08:30

@alexmiller interesting turn of phrase. I might “borrow” that