This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2018-05-05
Channels
- # architecture (3)
- # aws (4)
- # beginners (100)
- # boot (14)
- # cider (59)
- # cljs-dev (1)
- # cljsrn (24)
- # clojure (53)
- # clojure-dev (58)
- # clojure-italy (2)
- # clojure-spec (1)
- # clojure-uk (25)
- # clojurescript (7)
- # cryogen (1)
- # cursive (1)
- # datomic (9)
- # dirac (9)
- # duct (3)
- # off-topic (52)
- # om-next (3)
- # onyx (42)
- # portkey (28)
- # re-frame (3)
- # reagent (11)
- # rum (3)
- # shadow-cljs (12)
- # specter (7)
- # tools-deps (18)
- # vim (1)
- # yada (4)
As asked on the twitters: https://twitter.com/slipset/status/992662387600887808
Reason I’m asking is sort of at least twofold: 1) If it’s sort of the same, is there anything to be learned by the clj-refactor impl 2) If it’s sort of the same, can add-lib be used as a replacement for the clj-refactor impel so we get consistent behavior. 3) most likely just an off by one error
I'm certain it's almost entirely the same. I expect that in a few months this implementation will find it's way into refactor-nrepl.
@alexmiller Riddle me this: how does one add a maven dep and the corresponding sources and javadoc jars to the classpath? (needed for cider javadoc to work)
Not supported
Currently you can only have one artifact per library
I’m not opposed to supporting it, just trying to figure out how
@alexmiller would treating it as a unique library be insufficient?
I'd propose clojure.tools.deps.alpha/merge-alias-rules
be extended with some way to delegate merge strategy to the extension type
Uh, maybe not, that is only used to merge the same map key between different deps.edn sources
maybe clojure.tools.deps.alpha/resolve-deps
instead - when merging :extra-deps
into :deps
you still end up spitting out a map though, perhaps the key of that map needs to change from being the dependency path, to an opaque composite key that represents "a unique artifact". The dep path itself could move into the value (during resolution, not in deps.edn
itself)
That’s only used for alias types, which are not extensible
The merge-alias-rules that is
Treating it as a unique library isn’t possible as the group/artifact is used for resolution
This needs more thought and I consider it a lower priority than other stuff on the plate