Clojurians Log v2
tools-build
I wonder if there have been any thoughts on a suitable approach for https://clojure.atlassian.net/browse/TBUILD-41 (this is the Ask: https://ask.clojure.org/index.php/13802/ignore-pom-default-for-clojure-tools-build-api-write-exists ). There doesn't seem to be any existing similar precedent, so either :src-pom :none or :src-pom :ignore seem to be reasonable approaches here? Would there be interest in a PR^H^Hpatch for this?
I think I started looking at it and couldn't decide what approach to take
:src-pom :none seems fine, happy to look at a patch
would be looking for update to docstring, code, and added test in test-pom
Yup, NP. I may take a run at it this week if I need a break from the horrors that are React Native and IAP 🙂
I decided I needed a break from those horrors... how does https://github.com/clojure/tools.build/compare/master...seancorfield:tools.build:master look?
I noticed a missing not in the API doc about :pom-data, and the existing note about when :pom-data is used wasn't entirely accurate, so I updated both of those too.
If this looks reasonable, I'll make a .patch and attach it to the JIRA ticket.
I think that absence of "not" was correct?
Oh, because it refers to the existing source pom.xml, not :pom-data! Duh! Will fix.
don't modify the docs dir, those are generated
Ah, OK, I misunderstood your note about updating docs, sorry.
I meant in the api docstring, sorry if that wasn't clear
rather than add the p4 testdata, you could just reuse the existing p2 one
Well, I needed to verify the source pom.xml data was actually used -- and p2 didn't have scm
ok
The new test is essentially the test for p2 + source scm, to ensure that if the source is ignored, you get no scm.
There are no tests currently that verify existing pom.xml info is preserved 🙂
Patch created and attached to the ticket.