Am I right in that https://clojure.github.io/tools.build/clojure.tools.build.api.html#var-git-process doesn’t support failing on non-zero git exit codes? Or have I not had enough coffee yet?

@lee Based on https://github.com/clojure/tools.build/blob/master/src/main/clojure/clojure/tools/build/api.clj#L242-L244 you are correct.

Cool, thanks @seancorfield.

The underlying process function doesn't "fail", it just returns status/output stuff.

Yeah, that’s all fine. It just surprised me a bit that I could not even check the git exit code. Easy enough to do my own thing tho.

What problem are you trying to solve?

Failing my build if a git command fails for whatever reason.

(including stupid human errors)

You could use the raw process function and throw on :exit being non-zero.

Yeah thanks, am doing my own thing now. Just thought maybe git-process could use tweak. But am totally fine with not using it too.

(in other words, was trying to be helpful in confirming/highlighting a potential issue, aim was not to be complainy 😇).

yep, thanks! maybe we could throw on non-0 exit