Clojurians Log v2
Clojure programming
Channels
Apps
test-doc-blocks
lread 2025-05-20T17:30:44.775049Z
https://clojurians.slack.com/archives/C06MAR553/p1747762180763079
seancorfield 2025-05-20T17:37:01.119549Z
The 1.11 req means HoneySQL can't update easily... but I'll take a look at conditionally not doing doc tests for 1.10.
lread 2025-05-20T17:39:00.991369Z
It is for test generation only, so should not be a prob. Can do a PR if you like.
seancorfield 2025-05-20T17:39:04.357759Z
Oh, maybe I can just override the Clojure version in the generation...
lread 2025-05-20T17:39:10.659279Z
Yep!
seancorfield 2025-05-20T17:44:12.552739Z
I run all the test tasks -- and the generation task -- as subprocesses.
lread 2025-05-20T17:50:35.042359Z
I've already verified that test-doc-blocks latest works with honeysql, so I'm happy to whip up a PR if you like.
seancorfield 2025-05-20T17:51:32.054839Z
https://github.com/seancorfield/honeysql/commit/a0d815ca058e2000df6d9a89692ea3f40baee87d 🙂
lread 2025-05-20T17:52:20.688979Z
Speedy! simple_smile
seancorfield 2025-05-20T18:04:52.958709Z
I already had it open in VS Code since I was working on it over the weekend 🙂
👍 1
🎉 1
Matti Uusitalo 2025-05-21T04:47:59.182399Z
Thanks a bunch @lee! Now I can move forward to adopt this to test examples in metosin/malli.
Matti Uusitalo 2025-05-21T06:33:01.010779Z
malli is now using it too
lread 2025-05-21T10:59:43.965729Z
Thank you @matti.uusitalo117, so very nice to meet you, and it was very pleasant to work with you.
2025-05-20T17:33:39.815189Z
@skynet has joined the channel