test-check 2018-04-17

@mathpunk has joined the channel

I was trying to deal with this bug (https://github.com/clojure-emacs/cider/issues/1841), and in investigating it I discovered that test.check refers to a namespace that it doesn't have in the definition of test-context-stacktrace: https://github.com/clojure/test.check/blob/master/src/main/clojure/clojure/test/check/clojure_test/assertions.cljc#L12

I commented that line out, and my problem went away. It's not clear to me how to contribute or report that so, I'm mentioning it here

As I look at it more closely, I doubt it's that exact spot that helped; but, there are definitely several references to a clojure.test.check.clojure-test namespace. I see only a clojure_test directory, but no namespace

Alex Miller (Clojure team) 2018-04-17T04:18:53.000141Z

that’s due to someone monkey-patching clojure.test

Alex Miller (Clojure team) 2018-04-17T04:18:57.000055Z

leiningen does that

Alex Miller (Clojure team) 2018-04-17T04:19:00.000130Z

maybe others

While I did see this, I don't quiiiiite know what it means, nor what it implies about my project being a boot project

I've heard the term but only the context of 1) Ruby objects and 2) disapproval. Sometimes at once~

Alex Miller (Clojure team) 2018-04-17T04:32:15.000152Z

well this may be something similar but different, not sure. Leiningen reaches in and replaces the implementation of part of clojure.test, which breaks test.check’s expectation.

Alex Miller (Clojure team) 2018-04-17T04:32:31.000120Z

that’s a pretty dirty trick imo :)

Nice @nwjsmith. That will be very useful, also good learning material.

I'll try to spruce it up a bit this week. I think there's a ton of performance improvements available too, so I'd like to get some benchmarks around it.