Looking at the code, I think it is thread safe because it "locks" on the migration ID by insertion into a table -- so only one process can succeed -- and the process that succeeds gets to check whether to actually apply that migration ID.

Hi Sean. Does next.jdb use the connection-uri value? I grepped migratus, https://github.com/yogthos/migratus/search?q=%22connection-uri%22&type=code, seem no where it consumes it directly. The connection-uri is mentioned here, https://cljdoc.org/d/migratus/migratus/1.3.8/doc/readme#configuration:~:text=%3Adb%20%7B%3Aconnection%2Duri%20%22jdbc%3Asqlite%3Afoo_dev.db%22%7D%7D

No, next.jdbc does not accept a hash map containing :connection-uri. It would accept a JDBC connection string directly, instead, but I don't know whether Migratus would accept that for :db?

You should create an issue on the Migratus GH repo about that in the docs -- they probably just missed that when they switched from c.j.j to next.jdbc

I am considering allowing next.jdbc to accept such hash maps (both :connection-uri and :datasource) to make migrations (from c.j.j) easier...

Oh, looking at the Migratus docs further, they do accept a string for :db -- so you'd use that form instead of a hash map containing :connection-uri

https://github.com/seancorfield/next-jdbc/issues/207 (for tracking purposes)

https://clojars.org/com.github.seancorfield/next.jdbc/versions/1.2.999-SNAPSHOT supports this -- I'll create an issue on the Migratus repo to let them know about this.

I am using the jdbcUrl pluse the user and password method. Sounds like migratus supports db-spec flavour setting.

I'm confused -- :jdbcUrl is not supported by clojure.java.jdbc -- I thought you were asking about the change in Migratus from c.j.j to next.jdbc?

I would expect :db to just be passed straight through to next.jdbc, to be honest. Did you try specifying :db {:jdbcUrl ...} (with user and password)?

See https://github.com/yogthos/migratus/issues/221 -- feel free to add comments if I haven't covered what you're asking about.

hi, I did port migratus to next.jdbc. It does pass the :db spec directly to next.jdbc. We do have a bug that it does not fully support passing in a Connection or a DataSource object. I got busy with $work and did not have time to fix this issue yet. I would like for us to have tests for db-spec, Connection and DataSource. If you want and can help, don't hesitate.

thanks for reporting and @U04V70XH6 for helping out by enhancing next.jdbc