Hi all!

There are 2 cases for oracle db connection URI: jdbc:oracle:thin:@<hostName>:<portNumber>:<sid>; (if you have sid) jdbc:oracle:thin:@<hostName>:<portNumber>/serviceName; (if you have oracle service name)

The current clojure.jdbc implementation creates the second format, with "/" char.

E.g. (def my-oracle-db {:dbtype "oracle" :dbname "dbname"... creates URI jdbc:oracle:thin:@host:port/dbname

But this can't work with outdated SID connections.

Could I ask to add the check for a "sid" string, so if I write (def my-oracle-db {:dbtype "oracle" :dbname "sid:dbname"... I'll receive the following URI: jdbc:oracle:thin:@host:port:dbname

it's a java.jdbc\src\main\clojure\clojure\java\jdbc.clj:384 db-sep (if (= "sqlserver" subprotocol) ";DATABASENAME=" "/")

Here is a probable solution: db-sep (if (= "sqlserver" subprotocol) ";DATABASENAME=" "/") url (cond (= "h2:mem" dbtype) (str "jdbc:" subprotocol ":" dbname ";DB_CLOSE_DELAY=-1") (#{"derby" "h2" "hsqldb" "sqlite"} subprotocol) (str "jdbc:" subprotocol ":" dbname) + (= "oracle" dbtype) + (str "jdbc:" subprotocol ":" + (host-prefixes subprotocol "//") + host + (when port (str ":" port)) + (if (= (.indexOf (str dbname) "sid:") 0) + (str ":" (str/replace dbname #"sid:" "")) + (str "/" dbname))) :else (str "jdbc:" subprotocol ":" (host-prefixes subprotocol "//") host (when port (str ":" port)) db-sep dbname))

@kostafey Can you open a JIRA ticket with some details so I don't forget?

Here's the URL to save you digging around https://dev.clojure.org/jira/browse/JDBC

https://dev.clojure.org/jira/browse/JDBC-173

Unfortunately, I can't find how to format code in this Jira.

Thanks. I'll try to get a patch release out with that some time this week.

👍 Thank you!

It'll be better to modify this line to deal with the db-sep value

db-sep (if (= "sqlserver" subprotocol) ";DATABASENAME=" "/")

Also, I think I'd rather introduce a pseudo-subprotocol, oracle:sid, to handle this case.

But I'll give that some thought.

I don't really like the dbname having a "magic" prefix that goes away when the JDBC URL is constructed.

That's true. All solutions have their own disadvantages.

I think it's also possible to use ":" separator for all Oracle databases.

Since it works with both new and old-style connections. But probably someday later it will become deprecated.

OK, fix for that pushed to GitHub. If you're using clj/`deps.edn` you can try it out via the latest git SHA...