So I'm running into an issue using YesQL and transactions. The overall issue is that I can't get the id of a newly created record back from within the transaction. Is this just a limitation of using transactions? I tried using RETURNING in the sql but the db called it a syntax error 😕

; This prints `nil` even though the client is created in the db
(defn create-client [client-info]
    (jdbc/with-db-transaction [tx db-spec]
      (let [client (-> client-info
                     hash-password
                     create-client<! {:connection tx})]
      (println client)
      client)))

; This creates a client row and prints it to the output
(defn create-client [client-info]
    (let [client (-> client-info
                     hash-password
                     create-client<!)]
    (println client)))

It seems like create-client<! isn't returning the row like it does outside of a transaction.

It should work similarly within the transaction

reading through the yesql generate.clj file now to figure out what might be going on

You might need parenthesis around create-client<! {:connection tx} in your threading macro?

hm. I'll give that a try.

that worked! thanks so much

Np!

Any idea how it was still managing to insert?

I thought a mistake like that would have thrown an error

do you have yesql set up so that queries automatically get the db-spec?

it could be using the pre-defined one instead of the override from the {:connection tx}

oh that would make sense.

basically the create-client<! was being called without the override connection map (due to missing parens), so that’d be my guess

Yep, that’s the thing here.

You guys are great. It would have taken me quite a bit of time to notice that.

Hint: you can macroexpand threading macros to see if it turns out to something that makes sense

Like here you would’ve probably noticed that the transaction example would’ve had {:connection tx} calling the result of create-client<! 🙂

I tend to evaluate the code in as small chunks as possible. Clojure makes it fun and easy compared to almost any other language. 👍

oh. good call.