I know I’ve struggled with this before, but is there a way to get clojure.java.jdbc/query to return a sequence of string keyed maps? With {:identifiers identity} I still get keywords

PostgreSQL 10 released https://www.postgresql.org/about/news/1786/

@jonas No, it always produces keyword-keyed maps. What’s your use case?

@seancorfield I’ve got some other (string) data from elsewhere in the system, so it would be natural to work with string keys in this particular case. It’s also possible for quoted column names to not map well to keywords. i.e., (jdbc/query db "SELECT 1 as \"a column\"") is perfectly valid sql

Sometimes (perhaps not often) string keys just make more sense. For example you can opt out of keyword keys in most json parsers (for example cheshire)

@jonas of course clojure doesn’t complain about putting any old garbage in a keyword as long as you aren’t trying to get it via a reader

but yeah, that seems like a reasonable thing to want to do absolutely

@jonas Do you want to create a JIRA issue for this and I can take a look?

sure!

@seancorfield https://dev.clojure.org/jira/browse/JDBC-159

I could dig into the source as well and try to provide a patch. Or do you want to think about if we even want/need this first?

I'll need to give it some thought, as regards the right option naming.

My initial reaction is :keywordize? which will default to true for backward compatibility and I believe is common among JSON libraries?

this is happy news to me 😄

:keywordize? true makes sense. Ping me if you want a patch at some point

Thanks.

@seancorfield would you be interested in a initial perf test suite for clojure.java.jdbc?

(and some perf patches later if they have any real effect)

Regarding the specs or in general?

(either way I'm interested in performance improvements for it)