Clojurians Log v2

Hi, a question regarding specter performance Im testing the following transformation function, and i face a big difference

(defn convert-sizes-sp
  [layout]
  (sp/multi-transform
   [(sp/multi-path
     [(sp/must :size) (sp/cond-path number? (sp/terminal #(str % "fr"))
                                    keyword? (sp/terminal #(size-alias %)))]
     [(sp/submap [:y :x :z]) sp/MAP-VALS sp/ALL (sp/terminal convert-sizes-sp)])]
   layout))

(defn convert-sizes-f
  [layout]
  (cond-> layout
    (:size layout) (update :size (fn [size] (cond (number? size) (str size "fr")
                                                  (keyword? size) (size-alias size)
                                                  :else size)))
    (:x layout) (update :x (partial mapv convert-sizes-f))
    (:y layout) (update :y (partial mapv convert-sizes-f))
    (:z layout) (update :z (partial mapv convert-sizes-f))))

(let [input {:x [{:size 1} {:size 1} {:y [{:size 1} {:size 2} {:size 3}]}], :y [{:size "5px"} {:size 10}]}]
  (println (timeit 1000 (convert-sizes-sp input))) ; 600 msec
  (println (timeit 1000 (convert-sizes-f input)))  ; 12 msec
)

(defmacro timeit
          ([expr] `(timeit 1 ~expr))
          ([times expr] `(->> ~expr
                              (dotimes [_# ~times])
                              (time)
                              (with-out-str)
                              (re-find #"\d+\.\d+")
                              (js/Number))))

It’s been a few years since I’ve last needed specter, but I just wanted to provide a reiterated thanks. A few mins of re-reading the docs today and I’ve been able to quickly navigate some messy trees that sit squarely in specter’s use case.