Fork me on GitHub
#spacemacs
<
2023-09-12
>
Ho0man08:09:28

Hi everyone, I just recently reinstalled spacemacs ( emacs 29.1 and latest spacemacs and practicalli spacemacs configs) but the d s, c s commands for deleting and changing wrapping parens no longer works giving the error no surrounding delimiters found. What's wrong? I tried reinstalling emacs, spacemacs, practically config. Any help is appreciated. Thanks a lot

👀 1
practicalli-johnny08:09:37

Update: issue raised at: https://github.com/syl20bnr/spacemacs/issues/16144 I can reproduce this issue too, unfortunately. I suspect something has changed in which ever evil package includes evil-motion-range Are you able to do a package rollback? If it is a package, perhaps pinning an earlier version will fix it. I dont think its related to the Practicalli config, the only thing changed recently was commenting the syntax-checker layer (flyspell) and a tweak to the LSP idle delay. You could try enable the syntax-checker layer, but I would be surprised if its the cause (although an easy fix) Will see if I can find more details by looking for the right emacs package and similar issues.

Ho0man08:09:03

Thanks a lot, John will try both now

practicalli-johnny08:09:35

Its the layer... adding it back in seems to work. I'll push an update to the Practicalli spacemacs-config repo in a minute.

practicalli-johnny09:09:22

I've updated Practicalli Spacemacs-config repo to add the syntax-checker layer back in and the d s and c s commands work again. It seems LSP doesnt cover everything 🙂

Ho0man09:09:25

Thanks again, John But I seem to be still getting the surround error. I've enabled clj-kondo and cider on the clojure layer btw could this also be related? Should I delete any files or folders ? This is the warning after switching to the new config - (i dunno if its related though) :

■  Warning (emacs): 'syntax-checking-use-original-bitmaps' is deprecated. Use 'syntax-checking-indication-symbol' instead.
 ■  Warning (comp): /home/ho0man/.emacs.d/elpa/29.1/develop/helm-cider-20220706.944/helm-cider-spec.el: Error: Symbol's function definition is void helm-make-actions
And these are the evil-motion logs in the *Messages* buffer :
46 evil-motion-range: No surrounding delimiters found [2 times]
55 evil-motion-range: Wrong type argument: characterp, 67108873
56 evil-motion-range: No surrounding delimiters found
57 evil-motion-range: No surrounding delimiters found

practicalli-johnny09:09:20

I restart emacs after installing packages to ensure everything is loaded correctly. I also get the 'syntax-checking-use-original-bitmaps' warning, but ds and cs are working.

🙏 1
practicalli-johnny09:09:03

Although I have done a package update and they now seemed to have stopped working... so maybe there is also a package change...

practicalli-johnny10:09:16

There have been some changes in the https://github.com/emacs-evil/evil-surround/ package in the last 3-4 weeks, so an issue could have been introduced there, or perhaps within the evil/evil package which evil/surround uses... If you have a rollback from several weeks ago, then that may be the quickest fix...

🙏 1
practicalli-johnny10:09:19

With the following Emacs packages, then cs and ds work • evil-surround-20230627.2052 • evil-20230813.73720 So there seems to be a change after that fails to work, not sure exactly where or in which package as it seems the evil-cleverparens commands are being called, i.e. evil-cp-change . My guess is something has changed in evil-surround or evil that causes evil-cp-change to break.

🙏 1
practicalli-johnny10:09:40

evil-surround-20230813.2053 includes the broken functionality, so sometime between 2023-06-27 and 2023-08-13 it seems

practicalli-johnny11:09:02

@U6CE37RK6 The following recipe seems to work, pinning evil-surround to a working version. Currently testing with all updated packages. UPDATE: it works 🥳 The existing elpa/<emacs-version>/develop/evil-surround-... directory should be removed (or moved) first, then the evil-surround package will be pinned to the SHA version in the recipe below.

dotspacemacs-additional-packages '(
                                      (evil-surround
                                       :location
                                       (recipe :fetcher github
                                               :repo "emacs-evil/evil-surround"
                                               :commit "f273821f575ace519066fb106ee45a5b8577475f")))

🎉 1
Ho0man07:09:31

Thanks a lot, John

Ho0man07:09:41

I really appreciate your help

👍 1
practicalli-johnny11:09:22

https://github.com/syl20bnr/spacemacs/issues/16144: c s / d s evil change / delete surrounding parens (delimiters) commands are broken in evil-surround package on or after 27th August 2023. Add the following recipe to your Spacemacs user config, SPC f e d, if using this evil functionality and needing to carry out a package update in Spacemacs (remove the evil-surround package from elpa/<emacs-version>/develop directory if already updated after 27th August 2023 and restart to download the working package version)

dotspacemacs-additional-packages '((evil-surround
                                       :location
                                       (recipe :fetcher github
                                               :repo "emacs-evil/evil-surround"
                                               :commit "f273821f575ace519066fb106ee45a5b8577475f")))
UPDATE: a fix has been pushed to evil-surround and it seems to be working in my tests. Melpa should build a new package for download in about 2 hours from now. If you wish to test before, update the recipe to use the latest commit
(evil-surround
  :location
  (recipe :fetcher github
          :repo "emacs-evil/evil-surround"
          :commit "0d860be74165ceb8314742e4191cdad693f40a6d"))

🙏 1
tomd11:09:00

😅 those will be changes I made/merged. Apologies for the breakage. I’ll take a look as soon as I can. This is a downside of taking on a package with no automated testing and then making changes. Should be able to report back soon

practicalli-johnny11:09:05

Software archaeology is certainly "interesting"... wishing you the best of luck with this new package. Happy to do some more testing if required.

tomd11:09:30

😄 Thanks very much! Yes I may ask you to give it a check once I think I’ve fixed it 🙏

practicalli-johnny18:09:14

All looks good to me. Thank you.

tomd18:09:32

Ah, pleased to hear it