This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
- # announcements (1)
- # babashka (6)
- # beginners (5)
- # boot (18)
- # calva (4)
- # clj-kondo (39)
- # cljdoc (1)
- # cljs-dev (1)
- # clojure (24)
- # clojure-italy (5)
- # clojure-spec (5)
- # clojurescript (20)
- # cursive (10)
- # data-science (1)
- # datomic (1)
- # emacs (1)
- # fulcro (1)
- # kaocha (5)
- # rewrite-clj (18)
- # shadow-cljs (11)
- # spacemacs (35)
- # sql (11)
- # vim (13)
I am considering a change to the spacemacs-light/dark themes to make them a little more noticeable. I dont yet understand where the bitmap for the indicators come from. I would like something more like the git fringe indicators. You can easily switch off the fringes if they are annoying you 🙂
The colors are hard-coded by cider, so contrast will be inconsistent between themes.
Would probably be better to inherit from the diff face or something.
(defface cider-fringe-good-face '((((class color) (background light)) :foreground "lightgreen") (((class color) (background dark)) :foreground "darkgreen")) "Face used on the fringe indicator for successful evaluation." :group 'cider)
The bitmap appears to be the inbuilt
empty-line fringe bitmap. You can check with
It seems to be a property added to the fringe, in this method:
The process seems to be: add a space to the fringe, propertized with this bitmap.
(defconst cider--fringe-overlay-good (propertize " " 'display '(left-fringe empty-line cider-fringe-good-face)) "The before-string property that adds a green indicator on the fringe.")
Thanks this is really helpful. I did change the colour via the spacemacs.common.el theme file, but its changing the bitmap I think makes more of a difference.
No worries. I'll extract the colors only and put together a PR. Didn't realise spacemacs-theme also overrides the face.
At line 265 of spacemacs-comon.el I added as a test the following code...
`(cider-fringe-good-face ((,class (:foreground ,darkpurple))))
PR's are awesome.... did you find a nice bitmap to use? Is it possible to use a solid line rather than the
I had a look through a few, nothing that I prefer yet. There is a vertical rectangle, but it doesn't fill the frame.
Might be possible to bypass the bitmap and just fill the background. Let me try in fact...
Probably a better approach in this case would be to dispense with the bitmap and just adjust the background, but it might distort on large fringes. Not sure what setups people use.
spacemacs defaults to 8 px and there is a fringe-mode to set it to half size. I would be surprised if anyone used more than 16
wonder if we could have a cider layer option that would allow you to choose your bitmap?
I was thinking about that. I don't know what Cider's philosophy is on adding extra toggles
Yes, if you can add them to https://github.com/clojure-emacs/cider/issues/2748 that would be great