Fork me on GitHub
#spacemacs
<
2019-09-23
>
jumar07:09:52

Emacs is "deleting orphaned package flycheck-clj-kondo" and I don't know why. I do have that package listed in dotspacemacs-additional-packages

practicalli-john07:09:37

You can remove the previous config for this (in additional packages and user-config)

jumar07:09:28

Great, thanks. Will look at that config soon.

jumar09:09:34

Hm, for some reason it doesn't work at all. This is the only thing I did:

(clojure :variables
              clojure-enable-clj-refactor t
              clojure-enable-linters 'clj-kondo)

jumar09:09:46

Apart from that I commented out my earlier configuration for clj-kondo. In .spacemacs there's still this bit in the custom-set-variables:

'(package-selected-packages
   (quote
    (flycheck-clj-kondo 

jumar09:09:10

And I also have joker:

dotspacemacs-additional-packages '(		
                                      flycheck-joker
...

kommen09:09:12

@jumar did you enable the syntax-checking layer?

jumar09:09:47

Yes, I added it a long time ago in dotspacemacs-configuration-layers; but the docs (linked above) don't mention that

practicalli-john12:09:08

@jumar you will need develop branch from at least the start of September 2019 for this new method of clj-kondo to work

jumar12:09:22

I have that

practicalli-john12:09:45

did you restart Spacemac? and is clj-kondo on your system PATH?

jumar12:09:17

Oh no, I though I have, but it seems I reverted it back because of some issues? 😮

jumar12:09:54

(trying again)

jumar12:09:31

Unfortunately, that doesn't seem to help (latest develop). Is there any requirement on the Emacs version (I'm on Mac OS X)?

jumar12:09:14

(currently using 25.3)

borkdude12:09:26

@jumar I usually try flycheck-compile in a buffer when I try to debug flycheck issues. Maybe that helps. My 2 cts, I know 0 about spacemacs.

jumar12:09:36

Thanks for the tip! That reported the problem correctly

jumar12:09:03

It's just not shown in (`SPC e l`)

jumar12:09:36

Maybe the problem is that I have both joker and kondo?

borkdude12:09:12

I have that too in Emacs, but then again, no spacemacs

practicalli-john12:09:03

@jumar I dropped joker as clj-kondo was more than enough coverage for me. Try comment out the joker code in your .spacemacs file. They should work together, but if you comment out the joker code then its one less potential place for failure.

jumar12:09:36

Ok, will try that.

jumar12:09:01

@borkdude any special areas in which joker is still better - some particular types of errors it can detect that clj-kondo cannot?

practicalli-john12:09:05

If its helpful, my current .spacemacs file is at https://gist.github.com/ef3086a61a219e4b4d37b354fcdd32b7

👍 4
borkdude12:09:29

@jumar I have a hard time coming up with any as I'm trying to complete with other linters

borkdude12:09:39

but if you know some, please let me know 🙂

👍 4
practicalli-john12:09:42

@jumar suggest you would get more value with clj-kondo running as a flycheck backend (as the Clojure layer option) and then running eastwood/kibit as a one of process before sharing commits or as part of CD/CI pipeline. Although clj-kondo catches 99.9% of things anyway

jumar12:09:20

Finally sort it out - the final piece was removing clojure-lint layer which I forgot about (searching only for joker inside the .spacemacs file)

practicalli-john12:09:57

I was thinking of adding joker as an option to the clojure-enable-linters but I am unsure if we need both as @borkdude as added so much to clj-kondo. I've recommended dropping joker in my Spacemacs book and just use clj-kondo because its so awesome. Thanks

lread13:09:36

FWIW, I dropped joker and only use clj-kondo now.

malch13:09:43

joker shows unused private vars, that's probably it simple_smile

malch13:09:13

I mean the only added functionality

borkdude13:09:06

That wouldn’t be too hard to include in kondo. Maybe there’s already an issue for it.

malch13:09:51

It would be great :thumbsup:

lread14:09:36

in the meantime, clj-kondo analysis data and tools can report on unused private vars: https://github.com/borkdude/clj-kondo/tree/master/analysis#private-vars

borkdude14:09:04

true that 🙂

lread14:09:51

hey @borkdude, have we thanked you for clj-kondo yet? simple_smile

borkdude15:09:11

I'm almost drawning in thank you's, thanks a lot 😉

simple_smile 8
👍 8
❤️ 4
spfeiffer15:09:14

Also only using Kondo now.

lread15:09:24

hey @jr0cket have we thanked you for all your spacemacs guides and help yet? (I’m feeling grateful today)

practicalli-john16:09:50

Always nice to get another thank you. Just updating the linter section today 😁. Lots more updates in the next few weeks

🙂 4
❤️ 4