Clojurians Log v2

I'm seeing this with the latest master commit:

Note: The following stack trace applies to the reader or compiler, your code was not executed.
CompilerException Syntax error compiling new at (cljs/closure.clj:1977:13). #:clojure.error{:phase :compile-syntax-check, :line 1977, :column 13, :source "cljs/closure.clj", :symbol new}
	clojure.lang.Compiler.analyzeSeq (Compiler.java:7677)
	clojure.lang.Compiler.analyze (Compiler.java:7360)
	clojure.lang.Compiler.analyzeSeq (Compiler.java:7657)
	clojure.lang.Compiler.analyze (Compiler.java:7360)
	clojure.lang.Compiler.access$200 (Compiler.java:43)
	clojure.lang.Compiler$LetExpr$Parser.parse (Compiler.java:6947)
	clojure.lang.Compiler.analyzeSeq (Compiler.java:7669)
	clojure.lang.Compiler.analyze (Compiler.java:7360)
	clojure.lang.Compiler.analyzeSeq (Compiler.java:7657)
	clojure.lang.Compiler.analyze (Compiler.java:7360)
	clojure.lang.Compiler.analyzeSeq (Compiler.java:7657)
	clojure.lang.Compiler.analyze (Compiler.java:7360)
Caused by:
IllegalArgumentException No matching ctor found for class com.google.javascript.jscomp.DependencyOptions
	clojure.lang.Compiler$NewExpr.<init> (Compiler.java:3097)
	clojure.lang.Compiler$NewExpr$Parser.parse (Compiler.java:3174)
	clojure.lang.Compiler.analyzeSeq (Compiler.java:7669)
	clojure.lang.Compiler.analyze (Compiler.java:7360)
WARNING: A restricted method in java.lang.System has been called
WARNING: java.lang.System::load has been called by com.sun.jna.Native in an unnamed module (file:/Users/borkdude/.m2/repository/net/java/dev/jna/jna/5.16.0/jna-5.16.0.jar)
WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for callers in this module
WARNING: Restricted methods will be blocked in a future release unless native access is enabled

shadow-cljs - HTTP server available at 
shadow-cljs - server version: 3.2.1 running at 
shadow-cljs - watching build :app
[:app] Configuring build.
[:app] Compiling ...
[:app] Build failure:
------ ERROR -------------------------------------------------------------------
 File: /Users/borkdude/.gitlibs/libs/org.clojure/clojurescript/d912f929e4ca9b486a182575659dde95be20c386/src/main/cljs/cljs/repl.cljs
failed to require macro-ns "cljs.repl", it was required by "cljs.repl"
Error in phase :compile-syntax-check
Exception: namespace 'cljs.closure' not found

Hmm, when using cljs.main directly:

$ clj -M -m cljs.main --target browser --output-dir public/js --compile my-app.core
Syntax error (IllegalArgumentException) compiling new at (cljs/closure.clj:1977:13).
No matching ctor found for class com.google.javascript.jscomp.DependencyOptions

Adding com.google.javascript/closure-compiler-unshaded {:mvn/version "v20231112"} works (thanks ChatGPT...)

that is not a good fix, since that is a rather old closure compiler version lacking a lot of features such as the support for private fields

I suppose that should be fixed in CLJS itself, so it can use newer closure versions

closure keeps doing breaking API changes, so we always have to adjust slightly

yeah eventually I looked up the closure from the pom.xml for clojurescript and added that

well still. it needs to be the one from shadow-cljs, otherwise its just older and lacking features

but yeah, if you don't care about that then it doesn't matter

right, I was going back and forth between shadow and vanilla CLJS. Eventually I went with vanilla CLJS since I couldn't get lite mode working otherwise

(I was just testing it)

it should be a trivial fix in cljs.closure. can't remember what the change was, but they are rarely complicated