Clojurians Log v2

I don't see anything special in the generated code, so it might just be a Node JS weirdness

what is the "right exit code"? does the test throw? otherwise I'd always expect 0?

:node-test has extra special handling so it actually sets an exit code. :node-script does not do this. https://github.com/thheller/shadow-cljs/blob/master/src/main/shadow/test/node.cljs#L13

I just use browser. I figured out that when doing node:assert/equal or whatever other assertion on the top level makes the script exit with 1 on failure, but not inside a function (at least with shadow but probably not related to shadow)

I mean, target esm with browser

{:source-paths ["src" "test"]
 :builds
 {:reagami
  {:js-options {;; don't bundle any npm libs
                :js-provider :import}
   :compiler-options {:infer-externs :auto}
   :target :esm
   :runtime :browser
   :devtools {:enabled false}
   :output-dir "lib"
   :modules
   {:reagami {:exports
              {render reagami.core/render}}
    :tests {:init-fn test-runner-cljs/init
            :depends-on #{:reagami}}}
   :build-hooks [(shadow.cljs.build-report/hook
                  {:output-to "report.html"})]}}}

:compiler-options {:infer-externs :auto} this has been the default for like 10 years 😉 no need to set it

I also did try node, didn't make any difference

yeah, copy paste :)

I don't recommend tests as a module as part of a regular build. almost guaranteed to keep more stuff alive and in the :reagami module than needed

I know, this is just for testing the library, not anything that ships to production (then why do I have two modules? I don't remember)

this does exit with 1

import assert from "node:assert";

function f() {
  assert.strictEqual(1, 2);
}

f();
console.log("done");

oooh look:

try { test_runner_cljs.init(); } catch (e) { console.error("An error occurred when calling (test-runner-cljs/init)"); console.error(e); }

looks like shadow's produced code swallows the exception

runtime node doesn't fix this

maybe just let the environment handle the exception?

that is only there for development builds

without it the errors and stacktraces kinda sucked and werent immediately obvious that init-fn was the issue because it would sometimes be way down in the stack

I'm running watch or compile locally to test. Advanced testing is something CI can do for me, takes too long to iterate

but then again, I think swallowing exceptions even in non-advanced builds is surprising when it affects the exit code. having this code on the top level fixes it for me though

well you could try/catch in your init and just do whatever you want 😛

fair enough ;)

I guess in shadow you could add process.exit(1) or process.setExit(1) for node targets