Clojurians Log v2

I ended up adding a preamble hook for both dev and release builds, as too much of the existing setup expects one concatenated file, since that's what we deliver to clients, anyway. Trying to separate them just makes it harder to test the builds the same way. In case anyone needs it, here's what we did:

(ns shadow.hooks
  (:require [clojure.java.io :as io]))

(def preamble
  (apply str
         "// Preamble start\n\n"
         (slurp (io/resource "this"))
         "\n"
         (slurp (io/resource "that"))
         ...
         "\n\n// Preamble end\n\n"))

(defn preamble-hook
  {:shadow.build/stage :configure}
  [build-state & args]
  (println "Prepending preamble")
  (let [stage (:shadow.build/stage build-state)]
    (-> build-state
        (assoc-in [:shadow.build.modules/config :your-module-name :prepend] preamble))))

;; in shadow-cljs.edn:

{...
 :builds {:your-module-name {:build-hooks [(shadow.hooks/preamble-hook)]
  ...

Any further thoughts? Sorry to bug you.

(-> (shadow/get-build-config :your-build) (update-in [:modules :main] assoc :prepend (slurp "whatever.doc")) (shadow/release*)) seems like the best option?

for local testing I'd just use a separate script tag and for release just prepend it

you can use the above via https://shadow-cljs.github.io/docs/UsersGuide.html#clj-run

Thanks! You recommend the above over a hook fn?

(defn release []
  (-> (shadow/get-build-config :your-build)
      (update-in [:modules :main] assoc :prepend (slurp "whatever.doc"))
      (shadow/release*)))

yes

Got it. Will try this. Thank you very much for your help

seems like it would be easier to just leave the extra .js files as they are, or concatenated together into one .js file. and then just add an extra script tag to your html to load it? or any particular reason shadow even needs to know about it?

@thheller Sorry, to clarify, we produce one js artifact for clients to install on their own websites. We don't control the pages it's installed on. And realistically, I don't think I can convince them all to add another dozen <script> tags 😄

Still not sure I understand what's going on. But it works 🙂

It did however reduce my bundle size from 10MB to 1.8MB

you probably also want to add :export-conditions ["module" "import" "browser" "require" "default"] to the :js-options map. that ensures packages with "exports" also take the esm files, since that is pretty common these days

Ah right, saw it here in Slack but couldn’t find it in the Shadow-CLJS guide

Pretty sure this could be ported to Cljs. Would probably be even smaller: https://github.com/jacobemcken/aws-simple-sign/blob/main/src/aws_simple_sign/core.clj

its the default for dev builds, release builds no

The release build still produces maps but doesn’t link them or so?

if you have the build-report hook active yes, because thats working off source maps it enables them but doesn't link them

Ah now I got it then, thanks!

Is there a disadvantage of including source maps for release builds? Does a browser greedily download them?

source maps contain all the sources. so if you don't mind users getting access to your sources then no. browsers only download with devtools open.

That’s fine, it’s open source anyway. Thanks!