works just fine. I made an example a bit ago here https://clojurians.slack.com/archives/C03S1L9DN/p1710662438914879?thread_ts=1710421525.090259&cid=C03S1L9DN

hmm... doesn't work for me. I'm trying to add a @param {string} jws jsdoc string and I can't find it in the output JS

where did you use it? it only works on def and defn? or possibly bindngs, I'm not actually sure

I've tried this:

(defn ^{:export true, :jsdoc ["@param {string} jws"]} verify-jws
  [jws]
  (-> jws fc/verify-jws clj->js))

and this (following your example above):

(defn ^:export verify-jws {:jsdoc ["@param {string} jws"]}
  [jws]
  (-> jws fc/verify-jws clj->js))

that looks fine, although I'm unsure what that tag is for? after optimizations that tag will be gone?

for better typescript type declarations

but if that's the case, that would explain why I'm not seeing it 🙂

how or where would typescript type declarations come from?

the typescript compiler can generate them from js sources and can use jsdoc annotations for better type info when they're available

/**
 * @param {string} jws
 */
demo.browser.verify_jws = (function demo$browser$verify_jws(jws){
return cljs.core.clj__GT_js(jws);
});

shows up just fine

huh, weird

well if its generating them from release compiled sources then it won't have much luck

closure removes @param annotations as part of optimizations, they it assumes its for its guidance

we're explicitly using simple optimizations for other reasons

its still optimizations, so that changes nothing

ok

there might be an option to tell it to keep them, but I can't remember

I'd say there is close to zero chance for type annotations to remain in a shape where typescript can find them

it is running shadow-cljs release so that must be why

since even ^:export it won't recognize

ok, I'll give up for now then. just wanted to make sure I wasn't something simple to enable better types

thanks!

I have never done anything with typescript, so I don't know how types would be extracted

it should be fairly easy to generate .d.ts files using a build hook though, since that can see whats exported and what metadata those vars have

this is where it's documented, in case you're curious: https://www.typescriptlang.org/docs/handbook/declaration-files/dts-from-js.html

oh, that could be interesting

probably more work than it's worth right now, but good to know