Fork me on GitHub
#shadow-cljs
<
2023-12-08
>
skuttleman00:12:46

does shadow-cljs no longer support warnings in the compiler opts?

:builds {:dev {:compiler {:optimizations :none
                          :warnings {:redef false}}}
this seems to do nothing
17:19:46 cljs.1 | ------ WARNING #1 - :redef -----------------------------------------------------
17:19:46 cljs.1 |  Resource: no/en/core.cljc:131:1
17:19:46 cljs.1 | --------------------------------------------------------------------------------
17:19:46 cljs.1 |  128 |   [s]
17:19:46 cljs.1 |  129 |   (parse-number s #(#?(:clj Integer/parseInt :cljs js/parseInt) %1)))
17:19:46 cljs.1 |  130 |
17:19:46 cljs.1 |  131 | (defn parse-long
17:19:46 cljs.1 | -------^------------------------------------------------------------------------
17:19:46 cljs.1 |  parse-long already refers to: cljs.core/parse-long being replaced by: no.en.core/parse-long
17:19:46 cljs.1 | --------------------------------------------------------------------------------
17:19:46 cljs.1 |  132 |   "Parse `s` as a long number."
17:19:46 cljs.1 |  133 |   [s]
17:19:46 cljs.1 |  134 |   (parse-number s #(#?(:clj Long/parseLong :cljs js/parseInt) %1)))
17:19:46 cljs.1 |  135 |
17:19:46 cljs.1 | --------------------------------------------------------------------------------

1
skuttleman00:12:37

shadow-cljs v 2.26.2. trying to upgrade.

thheller04:12:47

just update the noencore dependency

thheller04:12:24

but :warnings should be fine, not sure why it isn't

thheller04:12:35

oh nevermind

thheller04:12:47

it is :compiler-options not :compiler

gratitude-thank-you 1
skuttleman10:12:25

That did the trick. Thanks!