hmm looks like the screenshot isn't loading, i'll try attaching it again here

shadow-cljs does not support css, therefore requiring a css file won't work. you'll need a secondary tool for that

gotcha, thanks! how about the main library import? is that type of import not supported?

can't see the images, slack seems to have problems

@U05224H0W try this https://ibb.co/1sV6ry3

and this is the actual file that is getting included? I see a .cjs file. what does the package.json "main" entry say

or does it have "exports"? or "browser"?

package.json of that package I mean

"./dist/footprint-js.umd.js" - ah yeah sorry, screenshotted the wrong file

yeah you definitely don't want to include that file

umd is bad

it has exports:

"exports": {
    ".": {
      "require": "./dist/footprint-js.umd.js",
      "import": "./dist/footprint-js.js",
      "types": "./dist/footprint-js.d.ts"
    },
    "./dist/footprint-js.css": {
      "import": "./dist/footprint-js.css",
      "require": "./dist/footprint-js.css"
    }
  },

ok, so in that case shadow-cljs will follow the require by default. you can change this by setting

:export-conditions ["browser" "require" "default" "module" "import"]

the above is the default order, so you move "import" before "require"

then it will use the proper .js file

it is weird that the require is pointing to a umd.js file. that seems uncommon to me, would expect the .cjs there.

if you can change that I'd recommend that over changing :export-conditions

does :export-conditions go in the :js-options map?

oh, sorry. yes it does.

oh an you need to be on 2.25.2 for any of that to matter 😛

if you are on an older version then "exports" is not considered. only the other top level keys, so "browser" or "main" or "module"

oh haha. it's ok, this is from a vendor we're working with so i can try asking them for a cdn instead

which you can also change by re-ordering :entry-keys ["browser" "main" "module"], to move module to first

you can also just require whatever directly and bypass all this

so (:require ["@onefootprint/footprint-js/dist/footprint-js.js" :as footprint])

but that only works for requires that you control yourself, so if something else still requires "@onefootprint/footprint-js" then you'll still have the problem

oh yeah i tried that first and got ExceptionInfo: package @onefootprint/footprint-js had exports, but could not resolve ./dist/footprint-js.js

ah so you are on 2.25+

i'm on 2.24.1

oh right, sorry added that stuff in 2.24+

i tried the :export-conditions and it seemed to mess with the import of a different library

yeah that unfortunately is a global setting and will make all packages switch

well ideally the package just removes the .umd.js file from require, that is uncommon and not something I have seen before

or you could maybe figure out what the umd file exports

it is most likely a global variable

which you'd use via js/WhateverThatWas instead of the :as alias

but umd usually means trouble in other places 😛

this is what's in the file:

(function (exports) {
  'use strict';

  ...bunch of stuff here

  exports.FootprintInternalEvent = w;
  exports.FootprintPublicEvent = E;
  exports.default = Nt;
  exports.identifyUser = W;

  Object.defineProperty(exports, '__esModule', { value: true });

  return exports;

})({});

uhm is there a window.Whatever = exports; or so in there?

otherwise that file is rather useless since the return value is never used? (which is also why you are seeing an empty object when printing the variable)

hmm not that i can see

tysm for the insight. fortunately vendor is amenable to a cdn

I don't recommend using cdn versions though 😉 easier to just either use the .js or .cjs files 😛

I doubt anyone has ever used the .umd.js file if its like that 😛

how would we use the js file? change the package.json?

yes

the library is on npm btw https://www.npmjs.com/package/@onefootprint/footprint-js?activeTab=code

seems to be public

and yeah the umd.js file is definitely invalid and the problem here

oh wow you're right haha, just realized it was actually another one (footprint-react) that wasn't online

also public, but seems to be using the same build system and has the same problem

changing the package.json "main" and "require" totally worked

the issue likely is that webpack and most other JS tools nowadays default to using the "module" or exports/import key

but would be impractical to do that after every npm install

shadow-cljs still defaults to the older default and thats why you end up with the require and umd file

in your opinion would it be reasonable to ask the devs to change the package.json permanently?

in my opinion the umd file is invalid and unusable, so yes someone should look into that. also pointing the "require" key at the umd file will make the entire thing unusable in node

which it probably is anyways, so probably not a priority

can you tell me which other package broke when you switched :export-conditions?

Errors encountered while trying to parse file
  /Users/elle/local/composer/composer-web/node_modules/htmlparser2/lib/esm/index.js
  {:line 48, :column 9, :message "'from' expected"}

odd

what does “local-only” mean here? local m2 repository? or?

yeah, ~/.m2/repository

hm… in that case it should suffice to provide the GAV in your :dependencies

if you mean “local deps” as in deps.edn’s :local/root then you will need to manage dependencies with a deps.edn alias and set :deps in shadow-cljs.edn to the alias

unless I missed an option, that throws a DependencyResolutionException bc it looks on central and doesn't find anything

that is interesting. can you check if the JAR file is inside your ~/.m2 ?

(I have locally installed libraries before and shadow was able to find them)

it is, I just put it there. It's a library I'm working on, so its at ~/.m2/repository/bhlie/<my-lib>.jar

that may be the issue. the format of the folder isnt like that

can you try installing it with lein install or mvn install or equivalent?

the structure of the local repo is something like this

.m2/
  repository/
    group/
      artifact/
        version/
          _remote.repositories
          artfiact-version.pom
          artfiact-version.jar
          ...

this is automatically handled for you by leiningen, maven, et. al

i do not recommend creating this folder structure by hand

yeah, I'm learning that as we speak 😅

so once I've made the jar, I should do mvn install in the project directory and that will put everything I need in ~/.m2

?

it depends on the library you are trying to install

does it use leiningen? maven? gradle? tools.build? etc.

tools.build

then nobody knows unless they documented how to install it 😞

there is still hope though… let’s try the following

remove the GAV from your :dependencies then drop the JAR file into somewhere like a resources folder… and in your shadow-cljs.edn file, add resources to your :source-paths maybe?

the idea behind this approach is to try adding the JAR to your classpath manually, and avoid having to install to an m2 repo

oh cool yeah I was thinking of something along those lines but e.g. java -cp only I didn't know how to make that work with shadow

I'll give that a go

worst case scenario, we can just manually install the JAR with maven by doing something like

mvn install:install-file -Dfile=your.jar -DgroupId=group -DartifactId=artifact -Dversion=version -Dpackaging=jar

Should I be able to require this like any other source once it's on the classpath? I expect yes but I'm evidently doing something wrong

well, I was gambling on shadow-cljs adding anything on the :source-paths to the classpath… but that doesnt seem to be the case if this doesnt work

let’s try the mvn install option as a last resort

nice, that worked!

thanks a bunch for your help