Fork me on GitHub
#shadow-cljs
<
2023-06-24
>
vemv22:06:18

Does adding the Piggieback middleware contribute anything to a cider+shadow-cljs setup? I see from https://github.com/thheller/shadow-cljs/issues?q=is%3Aissue+piggieback that it's commonly in the middleware stack. It's also in https://github.com/metabase/metabase/blob/master/shadow-cljs.edn (I take metabase as an example of a high-quality setup). But from casual testing, it doesn't appear to make a difference - everything keeps working without it. There's https://github.com/nrepl/piggieback/tree/cf8e5c573c97f3b779bc4ee473e7d02276fb99a4#does-shadow-cljs-use-piggieback but it isn't exactly conclusive.

dpsutton22:06:49

I believe shadow does not use it and has workarounds specifically to ignore ut

dpsutton22:06:05

my info is out of date

thheller06:06:20

no thats still correct. It is added by default because some editors otherwise try to do it. the shadow nrepl middleware justs intercepts calls to it, so it never actually does anything

thheller06:06:57

previously it tried to emulate piggiback instead but that was causing a lot of issues

vemv10:06:26

Great to know - thank you both! I'll make cider/piggie doc clearer on this topic.