bad example - it does the same with some npm modules, such as cookies, ws, etc.

never looked at macchiato? can you point me to the sources? is there any particular reason they are doing this instead of just over the ns form?

see e.g. https://github.com/macchiato-framework/macchiato-core/blob/7ffe90800cc19354541f807d738e12eef82f7072/src/macchiato/cookies.cljs#L59

it does that for a whole bunch of npm deps

I've been wondering whether I should just "fork" macchiato and replcae them all with the ns form. Just trying to avoid the work if at all possible.

I've used macchiato-core with node-script just fine. What specific errors do builds give you?

It builds & works fine, if the npm modules are available. But it isn't standalone - you need to install certain npm modules.

That's because macchiato-core depends on external node modules

i.e. it doesnt use just the node stdlib

(ns macchiato.cookies
  (:require
    [cljs.nodejs :as node]))

(def ^:no-doc Cookies (node/require "cookies"))

(def ^:no-doc random-bytes (node/require "random-bytes"))

what is the reasoning to write it this way?

> That's because macchiato-core depends on external node modules I'm aware, but shadow-cljs can normally bundle things just fine

(ns macchiato.cookies
  (:require
    ["cookies" :as Cookies]
    ["random-bytes" :as random-bytes]))

> what is the reasoning to write it this way? beats me - really weird.

I see. I’ve personally never gotten node scripts to bundle everything into a single file. I’ve always assumed npm install was necessary to run scripts using libs beyond the stdlib

that should be fine with regular CLJS as well

re: macchiato: IIRC macchiato was written when people were still using lein-cljsbuild and NPM support was shoddy at best with existing tooling (mostly cljsbuild and figwheel)

time to fix that then I guess 😉

Yea, I'll probably do that - just make my own macchiato copy with those things changed to the ns form.

Thanks

You can find use of require in let forms, which I find pretty ugly. I’ve never bothered sending PRs fixing them because in the end macchiato-core has more or less “just worked” for me. And the repository itself doesnt seem maintained.

I have no other suggestion to make, there isn't an easy way to bundle things hidden from the bundler like that

@Alex H With that said… if you’re willing to fork macchiato-core, I’m willing to help maintain it, since I have some projects that rely on it for SSR with React

I've submitted a PR upstream: https://github.com/macchiato-framework/macchiato-core/pull/53 In the meantime, I'll just use my own fork as a git dep.

I have no plans of maintaining it in any meaningful way, FWIW - just the bare minimum that works for me.

FWIW, the PR above is now merged upstream, and also available on clojars from 0.2.24 onwards.