I got around this previously when I had to use the fs module by doing this: (let [fs (js/require "fs")] ...) so the require happens at runtime. I could write a small .js file which does what I want and do this but I would prefer a cleaner solution.

you maybe want to use :target :npm-module or :target :esm?

or :js-options {:keep-as-require #{"node:stream"}}, :browser might not be ideal for electron since it bundles npm deps, which may lead to duplicates? but I guess build size is not that important

Yeah size is not that important and I want it to bundle the npm deps because the plugin can't npm install anything.

Thanks for the tip about :keep-as-require - will this flow through to included modules or it's only in the top level cljs code?

all code shadow-cljs processes will leave it as is

I have not tried :target :esm yet, will check that out. I tried :npm-module but I get the same file resolution issues:

Uncaught Error: Cannot find module './cljs_env'
Require stack:
- /tmp/.mount_joplinj3IwdH/resources/app.asar/services/plugins/plugin_index.html
    at Module._resolveFilename (node:internal/modules/cjs/loader:940:15)
    at i._resolveFilename (node:electron/js2c/renderer_init:33:1095)
    at Module._load (node:internal/modules/cjs/loader:785:27)
    at c._load (node:electron/js2c/asar_bundle:5:13343)
    at i._load (node:electron/js2c/renderer_init:33:356)
    at Module.require (node:internal/modules/cjs/loader:1012:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at plugin_com.joplinwebsite.publishplugin.js:1:13

for :esm you'd need type="module" in the html

but I'm not sure what the state of ESM for electron is. it wasn't supported last time I checked, dunno if that has changed

Ah ok. I don't think I have control over how the app is requiring the plugin code. Will have to investigate if I can tell it it's a module (or if Electron even allows it as you point out).

I have this target now using :keep-as-require:

:plugin {:target :browser
                   :output-dir "plugin"
                   :modules {:index {:entries [joplinsite.plugin]}}
                   :js-options {:keep-as-require #{"node:http"}}}

The required JS dependency "node:http" is not available, it was required by "node_modules/node-fetch/src/index.js".

Dependency Trace:
	joplinsite/plugin.cljs
	node_modules/node-fetch/src/index.js

Searched for npm packages in:
	/home/chrism/dev/joplinwebsite.com/node_modules

See: 

hmm no should be ok

let me check

ah, add :keep-native-requires true to the :js-options

bad boolean logic couples it to that 😛

Ok, that seems to have worked, thanks.

I'm now seeing this:

[:plugin] Build failure:
Failed to inspect file
  /home/chrism/dev/joplinwebsite.com/node_modules/fetch-blob/index.js

it was required from
  /home/chrism/dev/joplinwebsite.com/node_modules/node-fetch/src/body.js

Errors encountered while trying to parse file
  /home/chrism/dev/joplinwebsite.com/node_modules/fetch-blob/index.js
  {:line 45, :column 2, :message "'}' expected"}

thats the closure compiler not recognizing too modern code

Ah yes there is all kinds of es stuff in there.

thats not a problem

some non-standard cutting edge features just aren't supported yet

assuming you are on the latest version already, then there isn't much to do unfortunately

I'm pretty sure you can just keep all npm packages as they are

and just bundle then as part of your package

without shadow bundling them as part of the build

Ok, this has got me a bit further and was very helpful, thanks!

> and just bundle then as part of your package Ah I see what you mean, like link the node_modules in there and require them at runtime.

Oh or pre-process them into a separate bundle.

I don't know what the electron best practices are, but I assume that it doesn't require everything to be bundled

Alright I finally got it working. I use shadow-cljs to generate an esm module with :keep-as-require for everything that wouldn't come in without errors, then I used webpack to bundle all the resulting esm code into something I can require dynamically at runtime in my plugin. It's a big hack but it seems to work (at least to the point where it's importing and I can run the function). Thanks for your help!

https://shadow-cljs.github.io/docs/UsersGuide.html#_third_party_tool_integration

might as well use webpack for everything then

For anyone that stumbles across a similar problem: I removed all traces of joda time from my package.json and package-lock.json, had node uninstall them then re-started shadow-cljs which discovered the correct versions of the deps and installed them and now we’re good again 🙂

Hey, I've run smack into this. What do you mean "shadow-cljs discovered the correct versions of the deps"?