Fork me on GitHub
#shadow-cljs
<
2022-12-08
>
juhoteperi10:12:25

Another thing on the build-report, some JS files aren't grouped under the npm package. For some reason the :npm-info has a funny :package-id and empty :package-name and :version for some files.

juhoteperi10:12:31

@mui/x-data-grid contains separate package.json under components/ folder so I think that will be picked up by read-package-json

juhoteperi10:12:58

But some files under components/ are still grouped under the real npm package

juhoteperi10:12:08

{:npm-info {:package-id "/home/juho/Work/foo/bar/frontend/node_modules/@mui/x-data-grid/components@",
                             :package-name nil,
                             :version nil},
                  :output-name "module$node_modules$$mui$x_data_grid$components$containers$GridRootStyles.js",
                  ...

thheller10:12:48

hmm yeah weird package.json contents confuse the system a little bit

thheller11:12:48

I guess it should keep looking up for "name" if there isn't one

juhoteperi09:12:13

I did look at shadow.build.npm but as far as I understand, it is finding the closest package.json on purpose, so it doesn't seem to be trivial to change this. Perhaps there should be separate info for "real" package.json for the files that are under these nearly empty package.json files, and then build report could use that information.

thheller09:12:16

yeah the name and version fields are only used for the build report. the other stuff is more important for the actual build

thheller09:12:39

should still work properly though, I'll check it out

Derek15:12:04

2.20.14 made it to Clojars but not to npm

thheller15:12:12

oops, fixed