Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2022-09-09

Channels

#shadow-cljs
<
2022-09-09
>
witek06:09:00

Ok. I expected every npm package to be usable with shadow-cljs. Thank you for your help!

thheller06:09:33

well, my guess is this one isn't even compatible with webpack

thheller06:09:56

some just use npm as a delivery mechanism without any expectation of actually being bundle-able

thheller06:09:57

you could add the line module.exports = LeaderLine; as the last line in its sources to make it an actual npm package with an export

thheller06:09:06

but yeah otherwise its not exporting anything

Marius09:09:09

I’ve upgraded shadow-cljs from 2.19.0 to 2.20.1 (among other things) and now the compilation fails with the following exception: 

[:app] Configuring build.
[:app] Compiling ...
[:app] Build failure:
IllegalArgumentException: No matching method setOutputFeatureSet found taking 1 args for class com.google.javascript.jscomp.CompilerOptions
	clojure.lang.Reflector.invokeMatchingMethod (Reflector.java:127)
	clojure.lang.Reflector.invokeInstanceMethod (Reflector.java:102)
	shadow.build.closure/set-options (closure.clj:166)
	shadow.build.closure/set-options (closure.clj:122)
	shadow.build.closure/convert-goog* (closure.clj:2290)
	shadow.build.closure/convert-goog* (closure.clj:2255)
	shadow.build.closure/convert-goog (closure.clj:2434)
	shadow.build.closure/convert-goog (closure.clj:2384)
	shadow.build.compiler/maybe-closure-convert (compiler.clj:1233)
	shadow.build.compiler/maybe-closure-convert (compiler.clj:1226)
	shadow.build.compiler/compile-all (compiler.clj:1468)
	shadow.build.compiler/compile-all (compiler.clj:1345)
	shadow.build.api/compile-sources (api.clj:261)
	shadow.build.api/compile-sources (api.clj:253)
	shadow.build/compile (build.clj:512)
	shadow.build/compile (build.clj:493)
	shadow.cljs.devtools.server.worker.impl/build-compile (impl.clj:368)
	shadow.cljs.devtools.server.worker.impl/build-compile (impl.clj:349)
	shadow.cljs.devtools.server.worker.impl/eval28465/fn--28467 (impl.clj:448)
	clojure.lang.MultiFn.invoke (MultiFn.java:234)
	shadow.cljs.devtools.server.util/server-thread/fn--28223/fn--28224/fn--28232 (util.clj:283)
	shadow.cljs.devtools.server.util/server-thread/fn--28223/fn--28224 (util.clj:282)
	shadow.cljs.devtools.server.util/server-thread/fn--28223 (util.clj:255)
	java.lang.Thread.run (Thread.java:833)
Has anyone seen this before? I could not find anything neither in the web nor here….

Marius11:09:51

I’ve figured it out, the following dependency caused the exception: [com.google.javascript/closure-compiler-unshaded "v20220905"] Reverting to [com.google.javascript/closure-compiler-unshaded "v20220502"] solved the issue.

thheller05:09:04

actually it should be [com.google.javascript/closure-compiler-unshaded "v20220803"] for 2.20.1

thheller05:09:19

unfortunately the closure compiler frequently introduces breaking changes to their API

thheller05:09:27

so have to stay with matching versions

Marius11:09:53

ok, thanks, will fix it!

Ivan Fedorov20:09:46

Hi Thomas! I got further with my externs hunt, fixed many issues. One that still bugs me is that Closure seems to rename usage of properties of some browser APIs, notably the SVG elements properties. Do you have an idea of how to provide all externs for SVGElement? Other than just copying its API from MDN. ––––––––––––––– Update: yea, seems like Closure actually may not support SVG out of the box! https://github.com/google/closure-compiler/wiki/Externs-For-Common-Libraries#svg

Chicão20:09:15

Hi, I'm trying to export some components from an application that uses React + NextJS + Tailwind to import in a clojurescript app with helix an shadow-cljs, so does anyone knows how can I do this? I was trying to install my app on package json but had some problems I will send on the 🧵

Chicão21:09:03

when I installed my components into my cljs app here is the components into node modules

Chicão21:09:19

I tried to import and I got this

alex22:09:19

Not sure if this is the only issue but you might have a misspelling in your cljs import. Should it say "moclojer-components" (you're missing the "r")

Chicão02:09:40

yep I fix it but still have the same problem

thheller05:09:10

the components use next.js? normally next.js is the app and is not used to create libraries?

Chicão11:09:07

Oh it uses but I can remove if next is the problem. But not sure what I did is right. The component are jsx should I have to transpile to js?

thheller13:09:01

yes, they need to plain js

thheller13:09:12

and it needs to be a proper npm package

Chicão22:09:58

hi @U05224H0W, @UMMMKKADU open a PR https://github.com/moclojer/try-import-components-lib-into-cljs-app/pull/1 to help me, this was what I try to do. I’m sending here to share if someone wants do the same thing.. Thanks