I've been using a flush hook like this:

(defn flush-hook
  {:shadow.build/stage :flush}
  [build-state & args]
  (when (= :release (:shadow.build/mode build-state))
    ;; My logic
    )
  build-state)

when building release artifacts on something like github actions. is it a good idea to cache .shadow-cljs? or will that just bite me in the ass at some point?

@isak hmm I guess I didn't consider that. build reports just re-use the original build configs. I guess it should unset the build-hooks

@peder.refsnes the intention is to maintain the cache (ie. .shadow-cljs) yes. it invalidates itself if something changes

Hellooo, Happy Monday! Ever since switching to a branch with some version bumps (`deps.edn` and package.json) I've been getting a bizarre build error running shadow-cljs ... watch app—or shadow-cljs ... server then :Connecting (with https://github.com/tpope/vim-fireplace/blob/b6bef833b56632df917bcf33bc50b8a5d1e26139/doc/fireplace.txt#L19) and :CljEvaling (do (require '[shadow.cljs.devtools.api :as shadow]) (shadow/watch :app) (shadow/nrepl-select :app)): see below ⬇️ I've tried a https://stackoverflow.com/a/70490790 of https://docs.npmjs.com/cli/v8/commands/npm-ci, up to and including updating my global shadow-cljs to the latest version, and using npx shadow-cljs... and fiddling with the :output-feature-set compiler option... and https://github.com/angular/clutz/issues/490#issuecomment-292236507 😅 ... and still nada. Seems like people have https://clojurians-log.clojureverse.org/shadow-cljs/2020-06-02 about similar https://clojurians-log.clojureverse.org/shadow-cljs/2020-08-25 before... and it was some kinda problem in/with the closure compiler? :thinking_face: Fwiw, this is the thing called in the last (i.e. most recent) line of the stacktrace below, afaict: https://github.com/google/closure-compiler/blob/dfa3226ec7b5197b2a1c11b4f0f4a3ee147919f4/src/com/google/javascript/jscomp/parsing/ParserRunner.java#L118 And this is the file where the stack-blowing is happening: https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/parsing/IRFactory.java The error:

$ shadow-cljs -d nrepl/nrepl:0.8.3 -d cider/piggieback:0.5.2 -d com.billpiel/sayid:0.1.0 -d refactor-nrepl:3.0.0 -d cider/cider-nrepl:0.27.2 watch app
shadow-cljs - config: /home/carnun/Documents/Nette/nette/shadow-cljs.edn
shadow-cljs - starting via "clojure"
shadow-cljs - HTTP server available at 
shadow-cljs - server version: 2.19.3 running at 
shadow-cljs - nREPL server started on port 8777
shadow-cljs - watching build :app
[:app] Configuring build.
[:app] Compiling ...
[:app] Build failure:
Failed to inspect file
  /home/carnun/Documents/Nette/nette/node_modules/highlight.js/lib/languages/gml.js

it was required from
  /home/carnun/Documents/Nette/nette/node_modules/highlight.js/lib/index.js

Errors encountered while trying to parse file
  /home/carnun/Documents/Nette/nette/node_modules/highlight.js/lib/languages/gml.js
  {:line 1, :column 1, :message "The file could not be parsed as JavaScript."}

RuntimeException: Exception parsing "/home/carnun/Documents/Nette/nette/node_modules/highlight.js/lib/languages/gml.js"
	com.google.javascript.jscomp.parsing.ParserRunner.parse (ParserRunner.java:148)
	com.google.javascript.jscomp.JsAst.parse (JsAst.java:156)
	com.google.javascript.jscomp.JsAst.getAstRoot (JsAst.java:62)
	shadow.build.closure.JsInspector.getFileInfo (JsInspector.java:180)
	shadow.build.closure.JsInspector.getFileInfoMap (JsInspector.java:194)
	shadow.build.npm/get-file-info*/fn--12316 (npm.clj:452)
	shadow.build.npm/get-file-info* (npm.clj:451)
	shadow.build.npm/get-file-info* (npm.clj:401)
	shadow.build.npm/get-file-info (npm.clj:512)
	shadow.build.npm/get-file-info (npm.clj:509)
	shadow.build.npm/find-resource-in-package (npm.clj:726)
	shadow.build.npm/find-resource-in-package (npm.clj:686)
	shadow.build.npm/find-resource (npm.clj:776)
	shadow.build.npm/find-resource (npm.clj:739)
	shadow.build.resolve/find-npm-resource (resolve.clj:122)
	shadow.build.resolve/find-npm-resource (resolve.clj:93)
	shadow.build.resolve/eval14445/fn--14448 (resolve.clj:262)
	clojure.lang.MultiFn.invoke (MultiFn.java:244)
	shadow.build.resolve/find-resource-for-string (resolve.clj:80)
	shadow.build.resolve/find-resource-for-string (resolve.clj:69)
	shadow.build.resolve/resolve-string-require (resolve.clj:453)
	shadow.build.resolve/resolve-string-require (resolve.clj:436)
	shadow.build.resolve/resolve-require (resolve.clj:669)
	shadow.build.resolve/resolve-require (resolve.clj:662)
	shadow.build.resolve/resolve-deps/fn--14394 (resolve.clj:51)
	clojure.lang.PersistentVector.reduce (PersistentVector.java:343)
	clojure.core/reduce (core.clj:6885)
	clojure.core/reduce (core.clj:6868)
	shadow.cljs.util/reduce-> (util.clj:45)
	shadow.cljs.util/reduce-> (util.clj:44)
	shadow.build.resolve/resolve-deps (resolve.clj:49)
	shadow.build.resolve/resolve-deps (resolve.clj:33)
	shadow.build.resolve/resolve-symbol-require (resolve.clj:656)
	shadow.build.resolve/resolve-symbol-require (resolve.clj:615)
	shadow.build.resolve/resolve-require (resolve.clj:666)
	shadow.build.resolve/resolve-require (resolve.clj:662)
	shadow.build.resolve/resolve-deps/fn--14394 (resolve.clj:51)
	clojure.lang.PersistentVector.reduce (PersistentVector.java:343)
	clojure.core/reduce (core.clj:6885)
	clojure.core/reduce (core.clj:6868)
	shadow.cljs.util/reduce-> (util.clj:45)
	shadow.cljs.util/reduce-> (util.clj:44)
	shadow.build.resolve/resolve-deps (resolve.clj:49)
	shadow.build.resolve/resolve-deps (resolve.clj:33)
	shadow.build.resolve/resolve-symbol-require (resolve.clj:656)
	shadow.build.resolve/resolve-symbol-require (resolve.clj:615)
	shadow.build.resolve/resolve-require (resolve.clj:666)
	shadow.build.resolve/resolve-require (resolve.clj:662)
	shadow.build.resolve/resolve-deps/fn--14394 (resolve.clj:51)
	clojure.lang.PersistentVector.reduce (PersistentVector.java:343)
	clojure.core/reduce (core.clj:6885)
	clojure.core/reduce (core.clj:6868)
	shadow.cljs.util/reduce-> (util.clj:45)
	shadow.cljs.util/reduce-> (util.clj:44)
	shadow.build.resolve/resolve-deps (resolve.clj:49)
	shadow.build.resolve/resolve-deps (resolve.clj:33)
	shadow.build.resolve/resolve-symbol-require (resolve.clj:656)
	shadow.build.resolve/resolve-symbol-require (resolve.clj:615)
	shadow.build.resolve/resolve-require (resolve.clj:666)
	shadow.build.resolve/resolve-require (resolve.clj:662)
	shadow.build.resolve/resolve-deps/fn--14394 (resolve.clj:51)
	clojure.lang.PersistentVector.reduce (PersistentVector.java:343)
	clojure.core/reduce (core.clj:6885)
	clojure.core/reduce (core.clj:6868)
	shadow.cljs.util/reduce-> (util.clj:45)
	shadow.cljs.util/reduce-> (util.clj:44)
	shadow.build.resolve/resolve-deps (resolve.clj:49)
	shadow.build.resolve/resolve-deps (resolve.clj:33)
	shadow.build.resolve/resolve-symbol-require (resolve.clj:656)
	shadow.build.resolve/resolve-symbol-require (resolve.clj:615)
	shadow.build.resolve/resolve-require (resolve.clj:666)
	shadow.build.resolve/resolve-require (resolve.clj:662)
	shadow.build.resolve/resolve-deps/fn--14394 (resolve.clj:51)
	clojure.lang.PersistentVector.reduce (PersistentVector.java:343)
	clojure.core/reduce (core.clj:6885)
	clojure.core/reduce (core.clj:6868)
	shadow.cljs.util/reduce-> (util.clj:45)
	shadow.cljs.util/reduce-> (util.clj:44)
	shadow.build.resolve/resolve-deps (resolve.clj:49)
	shadow.build.resolve/resolve-deps (resolve.clj:33)
Caused by:
StackOverflowError: 
	com.google.javascript.jscomp.parsing.IRFactory$TransformDispatcher.processBinaryExpression (IRFactory.java:1743)
	com.google.javascript.jscomp.parsing.IRFactory$TransformDispatcher.process (IRFactory.java:2780)
	com.google.javascript.jscomp.parsing.IRFactory.transform (IRFactory.java:737)
	com.google.javascript.jscomp.parsing.IRFactory$TransformDispatcher.processBinaryExpression (IRFactory.java:1748)
	com.google.javascript.jscomp.parsing.IRFactory$TransformDispatcher.process (IRFactory.java:2780)
	com.google.javascript.jscomp.parsing.IRFactory.transform (IRFactory.java:737)
	...

see https://github.com/google/closure-compiler/issues/3945#issuecomment-1132625831

dunno how you are using highlight.js. if its via re-frame-10x you should upgrade that

also https://github.com/thheller/shadow-cljs/issues/1015

Oh wow... so throwing (even) more stack at it really is the answer? 🙃

well imho the answer is not including these files in the first place. I doubt very much you need gml support? whatever that even is 😛

re-frame-10x aye... and lowlight, via https://tiptap.dev iirc

GameMaker Language 😛 just one of many that highlight.js ships with in its node_modules

well its fine to include it if you actually need it

including it when you don't need it just makes everything larger and slower (to build, load, etc)

agreed! but it's very likely a keeper (unfortunately?)

hmm?

I just mean I agree in general that larger and slower is worse 😛

I mean another option is just editing this file in your node_modules folder

https://unpkg.com/[email protected]/lib/index.js

just remove all the registerLanguage calls you don't need

bit manual but might be worth

Throwing more more stack at it seemed to do the trick. Thanks @thheller! :))

> I mean another option is just editing this file in your node_modules folder Hmm... would this mean checking that into source control?

well I would just automate the edit in some way so it always runs after the package is installed

I mean all of this only applies if you don't control how highlight.js is used yourself

but I assume that is the case here

you can also use :js-options {:resolve {"highlight.js" {:target :npm :require "highlight.js/core"}}

that would only give you the basic highlight.js

you can then add all the languages you actually need manually in your code somewhere

or just live with the high stack size

Really appreciate these ideas. I'll have to chew them over tomorrow. Thanks again!

possible bug report (more in the thread)

will shadow use a cljsjs dependency? [edit] nope. clearly not. e.g :dependencies [[cljsjs/something "xyz version" ]] or is it ignored and i need to use npm install something and create a cljsjs shim as per the migration docs. I'm asking because i got errors about missing libs unless i did an npm install but my worry is that the cljsjs wrapper for some libs is doing more then a 1 to 1 translation to cljs. I don't have a specific example of this happening but it would be nice to be aware i need to tackle it.