Hi I’m trying to run https://github.com/ahonn/shadow-electron-starter. If I clone repo and use npm install with its current package-lock.json file using shadow-cljs ^2.8.110 it works. If I then run npm install shadow-cljs (updating to version ^2.16.12) run npm run dev and electron . it fails to start with

SHADOW import error /Users/kurt.harriger/projects/Logseq-Things-3-Plugin/shadow-electron-starter/.shadow-cljs/builds/main/dev/out/cljs-runtime/shadow.js.shim.module$ws.js
App threw an error during load
/Users/kurt.harriger/projects/Logseq-Things-3-Plugin/shadow-electron-starter/node_modules/ws/lib/websocket.js:414
      ...options
      ^^^
SyntaxError: Unexpected token ...

did you also update electron? I mean the current version there seams to be 16.0.7? in the repo is 8 so probably ancient history by now?

maybe you also have a really old node version? this isn't an error from anything shadow-cljs is doing. the error is outside of the code it controls

Initially i tried using yarn and things blew up because it downloaded newer versions not using package.lock and tried to revert and use npm then upgrade 1 at a time to isolate I suppose maybe it only upgraded the minor version or soemthing. Let me give it another try

yeah lock files in demo repos are problematic if the demo isn't constantly maintained. can't assume that something that was written 4 years ago still works

FWIW you don't see the error in the release build since the release build probably doesn't use the ws package. that is only used for the hot-reload/repl websocket

oh that makes sense why it only shows up in dev build. But yeah issue still shows up after upgrading to electron 16

node -v?

updated all the deps:

"dependencies": {
    "electron": "^16.0.7",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "shadow-cljs": "^2.16.12"
  }

electron -v v1.4.13

hmm npm WARN deprecated [email protected]: electron-prebuilt has been renamed to electron. For more details, see http://electron.atom.io/blog/2016/08/16/npm-install-electron

there we go that was the issue

uhm where did that version come from? v1.4.13

followed the instructions to npm install -g electron-prebuilt but appears thats where the problem was

looks like you have a really really old global install?

ah

I’ll send him a PR to update the example

thanks!

npm install electron-prebuilt -g
npm install shadow-cljs -g

just skip these two completely and just use npx electron and npx shadow-cljs. that'll use the version installed in the project and not some global

yeah thats sounds best. thanks