at the point the :configure hook runs the build config is already applied and as such modifying it has no effect

you can update [:compiler-options :closure-defines] directly instead

Hello. Yeah, thanks, I've figured that out already 🙂

Just wondered if it's a bug or I was not supposed to change build config in hooks.

I answered that. Intended to be like that

the webworker itself looks as follows

(ns quagga.components.dataview.worker)

(defn init []
  (set!
   js/self.onmessage
   (fn [^js e]
     (js/console.log "message received" (.. e -data)))))

I've added it to the modules like this

:worker
          {:init-fn quagga.components.dataview.worker/init
           :depends-on #{:shared}
           :web-worker true}

I've also added it to the html with a script tag of type "text/js-worker"

I'm calling postMessage as follows on the repl

(let [worker (js/Worker. "/js/quagga/worker.js")] (.. worker (postMessage "hello world")))

not sure what I'm missing

What comprises the module :shared? Given the stacktrace, there's some subs.cljs file in there that tries to reference js/document, which does not exist in web workers.

shared actually has nothing, it's defined like this

:shared {:entries []},

I think it's because all my other modules depend on shared

I tried to make the web worker module depend on :depends-on #{} but then it says

ExceptionInfo: two modules without deps, please specify which one is the default

Oh, interesting. Maybe I misunderstand something then. Shadow-cljs docs say: > You can leave the `:entries` of the `:shared` module empty to let the compiler figure out which namespaces are shared between the other modules. But that subs.cljs still comes from somewhere even though your web worker ns clearly doesn't depend on it. @U05224H0W Could it be a bug?

are there other modules that may cause stuff to be moved into :shared that the worker doesn't like?

can't say without your full config

:devtools
         {:preloads [day8.re-frame-10x.preload],
          :watch-dir "resources/public/css/"},
       :modules
         {:home
            {:depends-on #{:shared}, :entries [quagga.components.home.init]},
          :organization
            {:depends-on #{:shared},
             :entries [quagga.components.organization.init]},
          :settings
            {:depends-on #{:shared},
             :entries [quagga.components.organization.settings.init]},
          :shared {:entries []},
          :tabbed-dataview
            {:depends-on #{:shared},
             :entries [quagga.components.dataview.init]},
          :user-management
            {:depends-on #{:shared},
             :entries [quagga.components.organization.users.init]}
          :worker
          {:init-fn quagga.components.dataview.worker/init
           :depends-on #{:shared}
           :web-worker true}},
       :output-dir "resources/public/js/quagga/",

there probably are other modules bringing in code that's trying to use js/document

yeah so so since you only have :shared anything that two of the other modules may use will get moved to :shared

oh... ok

end as such also end up getting loaded by the worker

make an extra :base module or so

cool...

that the :shared and :worker depend on but have all the others only depend on :shared

both with :entries [] is fine

cool

Ah, I see. At least to me, the wording in the documentation made it seem like :shared has namespaces that are shared by all other modules that depend on :shared. Thanks!

yeah a namespace can only ever be in one module so if say something from :home and :settings share a required namespace the only place it can go is :shared.

> a namespace can only ever be in one module Now that you said it out loud, it became obvious to me as well. :)

unfortunately, I'm still getting the same error with this setup

:modules
         {:home
            {:depends-on #{:shared}, :entries [quagga.components.home.init]},
          :organization
            {:depends-on #{:shared},
             :entries [quagga.components.organization.init]},
          :settings
            {:depends-on #{:shared},
             :entries [quagga.components.organization.settings.init]},
          :shared {:entries []
                   :depends-on #{:base}},
          :base {:entries []}
          :tabbed-dataview
            {:depends-on #{:shared},
             :entries [quagga.components.dataview.init]},
          :user-management
            {:depends-on #{:shared},
             :entries [quagga.components.organization.users.init]}
          :worker
          {:init-fn quagga.components.dataview.worker/init
           :depends-on #{:base}
           :web-worker true}}

are you sure none of the namespaces used by the quagga.components.dataview.worker ns end up including the problem ns?

generate a build report, it'll tell you why something is where it is on mouse over

there's a line in worker.js that looks like this

SHADOW_ENV.load({}, ["goog.debug.error.js",..."day8.re_frame_10x.inlined_deps.re_frame.v1v1v2.re_frame.subs.js","shadow.cljs.devtools.client.browser.js","shadow.module.base.append.js","quagga.components.dataview.worker.js","shadow.module.worker.append.js"]);

I also suspect that dev tools are excluded from the build report somehow

so, I commented out :devtools from my app build

;;  :devtools
      ;;    {:preloads [day8.re-frame-10x.preload],
      ;;     :watch-dir "resources/public/css/"},

and that got rid of the error

I wonder if there's a way to disable dev tools for specific modules

ah its is the preloads yeah. you can move the preloads to the :shared module. just :shared {:entries [] :depends-on #{:base} :preloads [day8.re-frame-10x.preload]}

I'm trying to build them but it fails like this:

Hook [0 shadow.cljs.build-report/hook] failed in stage :flush
NoSuchFileException: .shadow-cljs/builds/psap/release/out/main.js

(also hi to my original hometown and thanks for making shadow-cljs 👋😄)

ah lemme try the standalone build

not a :browser build?

build reports only work with :browser currently

yup, it's :node-library

ah, too bad 😞

Indeed, the standalone run failed, as well

I think I was able to convert it into a :browser 💪 Still need to confirm whether the regression is reproducible this way, too. Stay tuned.

try setting :js-options {:js-provider :require}. it won't actually run in the browser that way but the build report won't suddenly contain all the bundled npm depenendeices

OK nice, the size increase still reproduces that way

And we got some build reports now

Looks like the main culprit is the application code itself

Its build output pretty much doubled in size

Maybe more inlining going on or something like that? :thinking_face: Any ideas how to dig deeper?

Maybe of note that said code is all .cljc

Ah but I can also see similar increases for the .cljs portions

I don't have any guess for you since I don't have a clue what you are doing 😛

there shouldn't be any big increases and I haven't had any other reports like that

nor noticed any increases in my own builds

Alright, then it's probably related to something unusual we're doing 😉 I wasn't asking about guesses moreso than hints how to investigate this further. The build report is a great help already, thanks a lot!

I guess we'll revert the update for now and try to get to the bottom of this. If we do or are able to come up with an isolated repro, we'll get back to you!

the only thing I can think of is running the build with --pseudo-names and looking at the output trying to figure out where it increase is coming from

--pseudo-names will make it huge regardless but at least you can figure out what the code was before optimizations

Great, thanks!