Fork me on GitHub
#shadow-cljs
<
2021-11-14
>
ghaskins16:11:28

@thheller im still trying to figure out whats going on, but upgrading from shadow v2.15.12 to both 2.15.13 or 2.16.4 results in errors related to goog.object

ghaskins16:11:32

does this sound familiar?

ghaskins16:11:35

goog$module$goog$object is undefined

ghaskins16:11:03

This is the minimal patch that is breaking me

ghaskins16:11:04

diff --git a/package.json b/package.json
index c689932..3425558 100644
--- a/package.json
+++ b/package.json
@@ -45,6 +45,6 @@
     "uuid": "8.3.2"
   },
   "devDependencies": {
-    "shadow-cljs": "2.15.12"
+    "shadow-cljs": "2.15.13"
   }
 }
diff --git a/project.clj b/project.clj
index 3bd6378..1877575 100644
--- a/project.clj
+++ b/project.clj
@@ -8,13 +8,13 @@
                                   :username [:gpg :env/gitlab_token_type]
                                   :password [:gpg :env/gitlab_token_value]}]]
   :dependencies [[org.clojure/clojure "1.10.3"]
-                 [org.clojure/clojurescript "1.10.879"
+                 [org.clojure/clojurescript "1.10.891"
                   :exclusions [com.google.javascript/closure-compiler-unshaded
                                org.clojure/google-closure-library
                                org.clojure/google-closure-library-third-party]]
                  [org.clojure/core.async "1.3.622"]
                  [org.clojure/test.check "1.1.0"]
-                 [thheller/shadow-cljs "2.15.12"]
+                 [thheller/shadow-cljs "2.15.13"]
                  [reagent "1.1.0"]
                  [re-frame "1.2.0"]
                  [kee-frame "1.3.1"]

thheller17:11:27

just make sure every namespace using goog.object also has a require for it. if some macro generates code accessing goog.object those need to be rewritten not to

thheller17:11:18

(or if things get to complicated to fix just :compiler-options {:global-goog-object&array true})

ghaskins17:11:45

@thheller ty, ill check it out