@chris358 that is not your requires, that is the require in those files. most likely they are doing some kind of dynamic require, eg. not require("some-string") but require(some_variable)

for :target :esm intended for node you want to set :js-options {:js-provider :import}. otherwise shadow-cljs will attempt to bundle everything which won't work for many node things

hi not sure if this is a shadow issue per se but since upgrading to react 17 we seem to have lost our code from the stack when getting errors in the console, so pre 17 we would get something like:

Warning: Failed prop type: The prop `open` is marked as required in `ForwardRef`, but its value is `null`.
    in ForwardRef (created by WithStyles(ForwardRef))
    in WithStyles(ForwardRef) (created by ui.views.reports.reports_dialog.render)
    in ui.views.reports.reports_dialog.render (created by ui.views.reports.reports_dialog.init)
    in ui.views.reports.reports_dialog.init (created by ui.views.meeting.home.render)

Warning: Failed prop type: The prop `open` is marked as required in `ForwardRef`, but its value is `null`.
    at eval ()
    at eval ()
    at cmp ()
    at cmp ()
    at div
    at eval ()
    at cmp ()

I don't really have a good idea of what might cause this but I know react 17 made some changes to the way the code is organised

@gingerwizard I'm guessing this is react? I haven't used react in a long time. don't know what changed in 17. only thing it looks like it is missing source maps?

I think in 17 react shipped as modules in some way that I'm afraid I don't fully understand

I'm not much of a UI guy really - if we are missing react source maps could that lead to not having our app code in the stack ?

looking at it in devtools I think I can see react source maps

fwiw I found a similar issue from a while back here that was closed without resolution, but shows at least it's unlikely to have anything to to with shadow https://github.com/mui-org/material-ui/issues/23600

@gingerwizard source maps map the JS location back to the original yes but you should be getting warnings in the browser console if source maps fail to load

if you get those it typically means that your :asset-path in your build config is misconfigured. if you get no warnings I would assume they loaded correctly and the problem is elsewhere

yup agreed :thumbsup::skin-tone-2: there is a problem in there somewhere - I would assume if it was a generic react 17 / mui issue the internet would be full of people complaining so likely something specific to our setup

well OK for anyone that reads this with a similar issue, I've been able to "resolve" it for now by rolling react back to 16.14.0. Unsatisfactory but seems to hang together for now

Hello 🙂 I am trying to use pnpm with shadow-cljs, and I appears that pnpm either does not install dependencies recursively, or that shadow-cljs does not work well with pnpm. Is there any shared experienced?

@neo2551 never tried pnpm so not sure what it does. all shadow-cljs cares about is a node_modules directory with all the packages. don't know what that looks like with pnpm

npm and yarn work fine

@thheller one difference might be that pnpm uses symbolic links instead of copying all the modules inside your node_modules dir, but like mvn it keeps each lib in a single place