curious @thheller -- if somehow a module ended up having exactly the same code in it between two builds, will the resultant js cache between builds as well? or does shadow/cljs/gclosure do something to prevent it from being the same bytes/etag/whatever

@robert-stuttaford it is somewhat unlikely for modules to be compatible between builds. it can happen but I wouldn't rely on it.

thought as much; just thought i'd confirm it with you

well done on modules, by the way. it's fantastic

given hot macros work with (gensym) and foo# they may be using different names in each build, which then may get different names in :advanced and so on

:modules is why all this exists in the first place 😉

😁

sup! is there any guidance around using node 12 vs 14?

any issues with either? it pretty much shouldn't matter at all?

well.... hahah yeah there are issues on my system, but who knows may be completely unrelated. I installed nodejs with scoop on windows then copy the shadow-cljs.edn file from the front page of shadow site, then npm install sahdow, etc... I just get a single error "? ? is not ISeqable", so kind of those impenetrable messages that don't really tell you much. So I began wondering if the node version mattered. Anyway, I removed the scoop node and I'm trying the official installer see if it makes any difference

I suspect is more of a problem of how my system is configured more than any shadow issue, but yeah I was wondering if 12 v 14 made any difference

node does not make a difference regarding shadow-cljs

it may make a difference for the code you are running on it

its not that impenetrable error message wise

this is what I saw:

also found it suspicious that shadow had those "..." instead of actual help

I guess I never tried to handle a typo?

the command line help typo is not the actual problem I think

here's a better example:

thats odd indeed. I'd guess that there are maybe some invalid "hidden" chars in the config?

hmmm yeah, let me try delete the file and try copy-paste again from the front page

there was a command to easily show such things but I can't remember what it was

if you send me the actual file I can check it out

and maybe improve the error message in the process

noooo just deleted it, yeah that was the problem, I think the file had the wrong encoding. So nothing to do with the nodejs scoop installed

maybe I can replicate that file... let me try

TF I think my emacs is loosing it

haha

ok cool, there's something wrong with my emacs. I could replicate the file.

please send to <mailto:[email protected]|[email protected]>

how you run re-frisk on react native? :thinking_face:

@stebokas I think you better ask those questions in #react-native.

I'm experiencing some weird issues with classpath override.. We basically have overridden a library with our own patches in src that shadow-cljs has previously used instead of the sources from the library. Now I'm getting:

[2020-08-04 14:47:11.441 - INFO] duplicate resource graphql_builder/generators/shared.cljc on classpath, using file:/Users/harri/.gitlibs/libs/floatingpointio/graphql-builder/7e8311225d5595e4456b8fd6338b127a80b7aab6/src/graphql_builder/generators/shared.cljc over file:/Users/harri/Development/hesburger/core-client/src/graphql_builder/generators/shared.cljc

is there a way to dissoc build options via the :`config-merge` option? use case: for the release build, we have set up ns-aliases. but for a specific release build, I want to remove one of those ns-aliases

@kommen there is not currently

ok, thanks

will look for another solution then

I just upgraded shadow-cljs from nashorn-js to graal-js and now I am getting problems in the compiled bundles. Compilation works, but vega npm dependencies cannot load when used in in transient project. this is the package that was making problems with polyfills (buffer / process) before. Is there any change in regards to this with the graal versions?

Trying to test my project and I’m getting the following, any suggestions where to look?

❯ shadow-cljs compile test
shadow-cljs - config: /Users/benny/projects/client/shadow-cljs.edn
shadow-cljs - connected to server
[:test] Compiling ...
========= Running Tests =======================
SHADOW import error /Users/benny/projects/client/.shadow-cljs/builds/test/dev/out/cljs-runtime/shadow.js.shim.module$$react_navigation$native.js
/Users/benny/projects/client/node_modules/react-native/index.js:13
import typeof AccessibilityInfo from './Libraries/Components/AccessibilityInfo/AccessibilityInfo';
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at wrapSafe (internal/modules/cjs/loader.js:1047:16)
    at Module._compile (internal/modules/cjs/loader.js:1097:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1153:10)
    at Module.load (internal/modules/cjs/loader.js:977:32)
    at Function.Module._load (internal/modules/cjs/loader.js:877:14)
    at Module.require (internal/modules/cjs/loader.js:1019:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/Users/benny/projects/client/node_modules/@react-navigation/native/lib/commonjs/useBackButton.tsx:2:1)
    at Module._compile (internal/modules/cjs/loader.js:1133:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1153:10)
===============================================
[:test] Build completed. (164 files, 163 compiled, 0 warnings, 7.45s)

you cannot import regular react-native packages without running through metro

only the :target :react-native works for react-native

no clue what to do testing with react-native

ouch

ok, so just to clarify, there’s no known way to test react native with shadow?

I don't know any. I'm sure there are but I don't use react-native so I have no clue how testing works there

whatever works with other tools will also work with shadow-cljs

i’ll check over in #cljsrn thanks @thheller

is there a way to break out the tested code so to ignore the rn-specific code during test execution?

one way would be to use a different source root for tests, but afaik you can only set the source root at the project root which breaks that theory

don't know what you mean

if i just want to test re-frame code for example, is there a way i could make my test target compile and test just that code?

that depends on your code

if its all in namespaces that don't otherwise use react-native stuff then sure

how would i configure shadow to look only at those namespaces though?

this isn’t legal:

:test
          {:target    :node-test
           :source-paths ["src/client/re-frame" "test"]
           :output-to "out/node-tests.js"
           :autorun   true}

source-paths are not relevant for what you are trying to do

shadow-cljs ONLY includes files that are directly referenced somewhere

it doesn't matter if files are other files on the classpath

https://code.thheller.com/blog/shadow-cljs/2018/02/08/problem-solved-source-paths.html

then when i run shadow-cljs compile test why does it try to compile the react native specific code if i’m not referencing it in my test sources?

test defaults to including namespaces that end in -test

so if any of those (or those they require) require react-native stuff it will end up including it

that’s pretty great, something somewhere is pulling in native code, but i will figure out what, it’s great to know it’ll only get pulled in if it’s referenced!