Fork me on GitHub
#shadow-cljs
<
2020-07-14
>
Yehonathan Sharvit00:07:22

what kind of issues could it cause @lilactown ?

lilactown02:07:02

you would be loading cljs.core twice

robert-stuttaford06:07:31

in upgrading from "2.8.83" to "2.10.14", our use of headless-chrome has started breaking: Uncaught ReferenceError: $jscomp is not defined - however, i see https://github.com/thheller/shadow-cljs/commit/04e636404e976761fb1eac675db55e5d12518246 as well. going to do a fresh node_modules. anything else we should try? update: clean node_modules didn't help.

thheller08:07:13

@robert-stuttaford which build :target? if you are using headless-chrome and only need to target that you can set :compiler-options {:output-feature-set :es8} which gets rid of most polyfills (which $jscomp is for)

robert-stuttaford08:07:56

thank you, giving that a go

robert-stuttaford08:07:26

that works, thank you!

Karol Wójcik13:07:01

Is it possible to create a wrapper library which consumes a npm library using shadow-cljs? I would like to make sure taht other build tools like figwheel-main could understand the generated source-code

thheller13:07:23

don't need to do that at all. consumers just need to use the new :bundle to get the npm package access. the code stays the same.

Karol Wójcik13:07:39

Thanks @thheller. Those are great news!

firstclassfunc13:07:46

Morning, Not sure if this was covered but any chance on adding git-deps t shadow-cljs.edn dependency resolution?

thheller15:07:38

@gary001 at some point yes. until then just use deps.edn.

👍 3
adam19:07:36

Hi guys. The live reload become painfully slow when I add: ["@material-ui/icons" :refer (ArrowForward)] The console says it’s processing 6557 files instead of 1013 once I add that import line. The solution seems to be described here but not sure how to do that in CLJS: https://github.com/mui-org/material-ui/issues/12422#issue-347896444

thheller19:07:30

@somedude314 definitely only import the icons you are actually using. all of them is madness.

thheller19:07:00

["@material-ui/icons/ArrowForward" :default ArrowForward]

❤️ 6
adam19:07:34

Ah thank you so much, that worked. I was trying ["@material-ui/icons/ArrowForward" :as ArrowForward :default defaultExport] and it was giving me an error.