Hello. I am attempting to write a macro in cljs using shadow-cljs. https://gist.github.com/samedhi/f8c6aa8eb5ca435ffac808da27e85978 . I have sidestepped most of the issues with referring to clojurescript ns by using their full names rather than using :as and a symbols to the respective ns. However, I am just not sure how to refer to a a NPM package "firebase-admin" from within my cljs macro. Two questions: 1. Is there a better way of referring to cljs ns from my macro? Some seem to work and some don't, quick summary on why that is? 2. How do I refer to node packages from a clojure macro? In my case I am attempting to use ["firebase-admin" :as admin], but that does not work within my clj macro namespace.

End goal is to have a testing helper that lets me write expressions like the following.

(deftest-function create-example-with-macro-test
  sut/create-example-cloudfx
  [doc1 "messages/message-1" {"foo" "bar"}
   doc2 "messages/message-2" {"foo" "baz"}]
  (t/is (not= (.get doc1 "foo") (.get doc1 "foo")))
  (t/is (not= "bar" (.get doc1 "foo")))
  (t/is (not= "baz" (.get doc2 "foo")))
  ;; And presumably also testing some side effect of the sut/create-example-cloudfx running
  )

@samedhi you can't reference JS namespaces directly in macros without using resolve-var. the common thing I recommend is doing something like (ns foo.bar (:require ["thing" :as x])) (def thing-you-need-in-macro x/foo)

and then using foo.bar/thing-you-need-in-macro in the actual macro

also follow https://code.thheller.com/blog/shadow-cljs/2019/10/12/clojurescript-macros.html

then you have the place where to put it right there

also very little of this macro would actually need to be written by this macro

I'd advise moving most of it out into a helper function and only use the macro to generate the boilerplate needed

@thheller just by chance do you remember how you added support for :default keyword into your ns analyze phase? as documented here: https://shadow-cljs.github.io/docs/UsersGuide.html#_using_npm_packages

cljs compiler’s analyze is choking on it and complains about it

I tried to look into shadow-cljs sources, but I don’t see any explicit mention how it is handled

when I try to pass shadow-cljs ns-form with :default into vanilla cljs analyze it gives me “Only :as, :refer and :rename options supported in :require / :require-macros…”

@darwin I replaced the ns parser with one that I wrote. https://github.com/thheller/shadow-cljs/blob/5ee9efcb7cae4ec558227bd04aa9d083c8aefc7c/src/main/shadow/build/compiler.clj#L169

the feature was kinda rejected though: https://clojure.atlassian.net/browse/CLJS-2376

ok, thanks, are you aware of anything else like :default which would cause error in ana/analyze in normal cljs?

if it is just :default, I can easily preprocess ns-forms before feeding them into cljs analyze

thats the only non-standard thing yes

ok, great, thanks

I'm messing about with yarn link to test some third party library feature that's not pushed to npm yet. Am I right to conclude shadow-cljs doesn't deal with links?

dunno what yarn link does exactly. symlinks are fine

I think they create symlinks, but have some extra registry in ~/.config/yarn/...

will try my hand at a manual symlink then 🙂

made a symbolic link to the directory node_modules but still getting

Search in:
	/Users/baruchberger/work/gsv/node_modules
You probably need to run:
  npm install 

See: 

so does /Users/baruchberger/work/gsv/node_modules/deck.gl/package.json exist or not?

I think http://deck.gl was one of those packages the closure compiler doesn't like? its from uber right?

If I want to develop a library in shadow-cljs that uses an NPM package, is there simply no way to distribute this as a jar that can be used in a non-shadow-cljs project?

The official documentation is a bit lacking in this area

> Please note that currently only `shadow-cljs` has a clean automatic interop story with `npm`. That may represent a problem for users of your libraries using other tools. You may want to consider providing a CLJSJS fallback and/or publishing extra documentation for `webpack` related workflows.

So what does this mean in practice? Either I create a CLJSJS package in which case the business value of shadow-cljs diminishes or I distribute some kind of setup instructions with the library?

What would that "extra" documentation look like, though?

Yes, it's from uber, huge repo. https://github.com/uber/deck.gl/blob/master/package.json they seem to work with lerna for sub modules.

Either way no issue if this isn't supported for now 🙂.

@simongray there is a trick, you can add a deps.cljs in your source root, and there you can declare NPM deps, example: https://github.com/wilkerlucio/pathom-viz/blob/master/src/core/deps.cljs

them, if you use the CLJS library with Shadow, it will automatically install those deps

oh, sorry, just noticed you asked for non-shadow, in that case will be hard considering that no other cljs build tools have proper support for NPM directly

@simongray yeah you pretty much have to create a matching cljsjs package. if you configure things correctly shadow-cljs will use npm directly and the others will fall back to cljsjs

or you can skip the cljsjs and provide manual instructions for people using webpack+cljs

I don't know how many people actually use webpack+cljs though

aynone seen this error? “Requested module does not have an export <name>” it gets printed afte “Closure compilation failed with 2 errors”

I’m trying to convert react-three-fiber examples into cljs with shadow-cljs, and wanted to require their shader js files as is by following https://shadow-cljs.github.io/docs/UsersGuide.html#_requiring_js (using absolute path)

I put this file[1] on classpath and then require it as ["/resources/shaders/Backface" :as BackfaceMaterial], shadow-cljs then complains ` [1] https://github.com/react-spring/react-three-fiber/blob/master/examples/src/resources/shaders/Backface.js

I decided to give the AdoptOpenJDK 13 a try and it seems to work for the most part. But there are some bizarre errors that pop up intermittently during compilation. It seems that it always involves clojure.lang.KeywordLookupSite$1. Example 1:

------ WARNING #1 - :invalid-arithmetic ----------------------------------------
 File: /home/p-himik/dev/git/ensemble/src/hgs/strayhorn/named_expressions/views.cljs:26:5
--------------------------------------------------------------------------------
  23 |                                       (cst/split model ",")
  24 |                                       [])))
  25 |         roman-on-change #(on-change (cst/join "," %))]
  26 |     (fn [_ & {:keys [error]}]
-----------^--------------------------------------------------------------------
 cljs.core/unsafe-bit-and, all arguments must be numbers, got [#object[clojure.lang.KeywordLookupSite$1 0xae194d44 "clojure.lang.KeywordLookupSite$1@ae194d44"] number] instead
--------------------------------------------------------------------------------
  27 |       [rc/v-box
  28 |        :gap "10px"
  29 |        :children [[rc/horizontal-bar-tabs
  30 |                    :tab-style tabs-style
--------------------------------------------------------------------------------

------ ERROR -------------------------------------------------------------------
 File: jar:file:/home/p-himik/.m2/repository/com/cognitect/transit-cljs/0.8.256/transit-cljs-0.8.256.jar!/cognitect/transit.cljs:295:6
--------------------------------------------------------------------------------
 292 |   ([tag-fn rep-fn str-rep-fn]
 293 |      (write-handler tag-fn rep-fn str-rep-fn nil))
 294 |   ([tag-fn rep-fn str-rep-fn verbose-handler-fn]
 295 |      (reify
------------^-------------------------------------------------------------------
Syntax error macroexpanding cljs.core/deftype.
ClassCastException: clojure.lang.KeywordLookupSite$1 incompatible with clojure.lang.IFn
	clojure.spec.alpha/spec-impl/reify--2059 (alpha.clj:923)

------ ERROR -------------------------------------------------------------------
 File: /home/p-himik/dev/git/ensemble/src/hgs/ella/score_details/sequences/views.cljs:297:3
--------------------------------------------------------------------------------
 294 |     :children (mapv (fn [w] [rc/label :label w]) issues)]])
 295 | 
 296 | (defn question-panel [_game-id changeset-id q args]
 297 |   (let [{:keys [events subs]} args
---------^----------------------------------------------------------------------
Syntax error macroexpanding cljs.core/nil?.
ClassCastException: clojure.lang.KeywordLookupSite$1 incompatible with clojure.lang.IFn

Can you make any sense of it?

Couldn't find anything on the warning about unsafe-bit-and. But the warning about ClassCastException is also mentioned here: https://github.com/thheller/shadow-cljs/issues/443 As well as OpenJ9 (aka AdoptOpenJDK I believe). I do embed shadow-cljs, but I definitely don't interact with the REPL in any way when these issues occur.

@p-himik not a clue. I've been on openjdk 13 since it came out without issues

Yes, in my experience unless it's a simple project, is close to impossible to run shadow-cljs on OpenJ9. These errors happen sometimes, specially when I'm using macros or core.async

never tried openj9. do other clojure apps work? don't know why shadow-cljs would break. its just normal clojure.

Yes, everything works fine. I remember that in the past I opened another bug on shadow because of OpenJ9 (something about detecting if a file was stale, if I'm not mistaken)

This one: https://github.com/thheller/shadow-cljs/issues/383

To be honest, I did not try other CLJS implementations like Figwheel, so it can be a ClojureScript compiler issue too...

I'm curious if anyone would know of this to be a problem.

(defmacro slurp [file]
  (clojure.core/slurp (io/file (io/resource file))))

(ns ezmonic.e-data
  (:require [cljs.reader :as reader])
  (:require-macros [ezmonic.util :refer [slurp]]))

(defonce data
  (reader/read-string (slurp "number-to-word-tree.edn")))

parsing 6MB of EDN is really slow. the emulator is just too fast.

I would not expect it to have to parse the EDN when going to/from the background though. I would only expect that on startup, no?

maybe you aren't allowed to use that much memory?

I don't do react-native development. maybe try asking in #cljsrn

also consider reading https://code.thheller.com/blog/shadow-cljs/2019/10/12/clojurescript-macros.html

:require-macros is so ugly 😛

6MB of EDN source will be much more are runtime, do you have stats about memory use for the app?

Good ideas. I'll take a look at the memory, and thanks for the link.