Fork me on GitHub
#shadow-cljs
<
2019-11-24
>
martinklepsch15:11:15

@thheller I’m playing around with the prepl stuff and am trying to use a version of shadow-cljs with some changes locally. Is it “supported” to provide the shadow cljs deps via tools.deps :local/root?

thheller15:11:10

not really. shadow-cljs has a bunch of java sources that need to be compiled. deps.edn doesn't deal with this

thheller15:11:13

you can sort of use it I guess if you run lein javac in the :local/root dir

thheller15:11:29

but I don't really keep the deps.edn updated so that is probably out of date

martinklepsch15:11:57

Ok, do you have a workflow you’d recommend as an alternative?

thheller15:11:36

dunno what kind of changes do you have in mind?

thheller15:11:03

open the shadow-cljs repo itself. run lein with-profiles +cljs repl and (require 'repl) (repl/go)

thheller15:11:26

thats why I do. (shadow.cljs.devtools.api/watch :browser) or any of the other tests builds

thheller15:11:38

lein with checkouts works too

thheller15:11:12

just lein install works if you have to. I've never really worked on shadow-cljs from inside another project

martinklepsch15:11:14

ok cool, I’ll give using the test builds a try then

p-himik17:11:57

Is it possible to have :source-map true but not have //# sourceMappingURL=....map in the built JS file?

thheller17:11:07

why would you want that?

p-himik17:11:14

I want to upload the source map to a third-party logging service instead of having it available on the production website. Having sourceMappingURL doesn't really hurt but it produces an extra 404 error if there's no map when I open the dev tools.

thheller17:11:22

you could put empty files there 😉

p-himik17:11:18

Yeah, true. Feels just a tad dirty though. 🙂 But it's probably what I'll do.

thheller17:11:46

if you open an issue I can see how much it would take to add that. probably not much.

p-himik17:11:05

Done! I've started looking into it myself, but there are a few places where the line gets appended, and some of those places have scary FIXME so I decided to ask here instead.

p-himik18:11:33

Another question - my manifest.edn contains a duplicated entry within :entries . Is this OK/normal?

p-himik18:11:22

From the prod version: :entries [hgs.platform.core hgs.platform.core].

thheller18:11:57

do you have it configured as :entries [hgs.platform.core] :init-fn hgs.platform.core/init or so?

thheller18:11:25

doesn't really matter if its duplicated though. its still just included once

p-himik18:11:01

Yep, that's exactly how the main module is configured. I see, thanks!

thheller18:11:05

you can skip the :entries if its just the same ns as :init-fn

👍 4