I'm using shadow-cljs to compile react-native to an Android emulator (code is forked from https://github.com/PEZ/rn-rf-shadow ) It works fine until I encounter an error. Sometimes they disconnect the CIDER nREPL (started via Emacs M-x cider-jack-in-cljs) with the runtime in the Android VM, then all REPL commands result in:

example.repl> (js/alert "test")
REPL command timed out.

(note that the hot-reloading part of shadow-cljs still works fine, it's just the REPL connection that gets borked)

So @thheller I noted that you mentioned in #cljs-dev that CLJS is stuck at an older version of Google Closure compiler -- is that something that carries over to shadow-cljs too or do you override the google closure dependency?

I'm having some trouble using the main option for node-test targets... given this namespace:

(ns app.core-spec
  (:require [cljs.test :refer-macros [deftest is]]))

(deftest something (is true))

:test {:ns-regexp "app.core-spec"
         :output-to "out/test.js"
         :target :node-test}}

$ shadow-cljs compile test && node out/test.js
shadow-cljs - config: D:\sandbox\devcards-test\shadow-cljs.edn  cli version: 2.8.69  node: v10.16.0
shadow-cljs - socket connect failed, server process dead?
[:test] Compiling ...
[:test] Build completed. (47 files, 2 compiled, 0 warnings, 2.04s)

Testing app.core-spec

Ran 1 tests containing 1 assertions.
0 failures, 0 errors.
Done in 13.20s.

(ns app.core-spec
  (:require [cljs.test :refer-macros [deftest is]]
            [shadow.test.node :as stn]))

(deftest something (is true))

(defn main []
  (stn/main))

:test {:main app.core-spec/main
         :output-to "out/test.js"
         :target :node-test}}

kamik@RED-X1C6 MINGW64 /d/sandbox/devcards-test (master)
$ yarn test:once
yarn run v1.17.3
$ shadow-cljs compile test && node out/test.js
shadow-cljs - config: D:\sandbox\devcards-test\shadow-cljs.edn  cli version: 2.8.69  node: v10.16.0
shadow-cljs - socket connect failed, server process dead?
[:test] Compiling ...
[:test] Build completed. (47 files, 2 compiled, 0 warnings, 1.89s)

Ran 0 tests containing 0 assertions.
0 failures, 0 errors.
Done in 12.60s.

I also tried using both :main and :ns-regexp at the same time but that failed with a weird error

why are you trying to override :main?

I think the issue with par-compile might be that it sets up a circular dependency if your ns-regexp matches your main ns

possible that I don't check that

make sure that the "runner" doesn't match the regexp

also do yourself a favor and run shadow-cljs server separately. waiting 12sec to a test to run is horrible

yeah on the real project I start the server separately, I didn't do it here because I forgot

I'm trying to override main because on my real setup there's some logic I need to run conditionally at the start

so the intended usage is that both main and ns-regexp need to be set?

:ns-regexp controls which namespaces are included yes

you can leave it to something that doesn't match and include all the namespaces in the :main ns directly

doesn't matter really

the user guide mentions that it defaults to "-test$"

it does

so I thought that if I set main without setting ns-regexp it would run the tests in the included namespaces in main, including itself

Testing app.core-spec

that doesn't match -test?

it doesn't, so it falls into the case you suggested: > you can leave it to something that doesn't match and include all the namespaces in the :main ns directly

ns-regexp didn't match anything but in main there was a test

well not really ...

WHAT THE FUCK IS THIS NEW FUCKING SLACK SHIT

the future is coming thheller, and it is annoying

drives me mad ... can't type :main anymore without it trying to make it something else

so the way this works is that :ns-regexp is responsible for adding namespaces

it does get better though, on my work slack it started last week and everyone had the same reaction, this week no one seems bothered

just accepting everything is shit I guess ...

:main only controls running the tests and it loads the tests via a macro

thats why the :main ns needs a {:dev/always true} annotation in the ns

otherwise the macro can't update properly

ok slack ... just don't highlight ... thats fine ...

might be a problem if you just delegate to the default runner ns

totally possible this all has a bunch of issues. I basically only tested the default setup

ok, I think I'm starting to understand a bit better... so if I want to both have my own main (for init logic), and not match any ns (because I don't have dedicated test ns), is there an approach I can take?

you mentioned just including the ns in the main ns

will try that

if you write your own main-ns I would suggest copying the default as is and only override what you need

do not delegate to it

the interaction with the macro is a bit funky

https://github.com/thheller/shadow-cljs/blob/0aaa281853d113829d01a6ba09cc328578b969cc/src/main/shadow/test/node.cljs#L15

thats the macro

and the :main ns needs https://github.com/thheller/shadow-cljs/blob/0aaa281853d113829d01a6ba09cc328578b969cc/src/main/shadow/test/node.cljs#L2

I tried these ns and it seems to run with main

(ns app.core-spec
  (:require [app.core-spec-two]
            [shadow.test.node :as stn]))

(defn main []
  (stn/main))

(ns app.core-spec-two
  (:require [cljs.test :refer-macros [deftest is]]))

(deftest something (is true))

will try the way you just mentioned

hmm, so the above finds and runs the single tests

but using the ns as you said does not

(ns app.core-spec
  {:dev/always true}
  (:require
   [shadow.test.env :as env]
   [cljs.test :as ct]
   [shadow.test :as st]))

;; FIXME: add option to not exit the node process?
(defmethod ct/report [::ct/default :end-run-tests] [m]
  (if (ct/successful? m)
    (js/process.exit 0)
    (js/process.exit 1)))

(defn main []
  (-> (env/get-test-data)
      (env/reset-test-data!))
  (st/run-all-tests))

$ shadow-cljs compile test && node out/test.js
shadow-cljs - config: D:\sandbox\devcards-test\shadow-cljs.edn  cli version: 2.8.69  node: v10.16.0
shadow-cljs - connected to server
[:test] Compiling ...
[:test] Build completed. (46 files, 1 compiled, 0 warnings, 0.82s)



Ran 0 tests containing 0 assertions.
0 failures, 0 errors.
Done in 1.83s.

please just out of habit STOP using the same namespace pattern for :mountain:

ok slack ... whatever ...

use something like app.test-runner or so for :main

please setup a demo repo for this .. can't look into it further right now

roger, will do

thank you for your time

how would I tell shadow-cljs where is my html file to take from?

I mean, do I have to manually copy it to the build/target folder?

shadow-cljs has no support for processing html, so yes you copy it manually or with another tool

okay. maybe I could use webpack here to do it

When trying to host my app, i'm noticing that the the requests by the browser triggered in the index.html to load the other assets (e.g main.js) are returning 404. I assume there is some path issue i need to resolve. I assume this is a function of the hosting service (in this case google bucket) but i wanted to ask here in case there is some configuration concept im missing. I dont think any of the production settings (e.g url hashing) would make a difference and i didnt see anything else listed.

maybe setting homepage in the package.json?

if the initial load already fails then your path in the html is incorrect?

I haven't used the google stuff before. I'm assuming you upload the files somewhere so make sure you upload all the files properly?

Thanks heller. The issue seems to be that the requested url is missing the bucket name e.g. its requesting http://storage.googleapis.com/js/compiled/main.js but the file is at http://storage.googleapis.com/<bucket-name>/js/compiled/main.js

that means you use :asset-path "/js" and likely need "js"

or just including the bucket-name if you know it

because /js implies relative?

no /js implies absolute from the domain root

js is relative to the current file

that'll become js/main.js loaded from index.html

oh

that will be it then

if you just have one file you only need to change your HTML

so that it loads <script src="js/main.js"> :asset-path does nothing for the initial file, only if you use multiple :modules

we do use multiple modules.

ok then :asset-path is relevant too. still need to change the html for the initial load though

Is it possible to get some sort of debug in compilation process using console flags? I am trying to debug my configuration of :source-paths ["src" "env/dev"] (ns-es in "env/dev" are ignored for some reason).

@muhanga do you mean that the namespaces are not found, even though the files exist on disk?

@lilactown Yes. I have namespace 'tst.cards' declared in "env/dev" dir and it is ignored and not taken into compilation. I have :lein true enabled, but i am not sure how those two interract.

what’s the file path to that namespace?

env/dev/tst/cards.cljs?

are the source paths defined in a leiningen profile?

@lilactown file path is env/dev/cljs/tst/cards.cljs . And source paths are defined in leiningen profile and i am able to build using lein.

That path is wrong. It will resolve the ns from the root of the source path

it’s looking in env/dev/tst/cards.cljs and not finding the file

if you want to nest it in that cljs directory then you need to add to the source-path instead

:source-paths ["src" "env/dev/cljs"]

Okay, this actually shed some light. Does shadow-cljs actually use :source-paths declared in lein config when :lein true is declared? Or it uses :cljsbuild\{build}\source-paths ?

Cause i think that anything inside :cljsbuild are actually ignored.

:lein true will use the source-paths defined in your leiningen config. it does not use anything to do with cljsbuild

Nasty. so if i want to be able to build cljs using both lein and shadow i basially need to disable :lein true

if you prefer to split your config and source paths between CLJ and CLJS, then what I typically do is use leiningen to manage CLJ dependencies and source paths and shadow-cljs.edn to manage CLJS dependencies and source paths

you can also specify a profile to use, if you prefer

why do you want to be able to build with both lein and shadow?

https://shadow-cljs.github.io/docs/UsersGuide.html#Leiningen

@lilactown Ouch. I need to read docs again. And couple of time more.

@dpsutton as of now i am trying to understand how shadow works so using it on existing lein project help me immensly. So i am trying to make them work in parallel. But more i try, more i think this is not really ideal approach to learning.

i would branch and move over. if works PR

i did exactly that and unfortunately we couldn't move over since we serve our front-end over https and local networking hyjinx but figwheel will happily connect an insecure websocket over ws not wss

@dpsutton :devtools-url "`http://localhost:9630``"` should work and also use ws:// even if you serve the initial page over https?

@muhanga any cljsbuild config is ignored but you can just setup regular :profiles {:dev {:source-paths ["src" "env/dev"]}} with :lein true

@dpsutton there are some Clojure libraries that only works with lein

@thheller i'll try that this afternoon. thanks

https://github.com/oliyh/kamera

I wish I could use shadow-CLJS with that :)

kinda tough if that uses figwheel directly 😛

that uses figwheel main?

but i'm sure it could be ported over. just no benefit i suppose. i don't think devcards require figwheel just its a bit easier

devcards works just fine in shadow-cljs

but kamera has a bunch of clojure code that is talking directly to figwheel

so that all would need to be replaced

dunno why it is talking to figwheel at all though

Basically i am trying to bootstrap spring + reagent + d3 + devcards combo to shadow-cljs (with minimal changes of lein configs) and everyting expect devcards works very nice with shadow. Looks like i will need to bite the bullet and do some rewrites from scratch. Thank you all.

which part of devcards doesn't work?

devcards require a constant to be set. have you ensured that is set?

@thheller for some reason devcards can't find react during initialization emiting bunch of "React is not defined"

yes, that is because devcards doesn't declare its dependency on react in any way

so you include [cljsjs.react] and [cljsjs.react.dom] in your code somewhere before including devcards

then it should be fine

Yep. It worked.

I am happy camper now. Thank you very much for this bits and pieces of knowledge.

Haha the devcard trick also took me a while to figure out