Sure, sorry, I think I worded that really poorly. I was under the impression when you connect to that prepl it isn't a ClojureScript environment but that was 2nd hand information, I'll try it for myself.

Thank you for adding prepl support in the first place! I'll try to get Conjure + shadow-cljs prepl documented somewhere, I just have 0 / negative free time right now.

From what i understand they should be able to work out of the box, yet i get Error from :frontend java.io.IOException: Stream closed

Ah, interesting, let me have a go. If I get it working I'll add a link / guide here https://github.com/Olical/conjure/wiki

Gimmie 20 minutes

🙂 thanks, the stream closed error is pretty generic, i wasnt sure if it is helpfull

That just means the socket is kicking you off just after you connect which could be because node / your browser isn't running / ready to evaluate JavaScript on the behalf of shadow-cljs... I think...

Building a demo repo

While I eat katsu curry 😅

I can change it so it doesn't kick you off but instead waits for a runtime? if that makes sense

it sends out {:tag :err :msg "No available JS runtimes!"} currently before kicking

Hmm that could be pretty neat :thinking_face: might help in scenarios where you refresh the browser or something? Would it be able to hook you up to the new environment?

If not, no worries. With Conjure you just hit one key combo and it'll reconnect whatever it can anyway.

(`<localleader>cu` or :ConjureUp)

> Ah I understand what you mean now, thanks for the explanation! I would argue you go for the first environment and maybe disconnect the prepl if there's nothing there, that way the client will know it's reconnecting to a new environment.

your words 😛

lol, sounds good then, thanks past me!

@U38J3881W with (`<localleader>cu` or :ConjureUp) i get disconnected immediately

Yep, trying to repro and investigate now, I've been putting off investigating for a while.

Hmm, sorry to bother you @thheller, I'm just trying to netcat into a prepl I started, I'm using npx shadow-cljs node-repl with what I think is some super basic config

{:builds
 {:demo
  {:target :node-script
   :modules {:main {:init-fn conjure-demo.main/init}}}}
 :prepl {:demo 36751}}

(not even using Conjure right now, just trying to netcat into the port)

you used node-repl. that isn't related to :demo in any way

🙃 I'm a shadow-cljs noob and I should've really learned earlier. I'll dig the docs.

:prepl {:node-repl 36751}

Thanks!

that should do it

Oh so node-repl is like a built in "build"

yes

That's cool

But I guess I could watch demo or something too.

Hmm, no output from the netcat but a big ol' blob of EDN in the shadow-cljs stdio

[:repl-unknown {:type :repl/session-start, :id "67bcbfa5-55...

try browser-repl .. I think node-repl is missing some things

Ah, interesting!

I am trying browser-repl the last 10 minutes and getting stacktraces

` [:app] Build completed. (405 files, 1 compiled, 0 warnings, 6.62s) 32 Exception in thread "Clojure Connection repl 1" clojure.lang.ExceptionInfo: failed compiling file:out/clojure/browser/event.cljs {:file #object[java.io.File 0x72769185 "out/clojure/browser/event.cljs"], :cloj 33 ure.error/phase :compilation} `

I might know what that is and might be able to patch it in shadow for you, hang on.

$ nc localhost 12345
(js/console.log "foo")
{:tag :ret :ns cljs.user :form "(js/console.log \"foo\")" :ms 1 :val nil}

Yeah, so :val is coming back as data, it needs to be a string.

That's the Clojure contract and I think something I patched in ClojureScript.

It needs to be a string because you can't parse some things that came from another environment, such as records and reader conditionals. So you can pr-str it in the eval environment but then you need to turn it into a string to make sure the prepl data is parseable in ANY environment. Then the prepl client can decide to keep treating the response as just a string or it can try to parse it in whatever way it deems correct.

oh right

So yeah, don't provide data as data in a prepl payload from an env because the string serialisation doesn't always match up on the other end.

i'll fix that

I can patch it if you don't have time but yeah, small nuance that I know of. I should really write up a "prepl spec" that I've inferred since it isn't documented.

I've been patching Clojure and ClojureScript to bring both of their prepl implementations inline with each other 😬

https://github.com/Olical/conjure-shadow-cljs-example demo repo is here for when it returns strings 😄

Oh the other thing to check: When an exception is caught it should return the data in :val as a string (output of Throwable->map I think?) then set :exception to true on the top level of the message.

I have a patch going into the next ClojureScript version which sets this :exception flag.

And one into the next Clojure version which allows reader conditionals (ClojureScript already has them).

should i open an issue somewhere ?

just to keep track when/if the problem has ben solved ?

https://oli.me.uk/clojure-prepl-for-tool-authors/ for future reference, I've written up how prepls should respond / work