@thheller Sorry to bother you again with this. Some more info with the broken stuff I'm seeing whenever I restart shadow-cljs. This seems to be the "root" error, AFAICT.

no it is not the root

it is just telling you that it failed to load that module. the reason that it failed is somewhere else

above or below, can't remember right now

just paste everything?

try {
        moduleFn.call(
          module,
          goog.global,
          shadow.js.jsRequire,
          module,
          module["exports"]
        );
      } catch (e) {
        console.warn("shadow-cljs - failed to load", name);
        throw e;
      }

It's a huge log that doesn't copy well -- but this snippet shows shows that the root error is below.

The only "error" in the console is at the very end:

main.cljs:105 Uncaught TypeError: nosco.routes.start_routing_BANG_ is not a function
    at Object.nosco$views$main$start [as start] (main.cljs:105)
    at admin:14
nosco$views$main$start	@	main.cljs:105
(anonymous)	@	admin:14

also not the root

well it might be ... the problem is that it might not exist because loading it failed

or it might not exist because of other reasons

no way for me to tell without seeing more errors

main.js:2176 failed to load nosco.views.page_list.js TypeError: global(...).default.createContext is not a function
    at Object.shadow$provide.module$node_modules$react_redux$lib$components$Context (Context.js:11)
    at shadow.js.jsRequire (js.js:63)
    at Object.shadow$provide.module$node_modules$react_redux$lib$components$Provider (Provider.js:15)
    at shadow.js.jsRequire (js.js:63)
    at Object.shadow$provide.module$node_modules$react_redux$lib$index (index.js:8)
    at shadow.js.jsRequire (js.js:63)
    at Object.shadow$provide.module$node_modules$react_beautiful_dnd$dist$react_beautiful_dnd_cjs (react-beautiful-dnd.cjs.js:14)
    at Object.shadow.js.jsRequire (js.js:63)
    at Object.shadow.js.require (js.js:97)
    at eval (/js/cljs-runtime/nosco.views.page_list.js:8)

please ignore all "failed to load" errors

well .. are there any others I mean?

That's the whole console log

Not sure if there's a better way to paste it...

ok failed to load nosco.views.page_list.js TypeError: global(...).default.createContext is not a function that seems to be the actual error

now .. to diagnose this further. please shutdown shadow-cljs completely

DO NOT DELETE ANYTHING!

just kill shadow-cljs

then start the watch again and please verify that it does NOT say connected to server on startup

that it is indeed restarting

Done. BTW the offending file looks like so:

shadow$provide["module$node_modules$react_redux$lib$components$Context"] = function(global,require,module,exports) {
"use strict";

var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");

exports.__esModule = true;
exports["default"] = exports.ReactReduxContext = void 0;

var _react = _interopRequireDefault(require("react"));

var ReactReduxContext = _react["default"].createContext(null);

exports.ReactReduxContext = ReactReduxContext;
var _default = ReactReduxContext;
exports["default"] = _default;
};

looks exactly like it should

well not exactly but close enough

No other shadow running, verified by jcmd, here's the new startup log

shadow-cljs - config: /Users/orestis/dev/nosco/gamma/shadow-cljs.edn  cli version: 2.8.55  node: v12.9.0
shadow-cljs - starting via "clojure"
INFO  [main] org.xnio  - XNIO version 3.7.3.Final
INFO  [main] org.xnio.nio  - XNIO NIO Implementation Version 3.7.3.Final
INFO  [main] org.jboss.threads  - JBoss Threads version 2.3.2.Final
shadow-cljs - server version: 2.8.53 running at 
shadow-cljs - nREPL server started on port 61137

ok and the compile finished with "Build completed"?

[:main] Build completed. (852 files, 851 compiled, 0 warnings, 31,49s)

what the heck? why did it compile so many files?

And now everything works because I was poking around before, and renamed something in .shadow-cljs/builds/main/dev/. I have the original files around.

...

😛

I was hoping to do some debugging on my own before bothering you!

you are not bothering me when reporting bugs/problems

I WANT to hear about them .. otherwise they never get fixed

if people resort to the standard lein clean practice before compiling ... just because ... I'll consider this project failed.

that is simply not acceptable to me 😛

unfortunately the cache files alone don't help much in debugging

but yeah the thing to look out for if you change depdendencies

OK, just by killing the server and restarting shadow, I have the same problem.

No new files, no new dependencies.

is that you actually restarted and there is no second shadow-cljs instance running

good!

now it is in the broken state? what was the last "Build completed"?

This time, [:main] Build completed. (851 files, 1 compiled, 0 warnings, 5,92s)

good

Broken state, browser console.log is like the one I pasted

now please make sure you have the browser cache completely cleared?

I assume there is no Service Worker running?

Yep, browser cache is disabled, serving files with Cache-Control: private, no-cache, no-store

No service worker or fancy stuff

ok. do you use multiple :modules or just one?

Single module.

so you have a rather large .js file that is loaded I presume?

{:target :browser
         :output-dir "dev-resources/public/main/js"
         :asset-path "/js"
         :modules {:main {:entries [nosco.views.main]}}
         :compiler-options {:infer-externs :auto}
         :devtools {:watch-dir "dev-resources/public/main"
                    :loader-mode :eval}
         :release {:output-dir "gamma-dist/main/js"
                   :closure-defines {nosco.routes/WORMHOLE-EXIT true
                                     nosco.controllers/ALL-FEATURE-FLAGS-ENABLED false}
                   :module-hash-names true
                   :cache-blockers #{gamma.translate}
                   :build-hooks [(gamma.translate/write-pot-file "translations/gamma.pot")
                                 (gamma.translate/clear-messages)]
                   :build-options {:manifest-name "manifest.json"}}}

That's the build conf, single large .js file, deps.edn for dependencies.

ok then check the dev-resources/public/main/js/main.js file

11MB. I can share if it helps?

that'd be good yes

<mailto:[email protected]|[email protected]>

ok one thing that I would suggest

it looks like you have a top level function call directly in your nosco.views.main?

(start)?

No, that's called by index.html:

<script src="/js/main.js"></script>
    <script>
      nosco.views.main.start(document.getElementById("main"))
    </script>

The code for that is

(defn ^:export start [el]
  (reset! EL el)
  (add-watch nosco.controllers/app-state :main-render
             (fn [_ _ _ s]
               (js/console.log "new state is " s)
               (let [{:keys [user siteConfiguration]} s]
                 (when (and user siteConfiguration)
                   (js/console.log "initial render")
                   (react-dom/render
                    (hx/f [Main])
                    el)))))
  (routes/start-routing!))

can you take out the start call for a second?

just to remove some errors

what does nosco.views.page_list do?

seems like it does some code on load?

(ns nosco.views.page-list
  (:require
   [hx.react :as hx :refer [defnc]]
   [hx.hooks :refer [useState useContext]]
   [nosco.ui.table :as table]
   [nosco.ui.components :as components]
   [cljs-bean.core :refer [bean ->clj ->js]]

   ["react-beautiful-dnd" :refer [DragDropContext Droppable Draggable]]))


(def initial-items
  (mapv #(hash-map :order % :id (str "oid-" %) :title (str "Item " %)) (range 10)))

Apart from a defining a bunch of components, that's the only "work" it does.

@orestis I found something suspicious

SHADOW_ENV.evalLoad("module$node_modules$React$index.js"

SHADOW_ENV.evalLoad("module$node_modules$react$index.js"

I guess that can be considered a bug

you are including 2 versions of react on the page

do you have a (:require ["React" ...] somewhere in your code or is that caused by some library?

I’ll check! Thanks for the detective work.

nosco.controllers seems to be it

Yup, that's it.

["React" :as React] -- in all other files, there is ["react" :as React]

I have no clue why that would break stuff but it is one suspicious thing I found

I'm on macOS which I is case insensitive, so the filename resolves to the correct file I guess.

How should I debug this now? Changing the import and relying on hot reload threw an error.

well that'll require a full page reload

it is in a state that can't be hot-reloaded otherwise

not sure this is the cause of your issues ...

just looked weird when looking through the code

Still the same error. Would force compile help?

what error?

There might be a chance that with all other react libraries, something else might be doing the same thing, but I think that various CI tools would catch it.

Same errors in browser console.

Should I restart something?

hmm maybe try wiping the cache

I think this might be the cause of all sorts of weird issues

So that would be .shadow-cljs/builds/main? Is that the "root" cache?

yes

I think this might be the actual cause of your problems .. let me know if it happens again

And should it be done while shadow is running? Or should I stop shadow, wipe the cache, start again?

stopping the build would be enough

ok I think I found the bug causing this ... something I've been meaning to address for a while

but yeah it should be fixed in you stick to "react" only

Things are working again (but they always work if I blow away the cache). I'll start over again and see what happens.

Works! Many thanks for helping here. Final question, is calling the start function from HTML discouraged?

no that is fine. from the stacktraces it just looked like things were going wrong while loading because of the start call

but they weren't ...

Cool. I've just noticed your Github sponsor page is online, so... 😄

thanks 🙂

still trying to figure out how your bug actually happens ... seems like it should either always happen or never

not quite sure why it breaks after a restart

but I added an additional check that should make the error easier to find 😛

Happy to help if I can.

@thheller I think case-(in)sensitivity is a major theme in my codebase 😄. Just found a case where importing date-fns/parseIso (wrong) vs date-fns/parseISO (correct) was breaking. The funny thing is that: (:require ["date-fns/parseIso" :as parseIso]) was returning something (an empty js object), which then broke downstreams consumers.

@orestis that problem should be fixed in master

Super!

Does anyone have a quick example on how to generate a basic index.html using manifest.edn?

I added something basic recently that does that

well it doesn't generate html, but it can update html 😛

https://github.com/thheller/shadow-cljs/blob/master/src/main/shadow/html.clj

basically you create and basic html file you want

like this one https://github.com/thheller/shadow-cljs/blob/master/out/demo-browser/index.src.html

and in your build config

:build-hooks
   [(shadow.html/copy-file
      "out/demo-browser/index.src.html"
      "out/demo-browser/public/index.html")]

basically that'll replace the <script src="/js/base.js" defer></script> with <script src="/js/base.<hash>.js" defer></script>

generating the HTML is also very easy if you use something like hiccup

hmm

can I use shadow.html directly in shadow-cljs.edn?

> Could not locate shadow/html__init.class, shadow/html.clj or shadow/html.cljc on classpath.

it is rather new so you probably need to bump versions

bumped version, this time it ran, but I don't see the file

I see the build should've logged something if the source path was wrong

maybe the warning is only visible if you run with --verbose

ah, {:type :shadow.html/source-does-not-exist, :source "public/js/index.src.html", :shadow.build.log/level :info}

it should probably just throw instead 😛

but the file is there :thinking_face:

oh ffs

:man-facepalming:

this needs to be an actual file, not a classpath resource 😛

it's not in the js folder 😂

hehe

jeez

I think it's time to go home... thanks so much for shadow-cljs and your help 🙂

it worked now

Hi, I am trying to call a constructor for JS object from npm as follows:

(:require ["bezier-js" :as bezier])

(bezier/Bezier. x1 y1 x2 y2 x3 y3)

TypeError: module$node_modules$bezier_js$index.Bezier is not a constructor
    at orgpad$client$util$geom_link$create_quadratic_bezier_from_control_point (orgpad/client/util/geom_link.cljs:39:9)
    at eval (eval at shadow$cljs$devtools$client$browser$global_eval (/js/compiled/cljs-runtime/shadow.cljs.devtools.client.browser.js), <anonymous>:1:73)
    at eval (<anonymous>)
    at Object.shadow$cljs$devtools$client$browser$global_eval [as global_eval] (/js/compiled/cljs-runtime/shadow.cljs.devtools.client.browser.js:829:16)
    at eval (/js/compiled/cljs-runtime/shadow.cljs.devtools.client.browser.js:838:44)
    at Object.shadow$cljs$devtools$client$env$repl_call [as repl_call] (/js/compiled/cljs-runtime/shadow.cljs.devtools.client.env.js:145:108)
    at Object.shadow$cljs$devtools$client$browser$repl_invoke [as repl_invoke] (/js/compiled/cljs-runtime/shadow.cljs.devtools.client.browser.js:836:46)
    at shadow$cljs$devtools$client$browser$handle_message (/js/compiled/cljs-runtime/shadow.cljs.devtools.client.browser.js:921:37)
    at eval (/js/compiled/cljs-runtime/shadow.cljs.devtools.client.env.js:294:151)
    at Object.shadow$cljs$devtools$client$env$process_next_BANG_ [as process_next_BANG_] (/js/compiled/cljs-runtime/shadow.cljs.devtools.client.env.js:273:90)

I can access functions from that module, i.e.,

(.quadraticFromPoints bezier ...)

@pavel.klavik unfortunately, how to import foreign JS can often vary depending on how the JS is packaged

is there a way to use new in this situation?

you should (js/console.log bezier) to see what the exported object is

based on their docs, I would expect that you would use the bezier as the constructor but it’s hard to know for sure

@pavel.klavik pretty good chance it should be (bezier. x1 y1 x2 y2 x3 y3)

cool, it works

var Bezier = require('bezier-js')

translates to the above

I'm trying to use https://github.com/Pikaday/Pikaday. shadow-cljs fails the build with

The required JS dependency "moment" is not available, it was required by "node_modules/pikaday/pikaday.js".

Is there a way to tell shadow that I actually don't need a dependency? The error message seems to hint that shadow isn't sure: "You probably need to run:"

You probably need to run:
  npm install moment

try :js-options {:resolve {"moment" false}} in your build config

there is no "standard" for optional dependencies

so shadow-cljs can't tell

Oh gotcha. That'd be useful to have here: https://shadow-cljs.github.io/docs/UsersGuide.html#_missing_js_dependency.

That does fix it btw.

this pattern is rather uncommon

Sure. Still seems useful. Pretty widely known lib - 6.8k stars.

https://github.com/Pikaday/Pikaday#commonjs-module-support

the library seems rather old given that it uses browserify as an example