I’m a shadow-cljs beginner really, so I don’t have the answer, but do you know about shadow-cljs check? Maybe it helps, I would have liked to know about it earlier a few months ago 🙂

I have run shadow-cljs check and it gives me some warnings. Most warnings are in external library code, but none that seem like they would break only in a release

hmm no that is not currently overrideable

do you have :infer-externs :auto turned on? it is most likely related to missing externs and using property access for something https://shadow-cljs.github.io/docs/UsersGuide.html#infer-externs

Whew! That was a crazy issue. Ultimately it had little to do with shadow-cljs. We had an in-house JavaScript library called paradigm and when we did the original interop with lein we just had it provide the same namespace that the global object provided paradigm. However when I followed the technique described to convert CLJSJS packages things went wrong in a weird way when released. Somehow the code was optimizing in a way that js/paradigm was resolving to the cljs paradigm namespace rather than the paradigm that we exported globally. I have no clue why this was happening only on a release build but worked fine in dev. Changing the namespace to avoid clashing with the global object fixed it.

it should be https://github.com/firebase/firebase-js-sdk/blob/master/packages/firebase/app/index.ts#L19

but since I am using https://github.com/deg/re-frame-firebase, i think it is getting initialized twice (wrongly in release build)

when i debug, I can see it is just an object instead of the actual firebase object in the js code, but since this only happens in advanced optimization, i am not sure why it is happening

it is more important to know how YOU use it. in your code I mean

not the node_modules code

that re-frame lib for example is depending on a global variable

i use the re-frame-firebase library. I don't call firebase directly.

may be it is in conflict with the firebase I have in the package.json file. Let me try to remove the one in package.json and try again

no you need it in package.json

as far as I can tell this should be working or not at all (so also not in dev)

https://github.com/thheller/shadow-cljsjs/blob/master/src/main/firebase/app.cljs

you are basically relying on this "shim" to create the global js/firebase that library uses

I'm gonna take a wild guess and say that it is expecting an older version

and you probably just have a newer version isntalled

[cljsjs/firebase "5.7.3-1"]

check which version you have under cat node_modules/@firebase/app/package.json

i do have newer version 🙂

you might be able to copy this file to your src directory

https://github.com/thheller/shadow-cljsjs/blob/master/src/main/firebase/app.cljs

thank you for the pointers. I will check more. I am surprised that it works with shadow normal build

and change it to

(ns 
  (:require ["@firebase/app" :default firebase])

yes that surprises me too

which version do you have? I want to test something

"name": "@firebase/app",
  "version": "0.4.11",
...

that is from your command

this is from my pagckage.json: "firebase": "^6.3.1",

i think 6.3.1 is the general version and 0.4.11 is the "app" module version

hmm yeah makes sense

I am very new to front end development so still confused with alot of things 🙂

welcome to the madness that is JS 😉

haha

oh before I forgot which build target do you use?

it is working fine for me in a :browser build

it is browser

I am 99% sure it is because of that reframe library

with multiple :modules maybe?

i only have one :modules {:main {:entries []}}

yeah I'm unsure why it would be working in dev but not release

you can try making a release build and then when loading it in the browser you can check via the console if there is a firebase variable

there should be

i can actually see it in the global variable

maybe try compiling with shadow-cljs release main --pseudo-names and debug it in the browser

should be some clue in there

I will try that.

@neupsh I've been trying to elucidate that exact behavior myself for the last three weeks. I also use re-frame-firebase

Similarly, I’ve traced it down to a double declaration of “var firebase” that in the re-frame-firebase initialization scope overloads the goog.exportSymbol’s firebase. I’ll try the above recommendations too and report back if that helps debug. Thank you.

In the "advanced optimized" js if i search for "firebase" I see two places where that var is assigned a value. One for global and one for local (in scope of that reframe lib node module init function).

The global one has correct value right after it is assigned, but the local scoped one is initialized as an empty object and then for each modules (sub modules?) they are added as properties of the "firebase" local object. Now, this object may have those submodules, but it does not have the "initializeApp()" method as it is never added to that object.

yes, in the debugger, at the point firebase.initializeApp is called, firebase is a nearly empty object, with properties (this is from my recent memory, so may be missing things)

{auth: {}, database: {}, firestore: {}} which is also initialized in that containing scope by a similar assignment to the var firebase = {app: {}} (I’m using :simple optimizations, so the app: {} nor other empties are being optimized out, forgot to mention that)

immediately prior to use of say firestore, there’s a dummy dec’l firebase.firestore = {}

BTW, did you get --pseudo-names to do anything useful, I’m on the horns of that now, with a … TypeError : $s$$.substring is not a function

seems to be on the second call leading up to that form

Separately, I have a minimal app that exhibits this “firebase.initializeApp not a function” behavior that I can share

@U20AW42V7 I have not got around to try that yet 🙂 I only get to play with clojure(script) off work.

Tried to spend some time without any progress.. I will continue tomorrow. Lets get to the bottom of this 🙂

@U20AW42V7 please share the repo if you can. happy to dig into that

@thheller I’m in the middle of cleaning it up right now, thank you. Last minute npm wrestling.

https://github.com/benzenwen/re-frame-firebase-shadow-cljs-interaction-test/tree/master

thanks. I'll take a look

Apologies for letting /semantic sneak in there! Thank you for shadow-cljs. Am going to turn in for the evening.

one last thing, I have a fork of shadow-cljsjs and/or re-frame-firebase that seems to supress the :dev build warning:

‘‘’ Warning: Firebase is already defined in the global scope. Please make sure Firebase library is only loaded once. shadow$provide.module$node_modules$$firebase$app$dist$index_cjs @ index.cjs.js:484 shadow.js.jsRequire @ js.js:63 shadow.js.require @ js.js:97 (anonymous) @ firebase.app.js:3 ‘’'

I found the problem I think

oh, that’s encouraging

yeah problem is fixed in master. will make a release a bit later

OMG @thheller I could not thank you enough 🙂

@thheller Thank you, that is awesome! 🙏

fixed in 2.8.45

I can confirm it works now. Thank you very much @thheller

I have another issue with "styling" and layout on the advanced build (material-ui) but that may not be related to this issue. I will create another thread if needed one.

Thank you @neupsh for bringing up the issue. I thought I was going crazy. Was starting to dig through shadow-cljs codebase.