Hm, working on a :npm-module target, and requiring some JS files from cljs using (:require ["/abs-path-to-js" :as my-js]). Compiles, but when that js file is evaluated I get a ReferenceError: shadow$provide is not defined

toying around, I added a shadow$provide = {}, then see another error - the pattern in these re-emitted js files is

shadow$provide.module$foo = function() {...}
module.exports = module$foo

the js file should be ES6+. commonjs doesn't work

ie. import/export not module.exports/require

ah

I’m getting some weird errors working with js files that depend on other js files https://gist.github.com/mhuebert/6898da15723a26da485a984bc3249022

one example fails at runtime, referencing a variable that isn’t defined except in the other js file. identity$$module$ftest$util instead of module$ftest$util.identity

the other one fails at compile time:

import * as util from './util'
export const IDENTITY = (x) => util.identity(x)

made an issue https://github.com/thheller/shadow-cljs/issues/521

hmm yeah the problem there is the :npm-module target

the direct JS support sort of only works in the browser since it sort of relies on having a shared global scope

not sure about the closure compiler error though

it might work with a newer closure compiler version

hm ok. So using (js/require "..") would be more reliable

yeah. I'm thinking about adding an option that skips the shadow-cljs transpilation of the JS files

and just copies them to the output-dir as is

so node can do the require stuff

for what I am trying to do, I think that would be ideal

I am trying to avoid an extra transpile step, the env I’m deploying to doesn’t support import/export

but that requires a bit of work so for now I'd stick with js/require probably

k. how do relative paths work with js/require in shadow?

all files are in the :output-dir so whatever you require must be relative to that

that’s simple