It looks like Set is only supported in IE11 and above

You might need a polyfill. I don't think CLJS depends on it; are you using any npm libs that might need it?

i definitely could be. appreciate your input, thats really helpful.

I think it’s react; https://github.com/facebook/react/issues/11429#issuecomment-342148046

what's the recommended way of integrating shadow-cljs into an existing clojure+deps.edn project?

If I add a shadow-cljs.edn file in the project root and use :deps true does this mean the clj and cljs sides are sharing the same dependencies?

@qythium depends on how you want to integrate everything

you could create a :cljs alias or so in deps.edn or you could just keep CLJS deps in shadow-cljs.edn

the recommended workflow is to just keep things separate

CLJS doesn't gain anything by being integrated into a CLJ project

you can however just integrate it like any other library

keeping it separate sounds good, so that means I'll have to have 2 JVM processes running in development? One for my existing clj project and the other running Shadow and the cljs repl

yeah thats what I do typically

most people seem to opt for the embedded version however so you only have one JVM running

https://shadow-cljs.github.io/docs/UsersGuide.html#embedded

but that often means fighting with dependencies a bit more

:deps {:aliases [:cljs]} and a :cljs alias in deps.edn is OK if you want to keep all dependencies in one place

https://shadow-cljs.github.io/docs/UsersGuide.html#deps-edn

its fine to embed really, you don't lose any features. just can get a bit annoying when fighting dependency conflicts

ah, so that's what happens when I "connect-clj&cljs" in Cider?

does not embedding mean having 2 separate nREPL ports to connect to?

yes

if you use emacs it is probably best to go with the embedded route

in Cursive it sort of doesn't matter since it doesn't rely on nrepl as mcuh

got it, thanks! I'll try it both ways and see :)

Looks like there's some sort of dependency issue with the [dali "0.7.4"] library, including it in the dependencies causes the error

Exception in thread "main" java.lang.NoClassDefFoundError: org/w3c/dom/ls/DocumentLS
 at java.base/java.lang.ClassLoader.defineClass1(Native Method)
 at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1016)
 at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:151)
 at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:802)
 at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:700)
 at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:623)
 at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
 at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
 at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
 at org.apache.xerces.jaxp.DocumentBuilderImpl.<init>(Unknown Source)
 at org.apache.xerces.jaxp.DocumentBuilderFactoryImpl.newDocumentBuilder(Unknown Source)
 at shadow.build.classpath$pom_info_for_jar.invokeStatic(classpath.clj:355)
 at shadow.build.classpath$pom_info_for_jar.invoke(classpath.clj:346)
 at shadow.build.classpath$find_jar_resources_STAR_.invokeStatic(classpath.clj:439)
 at shadow.build.classpath$find_jar_resources_STAR_.invoke(classpath.clj:427)
 at shadow.build.classpath$find_jar_resources.invokeStatic(classpath.clj:554)
 at shadow.build.classpath$find_jar_resources.invoke(classpath.clj:528)
 at shadow.build.classpath$find_resources.invokeStatic(classpath.clj:608)
 at shadow.build.classpath$find_resources.invoke(classpath.clj:600)
 at shadow.build.classpath$index_path_STAR_.invokeStatic(classpath.clj:839)
 at shadow.build.classpath$index_path_STAR_.invoke(classpath.clj:836)
 at clojure.lang.PersistentVector.reduce(PersistentVector.java:343)
....

any idea how I should go about resolving this?

hmm odd. might be https://clojure.atlassian.net/projects/TDEPS/issues/TDEPS-130

https://github.com/stathissideris/dali/blob/master/project.clj#L15

oh, so I have to manually add those excluded deps?

dunno

trying that out now-

might fix it but I'm not sure which package that class is from

that was it, adding xerces/xercesImpl {:mvn/version "2.12.0"} to the deps list fixed the startup - although I haven't tried using the library

I don't think it's specifically a tools.deps issue though, created an empty shadow-cljs project with only a single dependency on dali and the error still came up

Hello, I’m trying to move a figwheel project to shadow and I’m seeing this error around requiring macros

Error in phase :compile-syntax-check
FileNotFoundException: Could not locate clojure/core/match__init.class, clojure/core/match.clj or clojure/core/match.cljc on classpath.

core.match not on the classpath?

I can’t seem to match my ns correctly for my repl, I’m trying to call a (start) fn which is in my source paths, but I’m unable to resolve the symbol

{:source-paths ["dev/server" "src/client"]
 :deps   {:aliases [:dev]}
 :nrepl  {:port 9000}
 :builds {:main {:target     :browser
                 :output-dir "resources/public/generated/js/dev"
                 :asset-path "/generated/js/dev"

                 :modules {:main {:entries [admin.core]}}

                 :devtools {:http-port  3000
                            :preloads   [devtools.preload
                                         fulcro.inspect.preload]}}}}

how are you trying to call it?