I'm hitting an error with shadow-cljs release and I'm not sure what is causing it. shadow-cljs watch still works fine.

@bbss since you are using lein I'd suspect a bad closure-compiler version?

okay, sounds reasonable, how can I specify?

first check via lein with-profiles +cljs deps :tree

should be

[com.google.javascript/closure-compiler-unshaded "v20190325"]
   [org.clojure/google-closure-library "0.0-20190213-2033d5d9"]

[thheller/shadow-cljs "2.8.36"]
   [com.bhauman/cljs-test-display "0.1.1"]
   [com.cognitect/transit-clj "0.8.313"]
   [com.cognitect/transit-cljs "0.8.256"]
   [com.google.javascript/closure-compiler-unshaded "v20190325"]
   [com.wsscode/pathom "2.2.7" :exclusions [[org.clojure/data.json] [fulcrologic/fulcro] [camel-snake-kebab]]]
     [com.wsscode/spec-inspec "1.0.0-alpha2"]
     [edn-query-language/eql "0.0.3"]

might be here, my shadow-cljs version is older than cli I'm using

that looks like it should

[thheller/shadow-cljs "2.8.36"] -> [org.clojure/google-closure-library "0.0-20190213-2033d5d9"] -> [org.clojure/google-closure-library-third-party "0.0-20190213-2033d5d9"]

what is your :modules config? the exception looks like something isn't quite right with the modules

:main     {:target     :browser
                     :output-dir "resources/public/js/main"
                     :asset-path "/js/main"
                     :build-hooks [(gsv.api.mutations/recalc)]
                     :modules    {:shared {:entries []}
                                  :web-shared {:entries []
                                               :depends-on #{:shared}}
                                  :worker-shared {:entries []
                                                  :depends-on #{:shared}}
                                  :app {:entries [gsv.client]
                                        :depends-on #{:web-shared}}

                                  :fetch-worker {:entries [gsv.fetch-worker]
                                                 :depends-on #{:worker-shared}
                                                 :web-worker true}
                                  :filter-worker {:entries [gsv.filter-worker]
                                                  :depends-on #{:worker-shared}
                                                  :web-worker true}}

hmm that looks ok

the exception looks like the compiler pass responsible for moving keywords

can't find a common module to place a keyword in

but in your case it should be always finding :shared at the very least

hmm, any type of change I did that could have brought this about?

https://github.com/thheller/shadow-cljs/blob/de065f237031f2e8233642c96b0030477ce2be30/src/main/shadow/build/closure/ReplaceCLJSConstants.java#L52

not a clue. the error looks like targetModule is null which shouldn't really happen

/**
   * Finds the deepest common dependency of two modules, including the
   * modules themselves.
   *
   * @param m1 A module in this graph
   * @param m2 A module in this graph
   * @return The deepest common dep of {@code m1} and {@code m2}, or null if
   *     they have no common dependencies
   */
  public JSModule getDeepestCommonDependencyInclusive(

so it should only return null if there is no common module

but it should always be at least shared

try adding an explicit :shared dependeny to all :modules maybe?

maybe something isn't right with transitive deps?

eg. :app {:entries [gsv.client] :depends-on #{:web-shared :shared}}

Trying that.

just adding it to :app wasn't enough but adding that to the other worker modules seems to have done the trick! Thanks @thheller!

hmm strange

would have expected the logic the account for transitive deps but I guess it doesn't

oh wait

maybe I ran it in the wrong window.. 😕

give me a moment

no, that does seem to be the case 🙂

Hi all 👋 Is there something I'm missing here? I have my code under src/ and tests under test/ and I added them both to source-paths but yarn shadow-cljs compile test just doesn't find the test namespace under test/. All seems to work fine and the test namespace is found when I move the test namespace under src. Here's my shadow-cljs.edn:

;; shadow-cljs configuration
{:source-paths ["src" "test"]

 :deps true

 :builds
 {:flex-cli {:target :node-script
             :output-to "target/main.js"
             :main sharetribe.flex-cli.core/main}
  :test {:target    :node-test
         :output-to "target/tests.js"
         :autorun   true}}}

➜  flex-cli git:(master) ✗ yarn shadow-cljs compile test
yarn run v1.9.4
warning package.json: No license field
$ /Users/mikko/Documents/Projects/sharetribe/flex-cli/node_modules/.bin/shadow-cljs compile test
shadow-cljs - config: /Users/mikko/Documents/Projects/sharetribe/flex-cli/shadow-cljs.edn  cli version: 2.8.37  node: v10.11.0
shadow-cljs - starting via "clojure"
[:test] Compiling ...
========= Running Tests =======================

Ran 0 tests containing 0 assertions.
0 failures, 0 errors.
===============================================
[:test] Build completed. (27 files, 1 compiled, 0 warnings, 1,63s)
✨  Done in 10.35s.

(ns sharetribe.flex-cli.hello-world-test
  (:require [cljs.test :refer-macros [deftest is]]))

(deftest failing
  (is (= "hello" "world")))

if you set :deps true the :source-paths from shadow-cljs.edn do not apply and only use the ones defined in deps.edn

Yeps, that seems to be the case and makes totally sense now