@d4hines you could also use (gobj/set (.getElementById js/document "fps") "innerHtml" (str "<p>" n "<p>"))

gobj => goog.object

@lilactown @wilkerlucio can you confirm that .shadow-cljs is a git ignored directory in your projects? just a guess but maybe git messes with the .shadow-cljs dir when switching branches? probably not but who knows 😛

@thheller yup, its confirmed, and in my case I wasn't switching branches, just the shadow-cljs version

hello @thheller, I’m sorry to bother you again but my js file importing adventure is not finished yet

now it seems that everything works if I call functions from the js file that do not depends on imported modules

but when I use a more complex function with external dependencies the compiler complains like in this case:

node target/main.js SHADOW import error /Users/arusso/Development/clojurescript/ask-scopus/.shadow-cljs/builds/app/dev/out/cljs-runtime/server.google_sheet.js /Users/arusso/Development/clojurescript/ask-scopus/.shadow-cljs/builds/app/dev/out/cljs-runtime/server/oauth2.js:17 fs.readFile(‘credentials.json’, (err, content) => { ^ TypeError: fs.readFile is not a function at Object.readFile [as auth_init] (/Users/arusso/Development/clojurescript/ask-scopus/.shadow-cljs/builds/app/dev/out/cljs-runtime/server/oauth2.js:17:5) at /Users/arusso/Development/clojurescript/ask-scopus/.shadow-cljs/builds/app/dev/out/cljs-runtime/server/google_sheet.cljs:8:1 at global.SHADOW_IMPORT (/Users/arusso/Development/clojurescript/ask-scopus/target/main.js:64:44) at /Users/arusso/Development/clojurescript/ask-scopus/target/main.js:2195:1 at Object.<anonymous> (/Users/arusso/Development/clojurescript/ask-scopus/target/main.js:2199:3) at Module._compile (internal/modules/cjs/loader.js:805:30)

obviously I have the const fs = require(‘fs’); in the js file

and the [“./oauth2” :as auth] in the clojurescript namespace. In fact an dependency-free hello-world function from the js file is correctly imported and called from the CLJS namespace.

@rastandy and what is console.log(fs) in the oauth2.js file?

@thheller well, it’s {}

but if I call “node src/oauth2.js” it works

that doesn't mean anything

the commonjs support is sketchy

@thheller I mean that the import is correct in the js file

@thheller so you suggested me to use another module system?

yes but that is irrelevant. shadow-cljs just fails to rewrite the require properly

@thheller ok

ESM support should be a bit better yes

I can see about the commonjs require later, busy with other stuff currently

@thheller can you point me to some docs to convert my js file to ESM and import it correctly in CLJS? Sorry I’m pretty ignorant in JavaScript modules land

just plain ESM, nothing special regarding CLJS

and no I don't have a guide handy.

@thheller I can only thank you for your help and support, thank you very much!

@thheller I’ll find one, many thanks

@thheller great! Converting in ESM module everything works! Many, many thanks.

hello, I am struggling with shadow-cljs and hope you could help me (or point me somewhere), is there any way to run browsers tests (or karma test) in watch mode? (to be more explicit, re-run affected tests only whenever something changes in the code/tests)

thats what :browser-test does?

https://shadow-cljs.github.io/docs/UsersGuide.html#target-browser-test

well, actually yes. I am really sorry for the stupid question but your answer really helped me, thanks 🙂

random question: does shadow-cljs send the form that was evaluated to the browser when you evaluate at the REPL?

I think the source is included, not the form

> source is included, not the form What does that mean? Aren’t they equivalent?

"(foo)" vs (foo) (an actual list with foo symbol)

Oh, gotcha. So source = string, form = data.

I'm converting a figwheel-based project to shadow-cljs and finding that compilation w/ shadow-cljs fails on reagent's with-let macro, complaining that the vars referenced in the output of that macro are undeclared. Any possible causes come to mind?

ancient version of reagent?

0.8.1, I think that's the latest stable (checking now...)

yeah that's the latest

that should be fine I think

https://github.com/reagent-project/reagent/issues/420

maybe its not released yet?

with-let has been in reagent for several releases now - it seems to me that the macro is evaluating just fine but the code it's outputting includes references to vars shadow-cljs doesn't know about for whatever reason. I'm also seeing warnings about "provide conflicts" due to re-frame and some others putting compiled assets in their jars - think it's possible that's related?

yeah thats probably not helping

what kind of warnings do you get?

Pretty sure it's the same situation you talked about here: https://github.com/thheller/shadow-cljs/issues/473, ignoring the stuff about that person's macros + ns problems.

Actually, some of the complaints are about goog libs, so maybe I have something else going on. For example: [2019-04-10 14:30:26.531 - WARNING] provide conflict for #{goog.labs.userAgent.engine} provided by goog/labs/useragent/engine.js and {"/out/goog/labs/useragent/engine.js" #{goog.labs.userAgent.engine}}

yeah if compiled code is on the classpath that causes issues

things in public/* are already filtered

do you also have out/*?

I do not have an out, just target, which I've been rm -rfing after the failed builds to make a clean slate. There are other possible complications w/ my build setup. I'm using lein for my deps + source-paths because some of my deps are stored in a private s3 bucket. My shadow-cljs config file is pretty simple though: {:lein {:profile "+dev-client"} :builds {:app {:output-dir "target/admin/client/public/js/compiled/" :asset-path "/" :target :browser :modules {:main {:entries [kc.admin.user]}} }}}

...

I mean in the error messge

I need to know your actual errors to help. not errors someone else had.

> [2019-04-10 14:30:26.531 - WARNING] provide conflict for #{goog.labs.userAgent.engine} provided by goog/labs/useragent/engine.js and {"/out/goog/labs/useragent/engine.js" #{goog.labs.userAgent.engine}}

this means there was an "unexpected" source file in /out/goog/labs/useragent/engine.js on the classpath, which can be in a jar. doesn't need to be one of YOUR paths

Ok, I will look for something on the classpath containing the offending files. Thanks for the help.

run shadow-cljs clj-repl then ( "the/path/it-reports-in-the-error")

that'll tell you where its coming from (might need to strip the leading /)

Yeah, that did it, thanks. Turns out the culprit was that same re-frame-utils lib from that issue. I didn't even realize it was in my project.clj. 🙃

I see the manual has a "what to do when things don't work" section that basically just says "ask on slack". Would you be interested in a PR describing this issue and its resolution in that section?

I'd rather make the classpath filter smarter so people don't run into it anymore 😉

https://github.com/thheller/shadow-cljs/issues/477

:thumbsup:

Thanks again