any advice

is there a way to write portable libraries that include plain js files? I'm asking because by cljs standards they say to use :foreign-libs (https://github.com/clojure/clojurescript-site/blob/master/content/reference/packaging-foreign-deps.adoc), but shadow on the other side can import js files directly, but no :foreign-libs, I'm working in the Workspaces project and I have a dependency on a simple js file, is there a way to write it so users of the library get correct behavior with both standard cljs and shadow?

@dspiteself looks like you are using a browser build in a non browser environment? something that doesn't have access to document

@wilkerlucio the support for JS files in standard CLJS is absolutely terrible. they can't talk to CLJS code or import other code themselves

but if you don't need that you can emulate the inclusion just like cljsjs

hmm maybe not actually. I'm not sure if :foreign-libs are used before the classpath or after

@thheller so the best option seems to be create a npm package a cljsjs package and a shadow-cljsjs to get it compatible?

I'm not sure to be honest. what kind of JS file do you have?

@thheller this is the file in question, its a fuzzy search algorithm: https://gist.github.com/wilkerlucio/221cda4bc18184ea827cbf1e545aa4a2

I even started trying to convert, but its a very stateful procedural algorithm, that's actually better as is then trying to port it to functional I think

Yea I am targeting a serviceworker which is like a webworker. https://developers.google.com/web/fundamentals/primers/service-workers/ It does not have document. It uses self.importScripts()

It seems like it would need to be a different target

@dspiteself try setting :modules {:main {... :web-worker true}}}

@wilkerlucio I don't even know how you'd use that file with standard CLJS? did you get that working already?

if I want to target a single compiler (regular cljs OR shadow) its easy

using the foreign libs thing

the foreign lib give it a name, you require and use globals (as described here: https://github.com/clojure/clojurescript-site/blob/master/content/reference/packaging-foreign-deps.adoc)

@thheller the problem is making something that works in both cases, I can't find a way to make those compatible

how do you actually use that file with CLJS though?

I mean how do you require it and access the code?

you add something like this to deps.cljs:

{:foreign-libs
  [{:file "react/react.js"
    :file-min "react/react.min.js"
    :provides ["com.facebook.React"]}]
 :externs ["react/externs.js"]}

then you required the name said in the :provides, so, in this case: (:require [com.facebook.React])

then the code is just injected

and the file is expected to set globals, so very much like adding a new <script> tag, but goes in the same bundle

yeah thats what I mean

the file doesn't export any globals so you rewrite the file to make it work with CLJS?

yeah, I would do that

in this case is just 3 functions that are terrible to write in cljs 😛

can't think of anything besides the usual cljsjs and shadow-cljsjs trick

it sucks so bad, for such a small thing -.-

I'm not sure if you maybe can write it in Closure JS and just import it directly

shadow-cljs understands that but I'm not sure if CLJS does

ie. you add a goog.provide("some.ns.fuzzy") some.ns.fuzzy.fn = function ...

it might work

yeah I think that should work

transit-cljs is importing transit-js that way

https://github.com/cognitect/transit-js/blob/master/src/com/cognitect/transit.js

probably don't need the goog.scope stuff for your file since its so short

interesting, so if I make it like a google closure module I can import it directly in regular cljs?

I'd suggest using the "older" model the closure lib uses

but yes you can import those directly

https://github.com/google/closure-library/blob/master/closure/goog/string/string.js

just one goog.provide("some.ns")

and then everything prefixed with some.ns.foo = function() ...

or the way transit does it with goog.scope if you want local vars

cool, I'll try the first

@thheller this works, awesome! thanks for saving me on this one 🙂

a new workspaces version will be out soon, I think you might like it, some fixes and improvements, including a better spotlight (using the new fuzzy search)

sweet. I need to get back actually coding a bit .. too busy with other stuff the past few weeks

$ shadow-cljs server
shadow-cljs - config: /home/souenzzo/src/my-next-stack/shadow-cljs.edn  cli version: 2.7.6  node: v11.2.0
shadow-cljs - running: lein with-profile client,webdev run -m shadow.cljs.devtools.cli --npm server
Executable '' not found on system path.

indeed. the error message is wrong

but it is looking for lein

is lein found via which lein?

yep. already installed lein. Just reporting the wrong error message

thx. just fixed it.

http-root in devtools can be a array?

no only one dir

ok

could add support for multiple if you need

With figwheel, I use output-dir on target/public/js/out then serve target/public and resources/public (my index.html is on resources/public/index.html )

you can set :http-resource-root "public"

(in addition to :http-root)

What is the difference between http-resource-root and http-root ???

resources are served from the classpath

http-root from the filesystem

(this assumes that resources is on the classpath, which is is by default in lein but not shadow-cljs.edn)

It's already working nice 🙂

when I try to start shadow from repl I get

(shadow/watch :main :cards)
Execution error (ExceptionInfo) at shadow.cljs.devtools.server.runtime/get-instance! (runtime.clj:11).
missing instance

the server needs to be running when you run in embedded mode

https://shadow-cljs.github.io/docs/UsersGuide.html#embedded

the server/start!

and (shadow/watch :main) (shadow/watch :cards)

it only takes one build arg from the REPL

In shadow-cljs how I handle things like [fulcrologic/fulcro "2.6.15" :exclusions [cljsjs/react]] ?? Should I exclude in project.clj and just add in package.json?