I'm using shadow in "npm" mode. I'm trying to use devcards for both reagent and "raw" react components

@souenzzo it is intended that you use all your source-paths all the time. a build only includes whatever is required. https://code.thheller.com/blog/shadow-cljs/2018/02/08/problem-solved-source-paths.html

namespaces already provide enough separation. no need to do it at the source-path level

hmm, I am working on bringing maria.cloud up to the latest shadow-cljs version (it was on 2.2.x). I found that something changed in 2.3.9 which causes ReferenceError: goog is not defined errors when loading cljs.core macros (`/js/compiled/bootstrap/js/e9a22ddf.cljs.core$macros.js`), the stacktrace points to the first line, goog.provide('cljs.core$macros');. Not a lot changed between 2.3.8 and 2.3.9, https://github.com/thheller/shadow-cljs/compare/2.3.8...2.3.9

hmm, it doesn’t look like the code in the 2.3.8 jar matches the code with the 2.3.8 tag on github

so i think at least the changes from 2.3.7 (on github) also are included in the cause

@mhuebert the :output-wrapper default changed so that may be causing the issues

try setting :compiler-options {:output-wrapper false}

I did try that — unfortunately didn’t help

and you are still using :simple for the host build?

yes

did you set the output-wrapper for the host build?

it will have no effect on the bootstrap build

goog is not defined is probably cause by the output-wrapper

since that prevents creating global variables which the bootstrap stuff relies on

k let me try that again

so does the output-wrapper stuff mean that there wouldn’t ever be name collisions from advanced builds with other random global variables?

yes

well not "ever" but they are certainly reduced by a bunch

its basically just a function wrapped arround the code so it has its own scope instead of global

in my last project i had these super weird bugs from advanced builds accidentally “discovering” other short global names from old js libraries that i was also using. i ended up generating a list of externs from all the objects defined on “window”

yeah it should prevent that kind of issues

ok, so this is good news. I clearly did not put :output-wrapper stuff in the right place before. can successfully compile maria with latest version of shadow