is it possible to call (shadow/nrepl-select :app) from a different nrepl that’s running from the same app? or do you have to use the shadow nrepl to call that? can the shadow nrepl replace clojure.tools.nrepl ?

do you mean a different nrepl server?

you'll need to add the middelware to that server https://shadow-cljs.github.io/docs/UsersGuide.html#_embedded_nrepl_server

okay, and then do i still call nrepl-select ?

yes

okay thank you

did shadow-cljs offer any way of bundling a jar? Recommend using leiningen for that?

not yet, leiningen recommended yes.

you can use something like this https://github.com/juxt/pack.alpha

you’d need a deps.edn file though

wow nice!

thanks @biscuitpants

i haven’t used it in prod yet though 🙂

I love riding on rough paths, live on the edge 😛

btw, a proof that audioworklet and wasm can be compiled with shadow-cljs https://jsfiddle.net/4o3q5tu7/1/ (just showoff)

this is very cool

is there a way to specify dependecies for dev and for prod with shadow-cljs?

based on https://github.com/Day8/re-frame-debux#installation

but https://github.com/jacekschae/conduit/blob/master/shadow-cljs.edn#L12 I can see both bundled together

@urbanslug no that is not supported currently. you can do it via :lein or :deps if you need to

:deps?

https://clojure.org/reference/deps_and_cli

https://shadow-cljs.github.io/docs/UsersGuide.html#deps-edn

thanks 🙂

Is it possible, or has it been thought trough and considered not worth it. To publish jar with cljs resources and bundle with it the shadow-cljs.edn file, which when consumed by other shadow-cljs app. Will inherit the npm dependencies, :resolve and :hooks (or make it configureable which to inherit and what not)?

This seems to part of another endless discussion of npm deps in cljs. But yeh, totally annoying. tools.deps supporting :npm-deps would be nice. It almost doesn't happen anymore that someone makes a library in clojurescript.

@hlolli I had a look at pack as well for the same reason and I am thinking of adding an Azure pack target for my use case: https://github.com/juxt/pack.alpha/issues/18

but it would definetly convenient to have everything in one tool...

@richiardiandrea yes looks like this is very special usecase. Maybe it's not such a big problem of packageing the stuff we need, generate .pom etc. But what the build tools do with it. I'd like more radical integration with javascript. As for the hooks, js already has install, preinstall and postinstall. We have 4 tools to build clj/s (lein/boot/shadow-cljs/clj), and none can do it. If you ask me, the minification that webpack does is pretty radical and has gotten way better. Clojurescript isn't an island, but almost.

Don't know why I added the webpack comment there 🙂 but it's easy not to use any optimization, at least in shadow-cljs, which I love.

Anyway, to end my rant, which only in a good tone and with great love of cljs. Then imagine, publishing a cljs library running on nodejs "by the book". Then the recommended way is bundling all the dependencies in a consumeable form, makeing a jar, stuffing in the js, and declare foreign libs. With that, generate extern. Now imagine 100 modules in the node_modules for like 5 npm deps. Wiriting extern for each and one of them. Then ok, if successful, upload them to cljsjs, create PR and wait, so that at the end of it you can tell your friend, "hey check out my new library with this oneliner". End of rant 🙂

yeah not ideal

@hlolli it has been considered but ruled "not desirable". a library should never be specific to one tool, its one of the worst aspects of some npm deps and not something I want to introduce to CLJS. its already kind of bad that CLJS can't easily consume most npm deps like shadow-cljs but I do hope that they'll catch up eventually.

custom :resolve hooks are really a last resort option and should be used very rarely

:npm-deps you can declare in deps.cljs which shadow-cljs supports and will install on startup. CLJS will to when configured to do so.

js install/postinstall/preinstall hooks are the worst idea ever IMHO

there is also the fundamental difference in how cljs and closure view the world vs webpack. closure wants to optimize your whole program, webpack optimizes file by file and only recently gained some cross-file stuff

so publishing CLJS libs to npm for use by JS is probably never going to be easy

webpack minification is laughable compared to what closure does. it is getting better but is nowhere near closure :advanced

I can start ranting about all the bad things in npm for hours but I'd rather not 😉

happy to look over whichever problem you are running into though

you seem to have deleted another related message. at least I got an email notification but can't find the message here 😉

hehe yup, I deleted it, it was about being stuck between :es5 and :es6 when I using cljsbuild. If I uesed :es5 then I got errors about const and whole lots of features not being supported. When I used :es6, I started to get require calls adding .default and some of the node modules. Basically I'm working on packaging cljs app so that, hopefully, everyone can consume it on any build tool. But :npm-deps in deps.cljs, I had no idea that was possible. That may actually be exactly what I need. Thanks for pointing that out!

yeah the .default issue is a bit annoying. its the closure compiler doing that and unfortunately breaks many npm packages. and its a wontfix 😞 https://github.com/google/closure-compiler/issues/2971

Chad Killingsworth seem to have encountered this himself and made some changes. Maybe I try them out.

the problem was with .default, is that it was a module that I wasn't event require-ing directly, but a nested require

the change should be available in the closure compiler version used by shadow-cljs

but it doesn't matter. it only fixed an unrelated issue

it was in lein, but yup, I am leaving it behind for now and concentrating on tools.dep.

tools.deps isn't any different than lein when it comes to what CLJS does

but whats the actual problem you are trying to solve?

ah sorry, the actual problem was running tests.

But I guess that they need to run in lein too... so I won't leave it behind. My brain is bit drained.

if this is a nofix, then I just publish this stuff I have and write big red letters, use shadow-cljs. This is happening in the module "safe-buffer", which some module I'm requireing, is requireing, is requireing a built-in module "buffer"

var buffer = require('buffer')

module$buffer.default

closure probably didn't understand the buffer package

but yeah .. actually using :npm-deps in CLJS is rather unreliable still

buffer is also usually a built-in node package so it requires the node-libs-browser shims that webpack also uses

dunno if you have those installed

https://github.com/webpack/node-libs-browser

I'm in this case only targeting node, I have seperate namespace for the browser, which I don't think this package will get required

I would assume that, built-in modules would just get hard-coded into the closure compiler.

hmm if you are only building for node that closure shouldn't rewrite any code at all?

are you maybe not setting :target :nodejs or so?

and no closure has no predefined handling for built-in node packages at all

yes ahh, but I have :simple I "meant" that for .cljs sources

it doesn't matter

this is what I'm working with now

https://pastebin.com/sS89zmQU

in shadow-cljs when compiling for node the (:require ["whatever" :as x]) just generates a require("whatever") call

the code rewriting stuff only applies for browser builds since they can't use require

node builds for CLJS also emit require

so it should never get to the situation where require("buffer") is turned into module$buffer at all

I honestly have no idea about that config, may need to ask someone else

ok, yes, I wish closure would not change anything inside node_modules

it shouldn't when building for node

but I think :npm-deps confuses it

try setting :npm-deps false and see if that works

ok

ah ok I get it! now what's happening it that I just add the npm modules to foreign-libs, which is good, because I can set :module-type for each and every dependency.

hmm?

you don't add npm modules to :foreign-libs ever. they won't work.

for example, when compiling, I get

Caused by: clojure.lang.ExceptionInfo: No such namespace: web-audio-api, could not locate web_audio_api.cljs, web_audio_api.cljc, or JavaScript source providing "web-audio-api"

does node_modules/web-audio-api exist?

yes and if I add

{:file        "node_modules/web-audio-api/index.js"
:provides    ["web-audio-api"]
:module-type :commonjs}

but your code won't run at all

thats not what foreign-libs are for

you want the CLJS compiler to emit require("web-audio-api"). that is all. nothing else.

I don't know what setting you need to set to get it to do that

ask someone that does before continuing. you are on the completely wrong path when trying to use :foreign-libs to solve this.

ok just commented :npm-deps false then it compiles, just again ReferenceError: module$buffer is not defined

they are not suitable for this at all. :foreign-libs are prepended to the compiled code as-is!

hehe I maybe ask at another channel. And want to add that this is no "problem" for me, it's only an extra cool point that more people could use my code. Most likely, 1-2 peeps max will 🙂

I honestly can't figure out how to make it emit require

I know that it can do so but no idea how

before asking, I'll try this with vanilla closure in js...

just for sanity

closure got nothing to do with this

thats the point. closure should not be involved at all.

the CLJS compiler should emit require and let node figure it out

you don't think it could be connected with :language-in :es6 ?

Hello, I've just started using shadow-cljs for my ClojureScript development. My configuration file looks so:

{ :source-paths ["src/clj" "src/cljc" "src/cljs"]
 :dependencies [[reagent "0.8.1"]]
 :builds {:app {:target :browser
                :output-dir "resources/public/js"
                :asset-path "/js"
                :modules {:main {:entries [my-ns.main]}}}}}

(ns my-ns.main
  (:require [reagent.core :as r]))

@hlolli no.

@raf use three quotes for multi line code. your config looks fine and should work. are you sure you started shadow-cljs after adding the dependency?

if you have an old instance running that won't have the dep and won't find it

@thheller I use such command in the shell:

lein run -m shadow.cljs.devtools.cli compile app

well if you use lein to run the command you need to add the dependency to project.clj

or run shadow-cljs compile app

ah, clear. Somehow I thought lein is just throttling it to the shadow-cljs cli

then I've install npm package with shadow-cljs

:source-paths and :dependencies in shadow-cljs.edn don't matter if you use lein

as lein will only use project.clj

@thheller clear - I thought that only puting :lein option in the shadow-cljs.edn makes that lein deps are used

generally yes but only if you actually use the shadow-cljs command itself and not lein

now everything is clear. Thank you very much for help! I appreciate this! You've saved me a lot of time 🙂

@thheller now when I think about this, this ofc makes sens

@thheller thank you. Have a good night

@thheller just wanted to let you know, that now everything works, I was able to compile and run code

I think the problem is @cljs-oss/module-deps": "^1.1.1"

you are still doing it wrong it that is used at all

but yeah maybe just having it installed messes with things

I get Error: Cannot find module '@cljs-oss/module-deps' don't know who's asking for this then Error: Could not locate the bindings file. Tried:... for node-speaker

not a clue whats happening. I'm off to bed. gn8

ok, gn8, thanks again for all your help!

What is the best way to develop “lein” library and include it to shadow-cljs as dependency? My goal is to develop module and during this development test it in separated project as lein and shadow dependency.

I was even thinking about use the same project with project.clj and shadow-cljs.edn and run the same code using both to test it

So all in all I created module to help validate form with specs and fns. I want it to be dependency for lein and shadow-cljs example project (which will be the same project). This example project will have forms in web browser to let developers easy have the demo.

But the main issue is during developing I want to use version from my local hard drive, but when build project I want to use version from github.