Is it just me, or is there some issue with shadow kicking me out of the REPL (`CompilerException java.lang.RuntimeException...`) when debugging core.async code?

I'm getting an unusual number of these REPL terminations when working with core.async. It looks as though, when something goes wrong within a chan (e.g., an error like nil is not allowed in a channel), stuff breaks

I'm sometimes receiving SyntaxErrors when running karma tests. the message looks like this:

{
    "message": "Uncaught SyntaxError: missing ) after argument list\nat ci.js:114889:322\n\nSyntaxError: missing ) after argument list",
    "str": "Uncaught SyntaxError: missing ) after argument list\nat ci.js:114889:322\n\nSyntaxError: missing ) after argument list"
  }

@loganpowell do you have an example of code that kicks you out? how are you debugging core.async code? async in general is pretty tough to debug given its async nature but I don't know what you mean by getting kicked out?

@arne-clojurians I believe there was an issue with karma running tests too early, meaning it started running tests while the file was still being written?

try setting a super high autoWatchBatchDelay http://karma-runner.github.io/2.0/config/configuration-file.html (2000 or so should be good)

@thheller right now, it looks like anytime I get an error inside a chan I'm getting kicked out.

can be please be more specific what you mean by getting kicked out?

I have to restart the Cursive REPL with (shadow.cljs.devtools.api/node-repl)

ah. its a node repl. node crashes on uncaught exceptions I think?

ah, ok

well, the shadow-cljs node server keeps running, but Cursive breaks

maybe a Cursive issue

?

probably not. might be a nREPL issue though

wait ... what do you mean by node server?

you mean shadow-cljs itself right?

the node-repl process probably dies

yessir

λ shadow-cljs clj-repl
shadow-cljs - config: C:\Users\Surface\Projects\clojure\cljs\census-geojson\shadow-cljs.edn  cli version: 2.4.25  node: v8.11.3 shadow-cljs - starting ...
shadow-cljs - server version: 2.4.25
shadow-cljs - server running at 
shadow-cljs - socket REPL running on port 50413
shadow-cljs - nREPL server started on port 3333
shadow-cljs - REPL - see (help)
To quit, type: :repl/quit
[1:0]~shadow.user=>

still running

ok, not a big deal, I can just keep restarting the node-repl session in Cursive. This only seems to happen when working with core.async so I hope to be done with that soon 😄

it is a big deal ... just need more info to piece together what exactly you are doing

so, anything that goes wrong inside a chan seems to kick me out of the session. I'm trying to think of a better way to explain...

I'm still not clear on what you mean by kicked out

cursive gets disconnected?

I get kicked out for putting nil into a chan, when a function that's being called in a go block errors out, when I forget to eval a defn before eval'ing a go block that contains it... yes cursive gets disconnected

the nREPL session doesn't stop in the shadow-cljs clj-repl session. I just have to re-eval (shadow.cljs.devtools.api/node-repl) to start the Cursive REPL again and then re-eval the namespace, functions, etc.

I'm so confused ... can you do a step by step?

I don't have to shadow-cljs clj-repl again

sorry!

For example: step 1) shadow-cljs clj-repl => REPL session starts step 2) Error put into a chan => Error thrown in Cursive REPL (`shadow-cljs` still running, doesn't break) step 3) (shadow.cljs.devtools.api/node-repl) => restart node-repl in Cursive step 4) eval (ns...) and functions to get me back to debugging the core.async logic step 5) bug in code = repeat from step 2)

I'm even more confused now

you are running shadow-cljs clj-repl externally?

and CONNECT remotely with cursive?

or is this all in a terminal outside of cursive?

It's remote

Separate terminal

Would it be better to use the terminal in IDEA?

yes, lots.

Sweet! I will do that! Any particular command I should use in there, just the terminal included with Idea or something to do with Cursive?

any terminal is fine. point is that it doesn't use nrepl and I can see the full session

I think the node process just dies due to the uncaught exception

Gotcha. I'll do that and report on my findings. Thank you again Thomas!

but I don't know what you mean by kicked out still

I don't know how else to describe the behavior of having the shadow-cljs clj-repl still running, but the Cursive REPL dies on me, requiring me to re-eval (shadow.cljs.devtools.api/node-repl) in there to kick start Cursive REPL again. It feels like getting kicked out

Let me try the Idea REPL

I'll be back!

cursive REPL dies on you: does it display anything? can you still type?

cursive ALWAYS starts out on CLJ mode when you connect

running node-repl will switch to CLJS mode

when the node-repl dies you should just be in CLJ mode again

Yes, I'm using Node/NPM interop atm

thats why I don't understand what "kicked out" means

I think that's what's happening, yes, I'm getting "kicked out" of the CLJS session and into CLJ

the connection should still be fine

geez ok

Sorry! 😄

so you are just in CLJ mode and can eval CLJ code normally

Yes, it becomes a Java runtime

CompilerException java.lang.RuntimeException: Unable to resolve symbol: defn in this context, compiling:(null:1:1)

ok the REPL is just stuck in the wrong namespace probably

try (in-ns 'shadow.user) after you get "kicked out"

then just 1 or whatever

just so confirm that the CLJ repl still works

let me try

@thheller I can't find a link to a demo project you had that used shadow-cljs and was reading configs from the html file.

https://github.com/shadow-cljs/quickstart-browser/blob/master/public/index.html#L10 this one?

just calling <script>starter.browser.init({foo: "bar"});</script> instead?

@loganpowell forget about it. I think I know whats happening.

yeah I got that I just thought that it had it right there in the example

weird

mine has a window.onload

maybe that is the issue but I don't see why because the fn gets called but the args don't

same idea. just pass data to the init fn

doesn't work on reload

let me pull your example and try replicate

init is never supposed to get called on reload?

it is

the whole point of init is to only get called once

ok that makes sense

https://github.com/shadow-cljs/quickstart-browser/blob/master/src/starter/browser.cljs

see the entire setup

so what I do is transact app state in the init to add the vars from the html

init is called once on startup from HTML

it calls start

hmmm

on live-reload first stop is called and then start after loading the code

whatever happened in init never happens again

and is not supposed to

ok that makes sense

if it gets called again then yes it won't have any arguments

then in my case it does get called again

do you either have it marked as an :dev/after-load or :after-load in the config?

yes I do 😬

ok. so you split the init into 2 functions. one that can be called again (ie. doesn't use args) and one that puts the config somewhere safe

Thanks for that I was reading the docs trying to figure out how to handle it all

Also is there a client side routing lib you recommend?

no I don't do recommendations 😉

LOL

I don't know any to be honest. I have my own super basic one that I use for my work projects

@loganpowell

[7:1]~cljs.user=> (require '[cljs.core.async :as a])
nil
[7:1]~cljs.user=> (a/go (throw (ex-info "foo" {})))
<eval>:1
(function (){var c__34073__auto__ = cljs.core.async.chan.call(null,(1));
                                                         ^

TypeError: Cannot read property 'call' of undefined
    at <eval>:1:58
    at <eval>:89:3
    at Script.runInThisContext (vm.js:65:33)
    at runInThisContext (vm.js:199:38)
    at global.SHADOW_NODE_EVAL ([stdin]:75:30)
    at Object.shadow$cljs$devtools$client$node$node_eval [as node_eval] (C:\Users\thheller\code\shadow-cljs\.shadow-cljs\builds\node-repl\dev\out\cljs-runtime\shadow\cljs\devtools\client\node.cljs:25:16)
    at shadow.cljs.devtools.client.node/node-eval (C:\Users\thheller\code\shadow-cljs\.shadow-cljs\builds\node-repl\dev\out\cljs-runtime\shadow\cljs\devtools\client\node.cljs:48:30)
    at Object.repl-expr (C:\Users\thheller\code\shadow-cljs\.shadow-cljs\builds\node-repl\dev\out\cljs-runtime\shadow\cljs\devtools\client\env.cljs:91:16)
    at Object.shadow$cljs$devtools$client$node$repl_invoke [as repl_invoke] (C:\Users\thheller\code\shadow-cljs\.shadow-cljs\builds\node-repl\dev\out\cljs-runtime\shadow\cljs\devtools\client\node.cljs:48:13)
    at shadow.cljs.devtools.client.node/repl-invoke (C:\Users\thheller\code\shadow-cljs\.shadow-cljs\builds\node-repl\dev\out\cljs-runtime\shadow\cljs\devtools\client\node.cljs:116:6)
[7:1]~cljs.user=> (+ 1 2)
3

Ok

@loganpowell when I do the above in nrepl it breaks

I see, so nREPL issue

it doesn't help me if you post an example I cannot execute myself

🙂

I have absolutely no clue what you code does

I apologize

I was being lazy

but I can reproduce that the nrepl gets stuck in an unusable state

forgive my laziness. You're being generous and I, greedy

I just don't know exactly what I'm doing wrong

yeah understandable. nrepl is a total mess and I don't understand whats going on half the time either

Your example helps me understand what you need for me to help you help me

ok, no worries! Without a hitch otherwise. The NPM interop is flawless

🙏

FWIW just executing (js/process.exit 1) breaks the entire thing

haha

if the node process dies it breaks the entire nrepl session

but only the nrepl session, normal repl is fine

correct, shadow's repl keeps on humming

ok, onwards! Thank you again

always a model of patience

https://github.com/thheller/shadow-cljs/issues/370

After some experimenting with wrapping AudioWorklet with clojurescript, I found goog.defineClass, it works with "watch", but when I release, I encounter

Closure compilation failed with 1 errors
--- csound_wasm/browser.cljs:201
Unsupported class definition expression.

maybe there's another way around this https://developers.google.com/web/updates/2017/12/audio-worklet somehow grabbing the prototypes and convert it to object...

well in watch the code isn't processed by closure

so maybe you are just doing something you are not supposed to

yes, there's a lot of not supposed to, when it comes to mixing classes with clojurescript...

I've never dealt with this kind of interop.

yeah classes are a bit annoying

this might do it

https://gist.github.com/thheller/7f530b34de1c44589f4e0671e1ef7533

what I came up with was

(def CsoundWorkletNode
  (goog.defineClass
   js/AudioWorkletNode
   #js {:constructor
        (this-as that
          (fn [ctx]
            ((.-superClass_ that) ctx "csound-processor")))}))

class MyWorkletNode extends AudioWorkletNode {
  constructor(context) {
    super(context, 'my-worklet-processor');
  }
}

just replace React.Component with AudioWorkletNode

first of all this goog.defineClass is totally invalid

(goog/defineClass ...) or (js/goog.defineClass ...)

that the other one works is accidental

and this-as must be the first inside the fn not outside

and what is .-superClass_?

the error changed

Closure compilation failed with 1 errors
--- csound_wasm/browser.cljs:192
The class must be defined by an object literal

I guess super

(def CsoundWorkletNode
  (js/goog.defineClass
    js/AudioWorkletNode
    #js {:constructor
         (fn [ctx]
           (js/super ctx "csound-processor"))}))

?

your version

Closure compilation failed with 1 errors
--- externs.shadow.js:11
Parse error. 'identifier' expected

haha doh. it probably tried to generate externs for super

I thought I was doing simple optimizations

don't tell anyone I posted this but try

(def CsoundWorkletNode
  (js/goog.defineClass
    js/AudioWorkletNode
    #js {:constructor
         (fn [ctx]
           (js* "super({}, {});" ctx "csound-processor"))}))

[slack] it's back up

@thheller this is the error message from "who knows who"

Closure compilation failed with 1 errors
--- csound_wasm/browser.cljs:193
Parse error. Semi-colon expected

hmm yeah js* is weird. better not use it

what is the point of the class exactly?

I don't get it. I guess the logic is, that only the newest browser support audioworklet, and old ecmascript can't compile classes anyway. Not sure what's the logic.

And if this is something that is decided by w3c, then I guess more is coming.

might be like web components where you MUST use class with extends or else it breaks

CLJS can not currently emit that

you could try writing actual JS and calling a CLJS fn

dunno how much sense that makes though

hmm yes... I need this shit twice, one for the global scope, another for script processor scope.

do the worklets behave like workers?

I could write some js and pass into it a js object from clojurescript, to run the code defined in cljs land

yes

ie. can they call importScripts?

almost, in the audioworklet, the import script is a fetch, that must be over https

so not file:// protocol, localhost tough considered "safe"

it's shit if you ask me

it seems extremely weird to me

chrome devtools also don't seem to show how the code is loaded

https://googlechromelabs.github.io/web-audio-samples/audio-worklet/basic/hello-audio-worklet.html

lol, it's even crackling a bit, which is the main point of preventing with audioworklet

I know absolutely nothing about audio processing so I have no idea what the point of any of this is 😛

previously there was audioProcessorNode, that would get latencies if you changed the dom or something.

did you try the other method from the gist I posted? no goog.defineClass?

uh, did your gist get lost when the slack was down?

https://gist.github.com/thheller/7f530b34de1c44589f4e0671e1ef7533

ah no.. wait

just replace React.Component with whatever class

https://gist.github.com/thheller/36332574918b974a3e4996efcb7457d2#file-web-component-v1-cljs-L2

the Reflect.construct call might also work. it was necessary for web components a while back

not sure if it still is though. that was 2 years ago

ok nice, I saw similar thing here http://www.50ply.com/blog/2012/07/08/extending-closure-from-clojurescript/ surprised to see mutations on defn

2 mins...

yeah its weird

hang on though. how are you building those extra files?

looks like you use a dedicated build for that?

yes, I have a dedicated build for the processor/worker

don't do that 😛

compile then as a module?

:modules
{:shared {:entries [cljs.core] :depends-on #{}}
 :main {:entries [demo.app] :depends-on #{:shared}}
 :audio1 {:entries [demo.audio1] :depends-on #{:base} :web-worker true}}

in the main browser you load shared.js + main.js

context.audioWorklet.addModule('/js/audio1.js')

no idea if this works for the audio things though

yes I think I would trip on this sooner or later

it was intended for actual webworkers

the audio files will become huge otherwise since each will contain its own cljs.core version

not exactly ideal either way but worth a try

doesn't fix the class problem though

the idea here

(set! (.. component-fn -prototype -constructor) my-component)

oh thats copy&paste error

should be my-component instead of component-fn

makes sense

I think I have to sweat over this a bit, im getting

Uncaught TypeError: Illegal invocation
    at Object.goog.object.extend (goog.object.object.js:610)
    at browser.cljs:212

(goog.object/extend CsoundWorkletNode.prototype js/AudioWorkletNode.prototype)

it compiles tough, good news

CsoundWorkletNode.prototype this is rarely valid CLJS code

(.. CsoundWorkletNode -prototype)

don't try to cheat the system. you never know when it breaks

but yeah the illegal invocation is the exception I got with web components I think

try the web components Reflect stuff

yup, I still get the same error, changed it to see what would happen, the double dot macro I don't find to be so good looking, but will use it when/if needed 🙂

ok

I'm getting confused about that HTMLComponent parts, I assume I don't need them?

(defn component []
  (js/AudioWorkletNode #js [] component))

(set! (.-prototype component)
      (js/Object.create (.-prototype js/AudioWorkletNode)
                        #js {:constructor (fn [ctx])}))

you removed the Reflect call

@hlolli just a small tip, I suggest you try to using goog.object/set instead of set!, it's easier to read and is adv compilation proof

thats the only important bit

ah ok, my misunderstanding

I don't think this is gonna work either

(defn component []
  (js/Reflect.construct js/AudioWorkletNode #js [] component))

(set! (.-prototype component)
      (js/Object.create  (.-prototype js/AudioWorkletNode)
                         #js {:constructor (fn [ctx])}))

(def context (new js/AudioContext))

(-> (.addModule context.audioWorklet "./csound-wasm-worklet-processor.js")
    (.then (fn [] (new component context))))

Uncaught (in promise) TypeError: Failed to construct 'AudioWorkletNode': 2 arguments required, but only 0 present.
    at new csound_wasm$browser$component (browser.cljs:207)

the arguments is the #js [] in the reflect call

but I don't think this is going to work anyways

the :web-worker stuff definitely doesn't work at all

the context created is not like a webworker

it can't eval or do other stuff

it looks like its a strict es6 module environment which makes sense

I think it worked, just need to plugin the worker correctly now

(defn component [ ctx node-name ]
  (js/Reflect.construct js/AudioWorkletNode #js [ ctx node-name ] component))

(set! (.-prototype component)
      (js/Object.create  (.-prototype js/AudioWorkletNode)
                         #js {:constructor (fn [ctx])}))

(def context (new js/AudioContext))

(-> (.addModule context.audioWorklet "./csound-wasm-worklet-processor.js")
    (.then (fn [] (this-as that (new component context "csound-processor")))))

Uncaught (in promise) DOMException: Failed to construct 'AudioWorkletNode': AudioWorkletNode cannot be created: The node name 'csound-processor' is not defined in AudioWorkletGlobalScope.

ok, then I skip the :web-worker flag and keep the modules?

no modules won't work with this

ok, so I keep it like this 🙂

to be honest all of this looks downright hostile towards CLJS

OOP all over the place and special loading restrictions

I bet you've never seen this 🙂

Uncaught TypeError: Cannot use 'in' operator to search for 'StopIteration' in undefined
    at csound-wasm-worklet-processor.js:187
    at csound-wasm-worklet-processor.js:2133

I think I should just write the processor in javascript, that can be forgiven...

goog.iter.StopIteration="StopIteration"in goog.global

which means, f*, I need to write even more in the processor script than I imagined

yeah its a ES6 module scope

goog.global = this; but this is undefined in a module scope

is there a closure option to compile to this?

hmm?

there's :es6-strict and :es6-typed, maybe :es6-module smth... dunno

dunno. the closure library release used by CLJS is very old. it might be fixed in newer versions already.