yep that works. Ive only done it with the full lein integration prevously

@schpaencoder yes that is accurate. lacking a lot of details but accurate.

@eoliphant sorry I didn't get to it yesterday. I'll see if I find some time today

the idea with :npm-module would be to compile to <project>/material-dashboard-react/src/cljs and then in the src/index.js to require("./cljs/your.main").start()

ie. calling (ns your.main) (defn start [] ...)

from CLJS you can then require the (:require ["components/...."]) but the downside with this is that you can't require using relative paths

since that would make shadow-cljs try to import them

its probably not much cleaner than the other way

> yes that is inaccurate. lacking a lot of details but accurate. Which is it?

haha oops

yes. that is accurate. 😛

just woke up

Hehe

fixed. 😉

why are you asking? any issues?

hey @thheller no probs, no idea how you manage to keep this going and presumably have a life and what have you lol I’ll play around with it some. I’m admittedly a little weak with this stuff, more of a backend middleware guy, so usually just beat up on my ui guys to get the toolchains working, when I needed to do UI stuff lol. But man, the js spec folks, really need to figure something out. I’m definitely a big fan of ‘practical’ and organic standards like say spring in the java world. But when one is looking at some .js code and says something like ‘oh, that’s a webpack import’, where’s , we may have issues lol. I think the whole transpilation thing was a good idea that’s gone haywire.

hey #theller i can’t get that transform-input-paths plugin to work. babel keeps saying it can’t find it, based on the authors notes, it looks like it mightbe targeted at v7 or something. gonna try the root-imports plugin that it alludes to

would dumping all this crap into an NWB project, and creating an exporter index.js potentially be a way around this? https://github.com/insin/nwb/blob/master/docs/guides/ReactComponents.md#libraries

is there a trick to embedding shadow-cljs in a clojure project?

I’m trying to start the server and watch from my CIDER REPL. server starts, but when I run a watch it starts complaining about cljs/tools/reader

compile works fine

Well, i’m both annoyed and a little pleased lol. I sent a note to those guys, about the need to have this packaged properly and got a response that they’re working on it. So as I was starting to try to setup my own repo, discovered that there’s already an NPM distro, for the free/lite one. So I just installed that and it seems to work. Now just having an issue with the styles/options. the default appearance is what you’d expect, nice and material, so the css is sort of working. but it doesn’t seem to be honoring the options that are passed in

[reagent.core :as r]
            ["material-dashboard-react/components/CustomButtons/Button" :default Button]
            ["material-dashboard-react/assets/jss/material-dashboard-react/components/buttonStyle" ]))

(def mui-button (r/adapt-react-class Button))

(defn render [ctx]
  [:<>
   [:div [mui-button {:color "info"} "Hi There"]]
   [:div

   [:button {:on-click #(<cmd ctx :update :dec)} "Decrement"]

I’m guessing it’s a transient dependency thing

i use it with cursive. I start the watch from the command line, attach to it, then select to flip over to cljs

yeah, that’s how I do it at work. my website is already a clojure project tho so I was hoping I could have it all in one REPL

@eoliphant so it shows “Hi there” but isn’t respecting “color”?

ah yeah, i found it to be clunkier to run even though it was ‘better’ integrated

yep, it’s really weird

So renders as it should in the material style

I know reagent does it for you, but I also tried {"color" "info"} and clj-jsing it as well

grabbing at straws, but try using :> Button {:color "info"} "Hello"

yeah good point was thinking about that

dammit lol

as you learn in science, only vary one thing at a time lol

so, I was doing this, and switching over to keechma

@eoliphant the default .babelrc shipping with the material-dashboard stuff worked after all. the transform-import-paths wasn't required.

and hadn’t updated my :after-load directive

so just running babel in the directory worked fine

@lilactown it complains about tools.reader how? that might just be dependency conflict

lilactown.core> (shadow/watch :client)
[:client] Configuring build.
[:client] Compiling ...
:watching
lilactown.core> [:client] Build completed. (132 files, 2 compiled, 2 warnings, 1.72s)

------ WARNING #1 --------------------------------------------------------------
 File: cljs/tools/reader/edn.cljs:121:36
--------------------------------------------------------------------------------
 118 |                    (recur (inc i) (+ d (* uc base)))))))
 119 |            (js/String.fromCharCode uc))))))
 120 | 
 121 | (def ^:private ^:const upper-limit (int \uD7ff))
------------------------------------------^-------------------------------------
 cljs.core/bit-or, all arguments must be numbers, got [string number] instead
--------------------------------------------------------------------------------
 122 | (def ^:private ^:const lower-limit (int \uE000))
 123 | 
 124 | (defn- read-char*
 125 |   [rdr backslash opts]
--------------------------------------------------------------------------------

------ WARNING #2 --------------------------------------------------------------
 File: cljs/tools/reader/edn.cljs:122:36
--------------------------------------------------------------------------------
 119 |            (js/String.fromCharCode uc))))))
 120 | 
 121 | (def ^:private ^:const upper-limit (int \uD7ff))
 122 | (def ^:private ^:const lower-limit (int \uE000))
------------------------------------------^-------------------------------------
 cljs.core/bit-or, all arguments must be numbers, got [string number] instead
--------------------------------------------------------------------------------
 123 | 
 124 | (defn- read-char*
 125 |   [rdr backslash opts]
 126 |   (let [ch (read-char rdr)]
--------------------------------------------------------------------------------

if I trigger a re-compile this turns into an error

error how?

warning looks legit

[:client] Compiling ...
[:client] Build failure:
------ ERROR -------------------------------------------------------------------
 File: jar:file:/Users/will/.m2/repository/org/clojure/tools.reader/1.0.0-alpha4/tools.reader-1.0.0-alpha4.jar!/cljs/tools/reader/edn.cljs:121:1
--------------------------------------------------------------------------------
 118 |                    (recur (inc i) (+ d (* uc base)))))))
 119 |            (js/String.fromCharCode uc))))))
 120 | 
 121 | (def ^:private ^:const upper-limit (int \uD7ff))
-------^------------------------------------------------------------------------
Can't redefine a constant at line 121 cljs/tools/reader/edn.cljs
--------------------------------------------------------------------------------
 122 | (def ^:private ^:const lower-limit (int \uE000))
 123 | 
 124 | (defn- read-char*
 125 |   [rdr backslash opts]
--------------------------------------------------------------------------------

1.0.0-alpha4 that is defniitely the wrong version

we are up to 1.3.1 I think

ok, but that still needs to get commonjs’ed or whatever right? I’m poking trhough the npm version of the free one, and say the button class, has all the stuff fixed up that we discussed.

...
var _withStyles = require("@material-ui/core/styles/withStyles");

var _withStyles2 = _interopRequireDefault(_withStyles);

var _Button = require("@material-ui/core/Button");

var _Button2 = _interopRequireDefault(_Button);

var _buttonStyle = require("../../assets/jss/material-dashboard-react/components/buttonStyle");
...

1.3.0

I was thinkign of just dumping the pro source

@eoliphant yeah thats the code I get by running babel

oh really?

by default?

ok

in the checkout directory

let me try it agian

npm install and then npx babel src -d out

ah but in the free one

yeah

yeah that’s it

i’m gonna drop this pro code

check the .babelrc of the pro version

on top of ti

of it

it its different for some reason copy the free version over

but your’re saying only babel is required

if that’sthe case

well webpack is still sort of required for the Dashboard stuff

then I’ll just move the babelrc over

since that has an image import

right because of that

dunno about the pro stuff

i’m less concered about thouse

i’m probably gonna just recreate that in cljs

so when I run lein deps :tree I’m seeing this:

Possibly confusing dependencies found:
[org.clojure/tools.nrepl "0.2.12" :exclusions [org.clojure/clojure]]
 overrides
[thheller/shadow-cljs "2.4.24"] -> [org.clojure/tools.nrepl "0.2.13"]

Consider using these exclusions:
[thheller/shadow-cljs "2.4.24" :exclusions [org.clojure/tools.nrepl]]

though yeah.. I’m just gonna move all the build crap over to the pro dir.. Then I should just be able to point to the build dir as a local repo in my actual projects package.json right?

I don’t have tools.nrepl in my project.clj <_<

nor profiles.clj afaict

@lilactown thats always added. but look for tools.reader

lein itself depends on nrepl

@eoliphant the pro version doesn't have a .babelrc?

reader only appears once and it’s 1.3.0

nope

uses all the create-react-app defaults i guess

trying this one more time, I just cleared out some unused deps

@lilactown that can't be. the alpha4 must come from somewhere

remember the profiles in project.clj maybe something in there is responsible. or a plugin.

given that they have this working for the free one, I guess they were trying to figure out how to handle the paid version, but seems like that would just be a private npm repo, and give you a login when you pay or something

just need the .babelrc and the package.json really.

bower stuff etc is irrelevant

yeah will diff the package scripts since the pro has more deps and the lib build stuff isn’t in the pro

gonna be a little annoyed if this just works lol, this could have been couple lines in the readme lol

I’m afraid it’s cider-nrepl middleware

hmm that should really be using a more recent version

when in doubt just add clojurescript and tools.reader to your deps in case you don't have that

I’m on a slightly older version of CIDER. the latest uses 1.1.1

thats still really old

I hadn’t added clojurescript or tools.reader to my deps yet

I figured shadow-cljs would handle those for me

yeah gotta be a bit more careful with deps in project.clj

it should work if you list shadow-cljs first

🙃 I just put tools.reader in my deps and it worked

FML. that was like an hour of my morning 😂

should have just ran shadow-cljs from my terminal. oh well, now I know

yeah thats why I don't recommend using lein. just too many things you need to watch out for 😛

I should switch to deps.edn

is that any less painful?

well .. not really ... just different pains

lol

👋

i was trying to find the best way to eval some code on server mode startup last night, and I saw that a config option to run a worker was added for server mode, but it seems to have been removed. Whats the best way to do some eval on server startup?

👋 @iam

any one using shadow- with keechma?

i’m having some weird problem with the hot reload

shadow-cljs is calling the reload func

@chazbone you could probably use https://shadow-cljs.github.io/docs/UsersGuide.html#build-hooks

@lee.justin.m thanks! 😄 I’ll get to it!

but the ui isn’t updating

the only thing is that those hooks will run even when you are just compiling (as opposed to running a server), so you might have to do some detection of the environment

yeah thats alright with me, a little bit of overhead is fine

@chazbone you probably want https://shadow-cljs.github.io/docs/UsersGuide.html#clj-run

see the section below with {:shadow/requires-server true}

@eoliphant thats probably not related to shadow-cljs but what you do in your reload func

maybe the re-render you are calling just decides to no re-render or stops early

well I just noticed something that I’m working to reproduce, it appears figwheel is pushing one more file than shadow does prior to the reload getting called

i’m setting up shadow on the keechma default template app

never looked at keechma but if you have some code I can look at it would help

ok yeah just reproduced it. You want the whole project zipped up? but in short, in their template ui/main namespace, there’s a render function. say changing a bit of text in it, causes the following in figwheel

Figwheel: loaded these files
15:27:21.506 utils.cljs?rel=1532803397043:71 ("../keech_proj/ui/main.js" "../keech_proj/ui.js" "../keech_proj/core.js")

shadow-cljs: load JS keech_proj/ui/main.cljs
15:59:49.184 browser.cljs:25 shadow-cljs: load JS keech_proj/ui.cljs
15:59:49.185 browser.cljs:25 shadow-cljs: call keech-proj.core/reload

I'm gonna need the full code

sure

<mailto:[email protected]|[email protected]> or some git repo is fine

sent to your email. Just jacked shadow into it. Has a shadow-cljs.edn, package.json, etcand changed the name of the .js in the index.html everything else should be more or less as it was generated

whats the lein command to run the figwheel version?

(defn reload []
  (let [current @running-app]
    (println "RESTART" (true? current))
    (if current
      (app-state/stop! current start-app!)
      (start-app!))))

should just be lein figwheel

this might not be correct?

if current version is running, stop it

and you have to change thename of the .js

so the first call of reload just stops everything but never restarts it?

in index.html

yeah read weird to me too, but it works in figwheel

I don't know anything about keechma but that looks suspicious to me

ah nvm, the extra start-app! is probably called once stop finishes

yeah that makes sense

where is this shadow-cljs.edn config from?

i just copied it over from antoehr one of my projects and stripped the extraneous stuff out

added the deps to match the project.clj etc

ok then go to your other project and take out the hud preload

that is really old and not required since forever ago 😉

lol gotcha

also when copying deps leave out clojure,clojurescript and shadow-cljs itself

they will be ignored anyways

ok, yeah I’d migrated from lein, to shadow, to deps, just carried those foward iguess

so far I can't see anything from the shadow-cljs side. everything seems to be doing what it should do

yeah the only thing i saw, vs figwheel was that fighwheel was repushing the core

in addition to the other 2

ah I think I know

yep thats it

note the def app-definition in .core. that holds a reference to ui which is a map of the components

since core is never updated the re-render doesn't change

core is nore reloaded because its not directly dependent

Yeah I was wondering if it had something to do with the way it does dependencies

if you instead turn the def into defn everything works again

I see your ^:dev/once option, is there like a ^:dev/always?

ah

(defn app-definition []
  (-> {:components    ui
       :controllers   controllers
       :subscriptions subscriptions
       :html-element  (.getElementById js/document "app")}
      (dataloader/install datasources edb-schema)
      (forms/install keech-proj-forms/forms keech-proj-forms/forms-automount-fns)))

(defonce running-app (clojure.core/atom nil))

(defn start-app! []
  (prn "START-APP!")
  (reset! running-app (app-state/start! (app-definition))))

ok even better

shadow-cljs doesn't reload ALL dependents like figwheel seems to do

because that can get reaally slow and shouldn't be required

unless you do something like that where one namespace holds global state from another

could add a reload-all or something setting but no way I'm making that the default 😛

yeah that makes more sense

ah no

lol

seems to work just fine if you just change it to a defn

I was thinking more for cases like this, that perhaps couldn’t be solved as you’ve done it here

exceptions not rules lol

you are the first to report such a case

and yes there is a ^:dev/always you can put on the ns

lol well then I do feel special lol. Gonna drop a note in their channel as well

https://github.com/thheller/shadow-cljs/issues/349

and thanks for the help on that material ui stuff. good lord. lol, literally a like 2 sentence readme would have made most of that avoidable

ah I made a test repo for that btw

pushed it here: https://github.com/thheller/shadow-mui-dashboard-test

only tested the basic components but it seems to work https://github.com/thheller/shadow-mui-dashboard-test/blob/master/src/main/app/views.cljs

gotta shoot them a note… so they can add it for the pro or whaever

yeah I’ve gotten a page or so done looks prettty fine