Fork me on GitHub
#shadow-cljs
<
2018-03-18
>
mhuebert18:03:50

This is great, will trim down my already-very-small shadow-cljs.edn even further

mhuebert18:03:29

Plus handles the case of multiple on-reloads elegantly

thheller18:03:01

I was curious if I could trim down the config even more and looked at your maria/editor config

thheller18:03:15

:http-handler shadow.http.push-state/handle push-state is now the default so you can leave that out too 🙂

thheller18:03:24

not seeing anything obvious to remove besides that

mhuebert21:03:53

oh, that’s great

thheller16:03:33

@bhauman I found :figwheel-always and :figwheel-noload on the ns name. do you support other metadata currently? and what exactly does :figwheel-always do? just always load it even if it wasn't compiled?

bhauman16:03:56

yes the intention of :figwheel-always is to reload the ns on every code change

bhauman16:03:45

:figwheel-noload is to not load on code change

bhauman16:03:57

:figwheel-load is to load regardless of whether it is in the dependency chain or not

thheller16:03:30

will think about the others

bhauman16:03:47

:dev/once makes sense

thheller16:03:49

yeah added that last minute. like it way more than :dev/never-load

mhuebert18:03:59

I like :dev/once too

mhuebert18:03:50

This is great, will trim down my already-very-small shadow-cljs.edn even further

escherize19:03:37

@thheller Thanks -- the shim file has fixed my first issue with p5! And I just read through that part of the manual (good docs). The next error I'm getting is The required JS dependency "/assets/p5.tiledmap.js" is not available, it was required by "p5/tiled_map.cljs". Now, p5.tiledmap isn't in npm. I'm trying to require it by using the file locally, but can't quite get all the dots connected.

thheller19:03:29

not on npm? thats a first. 🙂

thheller19:03:44

where is it from then?

thheller19:03:54

@escherize so the only issue I see is that the require('../p5') is incorrect. it should be require('p5')

thheller19:03:30

otherwise it would attempt to load p5 from a relative file instead of npm

thheller19:03:07

but if you change that you can put the file into your source path and just require it directly via (:require ["/abs/path/p5.tiledmap.js"]) like you were trying?

thheller19:03:25

or even better just publish that file to npm with the fix 😉

thheller20:03:46

it would be almost usable from what play-cljs if the require here was changed to require("./p5") (ie. minus one dot) https://github.com/oakes/play-cljs/blob/master/src/js/p5.tiledmap.js#L5

thheller20:03:13

then you could just (:require ["/js/p5.tiledmap"]) in the shim file

escherize20:03:50

Thanks for your help. I’m away from my computer now but will do this and report when I get back. Thanks for your help again!!!